From: Leif Lindholm <leif.lindholm@linaro.org>
To: edk2-devel@lists.01.org
Subject: Re: [PATCH edk2-platforms] Platform/Hisilicon: fix D02 driver indentation errors
Date: Wed, 4 Oct 2017 09:24:06 +0100 [thread overview]
Message-ID: <20171004082406.ufull7clghge2spz@bivouac.eciton.net> (raw)
In-Reply-To: <20171004081233.5095-1-leif.lindholm@linaro.org>
Note to self: --subject-prefix="PATCH edk2-platforms" goes on git
format-patch command line, not send-email.
Grabbing some coffee.
/
Leif
On Wed, Oct 04, 2017 at 09:12:33AM +0100, Leif Lindholm wrote:
> When building with a somewhat recent toolchain (GCC 6.3), the D02
> platform fails due to (the implicit) -Werror=misleading-indentation.
>
> Cc: Heyi Guo <heyi.guo@linaro.org>
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
> ---
> Silicon/Hisilicon/Drivers/SasV1Dxe/SasV1Dxe.c | 4 ++--
> Silicon/Hisilicon/Pv660/Drivers/PcieInitDxe/PcieInitLib.c | 10 +++++-----
> 2 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/Silicon/Hisilicon/Drivers/SasV1Dxe/SasV1Dxe.c b/Silicon/Hisilicon/Drivers/SasV1Dxe/SasV1Dxe.c
> index d876565a7d..b18b56ddb2 100644
> --- a/Silicon/Hisilicon/Drivers/SasV1Dxe/SasV1Dxe.c
> +++ b/Silicon/Hisilicon/Drivers/SasV1Dxe/SasV1Dxe.c
> @@ -497,8 +497,8 @@ STATIC VOID hisi_sas_v1_init(struct hisi_hba *hba, PLATFORM_SAS_PROTOCOL *plat)
> !(dma_rx_status & DMA_RX_STATUS_BUSY))
> break;
>
> - // Wait for status change in polling
> - NanoSecondDelay (100);
> + // Wait for status change in polling
> + NanoSecondDelay (100);
> }
> }
>
> diff --git a/Silicon/Hisilicon/Pv660/Drivers/PcieInitDxe/PcieInitLib.c b/Silicon/Hisilicon/Pv660/Drivers/PcieInitDxe/PcieInitLib.c
> index 3581b41c90..3739a36e64 100644
> --- a/Silicon/Hisilicon/Pv660/Drivers/PcieInitDxe/PcieInitLib.c
> +++ b/Silicon/Hisilicon/Pv660/Drivers/PcieInitDxe/PcieInitLib.c
> @@ -570,7 +570,7 @@ EFI_STATUS AssertPciePcsReset(UINT32 HostBridgeNum,UINT32 Port)
> if (pcs_local_status_checked)
> DEBUG((EFI_D_ERROR, "pcs local reset status read failed\n"));
>
> - count = 0;
> + count = 0;
> do {
> MicroSecondDelay(1000);
> count ++;
> @@ -583,7 +583,7 @@ EFI_STATUS AssertPciePcsReset(UINT32 HostBridgeNum,UINT32 Port)
> if (hilink_status_checked)
> DEBUG((EFI_D_ERROR, "error:pcs assert reset failed\n"));
>
> - return EFI_SUCCESS;
> + return EFI_SUCCESS;
> }
>
> EFI_STATUS DeassertPciePcsReset(UINT32 HostBridgeNum, UINT32 Port)
> @@ -616,7 +616,7 @@ EFI_STATUS DeassertPciePcsReset(UINT32 HostBridgeNum, UINT32 Port)
> if (pcs_local_status_checked)
> DEBUG((EFI_D_ERROR, "pcs deassert reset failed!\n"));
>
> - count = 0;
> + count = 0;
> do {
> MicroSecondDelay(1000);
> RegRead(pcie_subctrl_base[HostBridgeNum] + PCIE_SUBCTRL_SC_PCIE_HILINK_PCS_RESET_ST_REG, hilink_reset_status);
> @@ -627,7 +627,7 @@ EFI_STATUS DeassertPciePcsReset(UINT32 HostBridgeNum, UINT32 Port)
> if (hilink_status_checked)
> DEBUG((EFI_D_ERROR, "pcs deassert reset failed!\n"));
>
> - return EFI_SUCCESS;
> + return EFI_SUCCESS;
> }
>
> VOID PcieGen3Config(UINT32 HostBridgeNum, UINT32 Port)
> @@ -777,7 +777,7 @@ EFI_STATUS HisiPcieClockCtrl(UINT32 soctype, UINT32 HostBridgeNum, UINT32 Port,
> if (clock_status_checked)
> DEBUG((EFI_D_ERROR, "clock operation failed!\n"));
>
> - return EFI_SUCCESS;
> + return EFI_SUCCESS;
> }
>
> VOID PcieSpdSet(UINT32 soctype, UINT32 HostBridgeNum, UINT32 Port, UINT8 Spd)
> --
> 2.11.0
>
prev parent reply other threads:[~2017-10-04 8:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-04 8:12 [PATCH] Platform/Hisilicon: fix D02 driver indentation errors Leif Lindholm
2017-10-04 8:15 ` Ard Biesheuvel
2017-10-04 8:24 ` Leif Lindholm [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171004082406.ufull7clghge2spz@bivouac.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox