From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::232; helo=mail-wm0-x232.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x232.google.com (mail-wm0-x232.google.com [IPv6:2a00:1450:400c:c09::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C8F6E2095B073 for ; Thu, 5 Oct 2017 06:11:13 -0700 (PDT) Received: by mail-wm0-x232.google.com with SMTP id i124so2052684wmf.3 for ; Thu, 05 Oct 2017 06:14:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=QuDrKytxeQpF3lO+orYQB1IGB1C38M6qDIPyZVon2Yw=; b=C8FoZJ/YjtySj4YWz1bGyJ+8J/fLpHpxeUd2pDv72S/hW+qrORWsLZAhVR1S9uPD9Q GPOOcL/HmsjRvrtOgbmgkRCQHrJMGztalYE8/Ky42XGnod5t03UMY+RxOw5xZYEJFhCH SxmATQN2L2gcNE+G0InMAzq00D9n6apoxK1J4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=QuDrKytxeQpF3lO+orYQB1IGB1C38M6qDIPyZVon2Yw=; b=YEEL01nfCEWad7yOKEhHLunBk7RNMRIuEOqhyng0AprF7jZcqnmCtyjU0+7Iux0Dqc Ngl7EJ6ISXQqZB0pjLPgKce6ezIEmv6QFGAkqlRdDnvv6j8w7j1hlnMacBjU4AIO5+Hp PBBIh5g1i5hM9+ZWzSy61+K9xEQn34GzsUTj+UPSKfw+BuVl4+mu8jh8ZPjkqFeXrx7B dvzKP0K+MfufwWAVloYIy8yVpBLy8U39m1qtKytcc2iED0aQcN59MpLMOqGAhE+4Yw15 0pNhPIHXl9RuGKXa0MUZNXtKSpMTd39wG/gwQIZtx8OHB8niPXLDARZR8MbiIREijeLh Aypg== X-Gm-Message-State: AHPjjUjydDXcGuoelwyYueM4HQs2xnZyXGFk2eeBaDNVDq+mxzGmg537 XnPyMxS0H7RmSEWOFBBPdUFPEQ== X-Google-Smtp-Source: AOwi7QAEn8fzLQBmfVAMi1xNMYnpKK6XX5tV9+ZBg4ZFC+bmxn3JP//Nq4HYmckjTnmDA7rQSJcGcw== X-Received: by 10.28.51.133 with SMTP id z127mr17891418wmz.110.1507209274771; Thu, 05 Oct 2017 06:14:34 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id w82sm25278254wme.5.2017.10.05.06.14.32 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 05 Oct 2017 06:14:33 -0700 (PDT) Date: Thu, 5 Oct 2017 14:14:31 +0100 From: Leif Lindholm To: Marcin Wojtas Cc: edk2-devel@lists.01.org, ard.biesheuvel@linaro.org, nadavh@marvell.com, neta@marvell.com, kostap@marvell.com, jinghua@marvell.com, agraf@suse.de, jsd@semihalf.com, Piotr =?iso-8859-1?Q?Kr=F3l?= Message-ID: <20171005131431.aadxlekozvjlwfuk@bivouac.eciton.net> References: <1506304319-8620-1-git-send-email-mw@semihalf.com> <1506304319-8620-3-git-send-email-mw@semihalf.com> MIME-Version: 1.0 In-Reply-To: <1506304319-8620-3-git-send-email-mw@semihalf.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [platforms: PATCH 02/10] Marvell/Drivers: MvSpiDxe: Log and return correct error X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Oct 2017 13:11:14 -0000 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit On Mon, Sep 25, 2017 at 03:51:51AM +0200, Marcin Wojtas wrote: > From: Piotr Król > > Make log information clear where it came from and return correct code to > be interpreted by caller. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Piotr Król > Signed-off-by: Marcin Wojtas > --- > Platform/Marvell/Drivers/Spi/MvSpiDxe.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Platform/Marvell/Drivers/Spi/MvSpiDxe.c b/Platform/Marvell/Drivers/Spi/MvSpiDxe.c > index aab20fc..0c6b624 100755 > --- a/Platform/Marvell/Drivers/Spi/MvSpiDxe.c > +++ b/Platform/Marvell/Drivers/Spi/MvSpiDxe.c > @@ -240,7 +240,8 @@ MvSpiTransfer ( > } > > if (Iterator >= SPI_TIMEOUT) { > - DEBUG ((DEBUG_ERROR, "Timeout\n")); > + DEBUG ((DEBUG_ERROR, "%s: Timeout\n", __FUNCTION__)); Should this not be %a as per Ard's suggestion, lest the output become "MSirnfr: ..."? (I can fold in on commit if you can confirm.) / Leif > + return EFI_TIMEOUT; > } > } > > -- > 1.8.3.1 >