From: Leif Lindholm <leif.lindholm@linaro.org>
To: Marcin Wojtas <mw@semihalf.com>
Cc: edk2-devel@lists.01.org, ard.biesheuvel@linaro.org,
nadavh@marvell.com, neta@marvell.com, kostap@marvell.com,
jinghua@marvell.com, agraf@suse.de, jsd@semihalf.com
Subject: Re: [platforms: PATCH 00/10] Armada 70x0/80x0 SPI improvements
Date: Thu, 5 Oct 2017 14:30:23 +0100 [thread overview]
Message-ID: <20171005133023.xiffuuabakeeyywf@bivouac.eciton.net> (raw)
In-Reply-To: <1506304319-8620-1-git-send-email-mw@semihalf.com>
On Mon, Sep 25, 2017 at 03:51:49AM +0200, Marcin Wojtas wrote:
> Hi,
>
> Finally I found time to respin SPI patchset. As agreed, I extracted
> style fixes from dynamic flash detection patch, but its main part
> is kept aside for now until FlashId table (and additionally both SPI
> protocols land in the edk2 mainline). A lot of minor fixes were
> implemented, details can be found in the commit logs and changelog
> below.
>
> Patches are available in the github:
> https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/spi-upstream-r20170925
>
> I'm looking forward to the comments or remarks.
If the two minor changes I have suggested are acceptable - for the series:
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
As mentioned, I can fold these in before pushing. Let me know.
/
Leif
> Best regards,
> Marcin
>
> Changelog
> v1 -> v2
> Slightly improve commit log prefixes.
>
> 1/10
> * Move documentation to Silicon/Marvell
> * Update PortingGuide with new paths in edk2-platforms repository
>
> 2/10
> * Correct error print
>
> 4/10
> * Sort PCDs
>
> 7/10
> * Simplify change and remove additional local variable
>
> 8/10
> * Correct FileSize type and let it really compile for ARM and AARCH64
>
> 9/10
> * modify macros -> s/SPI_ERASE_SIZE_/SIZE_/
>
> 10/10
> * New patch
>
> 3/10, 5/10, 6/10
> * Add Reviewed-by's
>
> Ard Biesheuvel (3):
> Marvell/Applications/SpiTool: Fix bug in error test
> Marvell/Applications/FirmwareUpdate: Fix 32-bit issues
> Marvell/Applications/SpiTool: Fix 32-bit issues
>
> Joe Zhou (1):
> Marvell/Drivers: MvSpiDxe: Fix write bug
>
> Marcin Wojtas (4):
> Marvell/Applications/SpiTool: Enable configurable CS and SCLK mode
> Platform/Marvell/Armada70x0: set CS and SCLK Mode for SPI flash
> Marvell/Drivers: MvSpiFlash: Fix usage of erase size parameter
> Marvell/Drivers: MvSpiFlash: Minor style fix
>
> Nir Erez (1):
> Silicon/Marvell: Refactor Documentation
>
> Piotr Król (1):
> Marvell/Drivers: MvSpiDxe: Log and return correct error
>
> Platform/Marvell/Applications/FirmwareUpdate/FUpdate.c | 6 +-
> Platform/Marvell/Applications/SpiTool/SpiFlashCmd.c | 13 +-
> Platform/Marvell/Applications/SpiTool/SpiFlashCmd.inf | 2 +
> Platform/Marvell/Armada/Armada70x0.dsc | 2 +
> Platform/Marvell/Documentation/Drivers/EepromDriver.txt | 96 -----
> Platform/Marvell/Documentation/Drivers/I2cDriver.txt | 64 ----
> Platform/Marvell/Documentation/Drivers/SpiDriver.txt | 116 ------
> Platform/Marvell/Documentation/PortingGuide/ComPhy.txt | 45 ---
> Platform/Marvell/Documentation/PortingGuide/I2c.txt | 20 --
> Platform/Marvell/Documentation/PortingGuide/Mdio.txt | 7 -
> Platform/Marvell/Documentation/PortingGuide/Mpp.txt | 48 ---
> Platform/Marvell/Documentation/PortingGuide/PciEmulation.txt | 31 --
> Platform/Marvell/Documentation/PortingGuide/Phy.txt | 45 ---
> Platform/Marvell/Documentation/PortingGuide/Pp2.txt | 35 --
> Platform/Marvell/Documentation/PortingGuide/Reset.txt | 7 -
> Platform/Marvell/Documentation/PortingGuide/Spi.txt | 16 -
> Platform/Marvell/Documentation/PortingGuide/SpiFlash.txt | 23 --
> Platform/Marvell/Documentation/PortingGuide/Utmi.txt | 35 --
> Platform/Marvell/Drivers/Spi/Devices/MvSpiFlash.c | 36 +-
> Platform/Marvell/Drivers/Spi/Devices/MvSpiFlash.h | 6 +
> Platform/Marvell/Drivers/Spi/Devices/MvSpiFlash.inf | 1 +
> Platform/Marvell/Drivers/Spi/MvSpiDxe.c | 6 +-
> Platform/Marvell/Marvell.dec | 3 +
> Silicon/Marvell/Documentation/Drivers/EepromDriver.txt | 96 +++++
> Silicon/Marvell/Documentation/Drivers/I2cDriver.txt | 64 ++++
> Silicon/Marvell/Documentation/Drivers/SpiDriver.txt | 116 ++++++
> Silicon/Marvell/Documentation/PortingGuide.txt | 377 ++++++++++++++++++++
> 27 files changed, 707 insertions(+), 609 deletions(-)
> delete mode 100644 Platform/Marvell/Documentation/Drivers/EepromDriver.txt
> delete mode 100644 Platform/Marvell/Documentation/Drivers/I2cDriver.txt
> delete mode 100644 Platform/Marvell/Documentation/Drivers/SpiDriver.txt
> delete mode 100644 Platform/Marvell/Documentation/PortingGuide/ComPhy.txt
> delete mode 100644 Platform/Marvell/Documentation/PortingGuide/I2c.txt
> delete mode 100644 Platform/Marvell/Documentation/PortingGuide/Mdio.txt
> delete mode 100644 Platform/Marvell/Documentation/PortingGuide/Mpp.txt
> delete mode 100644 Platform/Marvell/Documentation/PortingGuide/PciEmulation.txt
> delete mode 100644 Platform/Marvell/Documentation/PortingGuide/Phy.txt
> delete mode 100644 Platform/Marvell/Documentation/PortingGuide/Pp2.txt
> delete mode 100644 Platform/Marvell/Documentation/PortingGuide/Reset.txt
> delete mode 100644 Platform/Marvell/Documentation/PortingGuide/Spi.txt
> delete mode 100644 Platform/Marvell/Documentation/PortingGuide/SpiFlash.txt
> delete mode 100644 Platform/Marvell/Documentation/PortingGuide/Utmi.txt
> create mode 100644 Silicon/Marvell/Documentation/Drivers/EepromDriver.txt
> create mode 100644 Silicon/Marvell/Documentation/Drivers/I2cDriver.txt
> create mode 100644 Silicon/Marvell/Documentation/Drivers/SpiDriver.txt
> create mode 100644 Silicon/Marvell/Documentation/PortingGuide.txt
>
> --
> 1.8.3.1
>
next prev parent reply other threads:[~2017-10-05 13:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-25 1:51 [platforms: PATCH 00/10] Armada 70x0/80x0 SPI improvements Marcin Wojtas
2017-09-25 1:51 ` [platforms: PATCH 01/10] Silicon/Marvell: Refactor Documentation Marcin Wojtas
2017-09-25 1:51 ` [platforms: PATCH 02/10] Marvell/Drivers: MvSpiDxe: Log and return correct error Marcin Wojtas
2017-10-05 13:14 ` Leif Lindholm
2017-09-25 1:51 ` [platforms: PATCH 03/10] Marvell/Drivers: MvSpiDxe: Fix write bug Marcin Wojtas
2017-09-25 1:51 ` [platforms: PATCH 04/10] Marvell/Applications/SpiTool: Enable configurable CS and SCLK mode Marcin Wojtas
2017-09-25 1:51 ` [platforms: PATCH 05/10] Platform/Marvell/Armada70x0: set CS and SCLK Mode for SPI flash Marcin Wojtas
2017-09-25 1:51 ` [platforms: PATCH 06/10] Marvell/Applications/SpiTool: Fix bug in error test Marcin Wojtas
2017-09-25 1:51 ` [platforms: PATCH 07/10] Marvell/Applications/FirmwareUpdate: Fix 32-bit issues Marcin Wojtas
2017-09-25 1:51 ` [platforms: PATCH 08/10] Marvell/Applications/SpiTool: " Marcin Wojtas
2017-09-25 1:51 ` [platforms: PATCH 09/10] Marvell/Drivers: MvSpiFlash: Fix usage of erase size parameter Marcin Wojtas
2017-10-05 13:28 ` Leif Lindholm
2017-09-25 1:51 ` [platforms: PATCH 10/10] Marvell/Drivers: MvSpiFlash: Minor style fix Marcin Wojtas
2017-10-05 13:30 ` Leif Lindholm [this message]
2017-10-05 13:37 ` [platforms: PATCH 00/10] Armada 70x0/80x0 SPI improvements Marcin Wojtas
2017-10-05 14:54 ` Marcin Wojtas
2017-10-05 15:50 ` Leif Lindholm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171005133023.xiffuuabakeeyywf@bivouac.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox