From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::230; helo=mail-wm0-x230.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x230.google.com (mail-wm0-x230.google.com [IPv6:2a00:1450:400c:c09::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 9DD2D2095B06C for ; Thu, 5 Oct 2017 06:27:04 -0700 (PDT) Received: by mail-wm0-x230.google.com with SMTP id m72so2171322wmc.1 for ; Thu, 05 Oct 2017 06:30:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=90QJyEfF3aOo1Q4Lg4p9C19eb0ah2NT+B49zb6aMvic=; b=Popl59Lcd1JogCVwmcOFPOKLH76Axj8r+lAB88/QKvXLlUiVWiS9LE1CvEVzB3lnFH lO6MbF8R6Sh6BoRrlEBpEGKE7Mo08IBLQNQ+uEMMgKFEgo4gxilzt+LbMNbQSsex3u+3 1/qDg8kJ7jY6gDMiWpvAC9DUfF4FpW9LdLIy0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=90QJyEfF3aOo1Q4Lg4p9C19eb0ah2NT+B49zb6aMvic=; b=HP0GNCIvt14QgMAsX+eN037bY57qbPLv6kUC14fuv3AMCZCvjncIYWIK9y3/rZGJ6O N8ZggHLfoR7Qrd/VF1b+tB8yO81HTzawzszU8N0PXIwLqe/2DNZcJNUoKfDwPHQpsWqy WVynCNJFrThEA6yXgDA1yXH3fKkG+4+9o7pHXPgOYAaQgcRgHfoOukYVqHwe7NKIhz4a Z01E/QYTRvaBg/H9QyVIO69N7rCfcwvTSbaS75Iwxb1ddmab7Va6h0EuVeE5dV7KY0pC mT+3CTrQQ3dn4QNH6N5mm+01vILqUSBqMPy4qpexAswEyAE1T+vQjXWkobRN+O7fUpLm aKMg== X-Gm-Message-State: AMCzsaVbhBEEhRzWuhFahlnZs1BdFDmvOWP64EpC1YyYklCEDSaTBt+f Hwf+kE5mSwbFiDoSMq46WjPC1g== X-Google-Smtp-Source: AOwi7QCUlfCZs5gSkbB3jOLCkA2ICVaPdunWnQh3Vv09L6tT2suu7Jzlg3YKB0U3yxnNWuEkJUSUFg== X-Received: by 10.28.0.66 with SMTP id 63mr3223971wma.7.1507210225702; Thu, 05 Oct 2017 06:30:25 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id k82sm8106193wmf.19.2017.10.05.06.30.24 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 05 Oct 2017 06:30:24 -0700 (PDT) Date: Thu, 5 Oct 2017 14:30:23 +0100 From: Leif Lindholm To: Marcin Wojtas Cc: edk2-devel@lists.01.org, ard.biesheuvel@linaro.org, nadavh@marvell.com, neta@marvell.com, kostap@marvell.com, jinghua@marvell.com, agraf@suse.de, jsd@semihalf.com Message-ID: <20171005133023.xiffuuabakeeyywf@bivouac.eciton.net> References: <1506304319-8620-1-git-send-email-mw@semihalf.com> MIME-Version: 1.0 In-Reply-To: <1506304319-8620-1-git-send-email-mw@semihalf.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [platforms: PATCH 00/10] Armada 70x0/80x0 SPI improvements X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Oct 2017 13:27:05 -0000 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit On Mon, Sep 25, 2017 at 03:51:49AM +0200, Marcin Wojtas wrote: > Hi, > > Finally I found time to respin SPI patchset. As agreed, I extracted > style fixes from dynamic flash detection patch, but its main part > is kept aside for now until FlashId table (and additionally both SPI > protocols land in the edk2 mainline). A lot of minor fixes were > implemented, details can be found in the commit logs and changelog > below. > > Patches are available in the github: > https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/spi-upstream-r20170925 > > I'm looking forward to the comments or remarks. If the two minor changes I have suggested are acceptable - for the series: Reviewed-by: Leif Lindholm As mentioned, I can fold these in before pushing. Let me know. / Leif > Best regards, > Marcin > > Changelog > v1 -> v2 > Slightly improve commit log prefixes. > > 1/10 > * Move documentation to Silicon/Marvell > * Update PortingGuide with new paths in edk2-platforms repository > > 2/10 > * Correct error print > > 4/10 > * Sort PCDs > > 7/10 > * Simplify change and remove additional local variable > > 8/10 > * Correct FileSize type and let it really compile for ARM and AARCH64 > > 9/10 > * modify macros -> s/SPI_ERASE_SIZE_/SIZE_/ > > 10/10 > * New patch > > 3/10, 5/10, 6/10 > * Add Reviewed-by's > > Ard Biesheuvel (3): > Marvell/Applications/SpiTool: Fix bug in error test > Marvell/Applications/FirmwareUpdate: Fix 32-bit issues > Marvell/Applications/SpiTool: Fix 32-bit issues > > Joe Zhou (1): > Marvell/Drivers: MvSpiDxe: Fix write bug > > Marcin Wojtas (4): > Marvell/Applications/SpiTool: Enable configurable CS and SCLK mode > Platform/Marvell/Armada70x0: set CS and SCLK Mode for SPI flash > Marvell/Drivers: MvSpiFlash: Fix usage of erase size parameter > Marvell/Drivers: MvSpiFlash: Minor style fix > > Nir Erez (1): > Silicon/Marvell: Refactor Documentation > > Piotr Król (1): > Marvell/Drivers: MvSpiDxe: Log and return correct error > > Platform/Marvell/Applications/FirmwareUpdate/FUpdate.c | 6 +- > Platform/Marvell/Applications/SpiTool/SpiFlashCmd.c | 13 +- > Platform/Marvell/Applications/SpiTool/SpiFlashCmd.inf | 2 + > Platform/Marvell/Armada/Armada70x0.dsc | 2 + > Platform/Marvell/Documentation/Drivers/EepromDriver.txt | 96 ----- > Platform/Marvell/Documentation/Drivers/I2cDriver.txt | 64 ---- > Platform/Marvell/Documentation/Drivers/SpiDriver.txt | 116 ------ > Platform/Marvell/Documentation/PortingGuide/ComPhy.txt | 45 --- > Platform/Marvell/Documentation/PortingGuide/I2c.txt | 20 -- > Platform/Marvell/Documentation/PortingGuide/Mdio.txt | 7 - > Platform/Marvell/Documentation/PortingGuide/Mpp.txt | 48 --- > Platform/Marvell/Documentation/PortingGuide/PciEmulation.txt | 31 -- > Platform/Marvell/Documentation/PortingGuide/Phy.txt | 45 --- > Platform/Marvell/Documentation/PortingGuide/Pp2.txt | 35 -- > Platform/Marvell/Documentation/PortingGuide/Reset.txt | 7 - > Platform/Marvell/Documentation/PortingGuide/Spi.txt | 16 - > Platform/Marvell/Documentation/PortingGuide/SpiFlash.txt | 23 -- > Platform/Marvell/Documentation/PortingGuide/Utmi.txt | 35 -- > Platform/Marvell/Drivers/Spi/Devices/MvSpiFlash.c | 36 +- > Platform/Marvell/Drivers/Spi/Devices/MvSpiFlash.h | 6 + > Platform/Marvell/Drivers/Spi/Devices/MvSpiFlash.inf | 1 + > Platform/Marvell/Drivers/Spi/MvSpiDxe.c | 6 +- > Platform/Marvell/Marvell.dec | 3 + > Silicon/Marvell/Documentation/Drivers/EepromDriver.txt | 96 +++++ > Silicon/Marvell/Documentation/Drivers/I2cDriver.txt | 64 ++++ > Silicon/Marvell/Documentation/Drivers/SpiDriver.txt | 116 ++++++ > Silicon/Marvell/Documentation/PortingGuide.txt | 377 ++++++++++++++++++++ > 27 files changed, 707 insertions(+), 609 deletions(-) > delete mode 100644 Platform/Marvell/Documentation/Drivers/EepromDriver.txt > delete mode 100644 Platform/Marvell/Documentation/Drivers/I2cDriver.txt > delete mode 100644 Platform/Marvell/Documentation/Drivers/SpiDriver.txt > delete mode 100644 Platform/Marvell/Documentation/PortingGuide/ComPhy.txt > delete mode 100644 Platform/Marvell/Documentation/PortingGuide/I2c.txt > delete mode 100644 Platform/Marvell/Documentation/PortingGuide/Mdio.txt > delete mode 100644 Platform/Marvell/Documentation/PortingGuide/Mpp.txt > delete mode 100644 Platform/Marvell/Documentation/PortingGuide/PciEmulation.txt > delete mode 100644 Platform/Marvell/Documentation/PortingGuide/Phy.txt > delete mode 100644 Platform/Marvell/Documentation/PortingGuide/Pp2.txt > delete mode 100644 Platform/Marvell/Documentation/PortingGuide/Reset.txt > delete mode 100644 Platform/Marvell/Documentation/PortingGuide/Spi.txt > delete mode 100644 Platform/Marvell/Documentation/PortingGuide/SpiFlash.txt > delete mode 100644 Platform/Marvell/Documentation/PortingGuide/Utmi.txt > create mode 100644 Silicon/Marvell/Documentation/Drivers/EepromDriver.txt > create mode 100644 Silicon/Marvell/Documentation/Drivers/I2cDriver.txt > create mode 100644 Silicon/Marvell/Documentation/Drivers/SpiDriver.txt > create mode 100644 Silicon/Marvell/Documentation/PortingGuide.txt > > -- > 1.8.3.1 >