From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::22b; helo=mail-wm0-x22b.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x22b.google.com (mail-wm0-x22b.google.com [IPv6:2a00:1450:400c:c09::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 21A852095B089 for ; Thu, 5 Oct 2017 08:46:48 -0700 (PDT) Received: by mail-wm0-x22b.google.com with SMTP id m72so2988697wmc.1 for ; Thu, 05 Oct 2017 08:50:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=M2KHHnhMUPuOyPWXmR9mjnIt0kjGrCkQ/WlsAiBAzx0=; b=WxccPqkJJN5hu71GVVSyUN9I3PrCNRY87miFAXHhJooFaRq40WQAtKXJxpKaoECzZr GhquFO+SnekSBieErA9CwQ5EiVnragQgrmKzkPcT7CogPaW0Z3TMuigFHQatlF2PGlH+ VR6bDpdMG60KRrY4cOrTvsTU6tSb04MBUyjv0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=M2KHHnhMUPuOyPWXmR9mjnIt0kjGrCkQ/WlsAiBAzx0=; b=RrX0L4YMsIwIPI+LiTHNt5AuNyPuCWdKh9IMfVGD7zVSu4zRQ/ZmTm0fzfgDm9313y MtBZPZafymCtyYLaXf5WUo3AFeG+vdbHKLvI3xB0SKFVz4YSCiZRjl4KdG8RSLKveZAB U/WgLbjP0M4aRlWrwPx0Xa8C6yOA7mQvpdQKjgqNMkrxMw09rqgddvqGietYgyA24joV XG7e21lr2la1iyDo80bfhASYBFiyIUiEpE4wt7A8KT/4be2LPGHd3nYZ0EaO+e1iA0bs ccGX1eZfFLd62gTF2SiVa9ZrdZKEbrfxN+9HnXBSz9PTLSYAOtyNsfvUJCd4CEsEk2CA hXQQ== X-Gm-Message-State: AHPjjUiWW78/oeaYoSKB+tXcff4rHoX4rLT4zAbLGnXG+eU+k9toWDLd f+EPIf6OadglNIo3SOqE2rXWDw== X-Google-Smtp-Source: AOwi7QCBPjC1zdZ/GGytK0RT2R6gDfFvziGeel/mHy3Rir1lgOG+bZFHVwzOy2afqCfHSvOlDLrUYw== X-Received: by 10.28.30.139 with SMTP id e133mr17662284wme.8.1507218610130; Thu, 05 Oct 2017 08:50:10 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id f5sm106062wmg.10.2017.10.05.08.50.08 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 05 Oct 2017 08:50:08 -0700 (PDT) Date: Thu, 5 Oct 2017 16:50:07 +0100 From: Leif Lindholm To: Marcin Wojtas Cc: edk2-devel-01 , Ard Biesheuvel , nadavh@marvell.com, Neta Zur Hershkovits , Kostya Porotchkin , Hua Jing , Alexander Graf , semihalf-dabros-jan Message-ID: <20171005155007.vknjlkn6ahum6gfy@bivouac.eciton.net> References: <1506304319-8620-1-git-send-email-mw@semihalf.com> <20171005133023.xiffuuabakeeyywf@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [platforms: PATCH 00/10] Armada 70x0/80x0 SPI improvements X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Oct 2017 15:46:49 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Oct 05, 2017 at 04:54:26PM +0200, Marcin Wojtas wrote: > Leif, > > 2017-10-05 15:37 GMT+02:00 Marcin Wojtas : > > Hi Leif, > > > > 2017-10-05 15:30 GMT+02:00 Leif Lindholm : > >> > >> On Mon, Sep 25, 2017 at 03:51:49AM +0200, Marcin Wojtas wrote: > >> > Hi, > >> > > >> > Finally I found time to respin SPI patchset. As agreed, I extracted > >> > style fixes from dynamic flash detection patch, but its main part > >> > is kept aside for now until FlashId table (and additionally both SPI > >> > protocols land in the edk2 mainline). A lot of minor fixes were > >> > implemented, details can be found in the commit logs and changelog > >> > below. > >> > > >> > Patches are available in the github: > >> > https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/spi-upstream-r20170925 > >> > > >> > I'm looking forward to the comments or remarks. > >> > >> If the two minor changes I have suggested are acceptable - for the series: > >> Reviewed-by: Leif Lindholm > >> > >> As mentioned, I can fold these in before pushing. Let me know. > >> > > Here: > https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/spi-upstream-r20171005 > > you can find rebased commits, with 2 modifications you pointed (%a and > use BaseLib size types). Added RB's everywhere and tested - working > fine. Many thanks - pushed as a4591fe0b0..13f15e8113. / Leif