From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::229; helo=mail-wm0-x229.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x229.google.com (mail-wm0-x229.google.com [IPv6:2a00:1450:400c:c09::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0AAAD2095B07C for ; Thu, 5 Oct 2017 13:22:29 -0700 (PDT) Received: by mail-wm0-x229.google.com with SMTP id u138so4119268wmu.5 for ; Thu, 05 Oct 2017 13:25:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=WU2nG5vdV0V8+JiLZyBP7BwHY02nvfw6QMRXpXgjcbY=; b=HXw+OgbN+NeN4IoTnEFU4ZxSucLerWTV7KaNghvmX2P3iboHgQLeJtyiY/EiLr5pZR X3L55MIJq6C7HeImD5MqF7AYYI14Y/0qQqq3kdL/pyed9kGorkzydILTaR3uNSFC5g4K cKT45dWRTYObmQemTDKEipkYpYHeJ0UFu1vBQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=WU2nG5vdV0V8+JiLZyBP7BwHY02nvfw6QMRXpXgjcbY=; b=Dvun3Cz0aCDmy4/axUbCLIPtitDgq3JsPXlXIdmhFXmfudQyY3B4U4Ftqc2hd3V5/y Tk2c0hMU1y0Al/8DRhrMiIMym+9sj/1KI7Gnbbb02Y+8K5WMbg+LQfKqrNgsX6Nm1WVf 1FKX9/Uh7heyMga72wpWKOwWPT+OU442s31pgcnP2Z95HLomvH+BBd0Pma2bfdQVvh8A m3ApVC5nsy95PFo8B2fOt3n835DBSgeMsqj8r8pzhX3Q31QEVCV8nmFbiVtmbpQ6og3k jnKiCPmG301bYao8CGt9rLeKCWr2RCXmOOq+acvJu/0WntOm1P5JpYbLhbjnTmdvl6Tv 4WAw== X-Gm-Message-State: AMCzsaXKiYcCdtrsILOITdHGVFaUtmQzn/k0/KUsh8KvkGgekSMTNCIz 3DcqtnA0VMa9RC8hbjZvqXqLvA== X-Google-Smtp-Source: AOwi7QCNbRt4QxvqSSHNAIpX3eS3h5h16nBuu4dOvsR7EM+mZ9Zr833qiEJexN0qMqyGboeHJVHc7w== X-Received: by 10.28.191.215 with SMTP id o84mr246796wmi.153.1507235151513; Thu, 05 Oct 2017 13:25:51 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id r21sm144913wmd.26.2017.10.05.13.25.50 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 05 Oct 2017 13:25:50 -0700 (PDT) Date: Thu, 5 Oct 2017 21:25:48 +0100 From: Leif Lindholm To: Ard Biesheuvel Cc: "edk2-devel@lists.01.org" , evan.lloyd@arm.com, matteo.carlini@arm.com Message-ID: <20171005202548.dkyovf2pb2pdmnln@bivouac.eciton.net> References: <20170921162345.11724-1-evan.lloyd@arm.com> <20170921162345.11724-4-evan.lloyd@arm.com> <20171005201501.hbdkecp3el5q4e3o@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH 3/4] ArmPkg/ArmGicDxe: Expose HardwareInterrupt2 protocol X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Oct 2017 20:22:30 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Oct 05, 2017 at 09:15:41PM +0100, Ard Biesheuvel wrote: > On 5 October 2017 at 21:15, Leif Lindholm wrote: > > On Thu, Sep 21, 2017 at 05:23:43PM +0100, evan.lloyd@arm.com wrote: > >> From: Ard Biesheuvel > >> > >> The existing HardwareInterrupt protocol lacked a means to configure the > >> level/edge properties of an interrupt. The new HardwareInterrupt2 > >> protocol introduced this capability. > >> This patch updates the GIC drivers to provide the new interfaces. > >> The changes comprise: > >> Update to use HardwareInterrupt2 protocol > >> Additions to register info in ArmGicLib.h > >> Added new functionality (GetTriggerType and SetTriggerType) > >> > >> The requirement for this change derives from a problem detected on ARM > >> Juno boards, but the change is of generic (ARM) relevance. > >> > >> This commit is in response to review on the mailing list and, as > >> suggested there, rolls Girish's updates onto Ard's original example. > >> > >> Contributed-under: TianoCore Contribution Agreement 1.0 > > > > This patch has lagged: Ard, are you happy to confirm this one could be > > updated to 1.1? > > > > Absolutely. Many thanks: series pushed as fe4049471b..baee8efb36 / Leif