From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::232; helo=mail-wm0-x232.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x232.google.com (mail-wm0-x232.google.com [IPv6:2a00:1450:400c:c09::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0360721EA15A4 for ; Fri, 6 Oct 2017 08:58:44 -0700 (PDT) Received: by mail-wm0-x232.google.com with SMTP id f4so8823985wme.0 for ; Fri, 06 Oct 2017 09:02:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=zXWzOxS3uhEmiq9HyHlxLS2G2GK+eIBeoS6BJYRVslc=; b=TaaPibY+eJ+984Y4M2rEToSd5w2s9LrFH9Hdomh0xBmLgvktmEKno7GZCNJxMQ9fXa 1MmLZR0x6Hk7l2FbKYwsr/Ss0YBGUJMxvUzz5PB1PUDfCuXo9OBCl7hTyOVHK/vJ4Xjg o4kM5P9bO5sX15ZAMFIGIYOga4rmrtM7yPuuI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=zXWzOxS3uhEmiq9HyHlxLS2G2GK+eIBeoS6BJYRVslc=; b=KhefjNpBLngdtGRfcbIjPSjfP9YpOLK0CkFepLL/8CDLGsKS2Xi+29L8mYAnXXZxs5 7RWOhh+Vje2SxtykI6ZcIBOzWTZy1ySmSfjkTKas+DZgNJIMoikBxxJz/lffo9VrscUs w2iN+U7GwXE7ssYt8H1qONBmLpyju1ZX61j83GIOnNMhhhttJZVLxlHBgbITzysJ0Iul kwRb3FcYxpbI6YNs5i3T+6eTmbCeKqj7C9gboCe1M0NFZJAOBIoMdr2HD8gmkqUqu++B QfI3+Dx+bZWBdgvOGRa0oKssCEFtpaV7ufgnQi6DwiHhc7qkhVOP1+QifEAIRwyYKd3w vO/w== X-Gm-Message-State: AMCzsaVzqnav4ep+NaCKrcMlGX+nJP5R6f66YrA//GDTb9eWWnSFw1TX wf+hUIXXAxj/Nz0dWlL13wTIgfSWjpA= X-Google-Smtp-Source: AOwi7QBAg49jButtGPfDlnhH1uMGSTfDJUGfWXd0Xr5LX5eoMcPV7jE+HlZjZL4XHAmeRdw4xq2gnQ== X-Received: by 10.28.129.197 with SMTP id c188mr2054064wmd.58.1507305727392; Fri, 06 Oct 2017 09:02:07 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id p95sm3839958wrc.53.2017.10.06.09.02.06 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 06 Oct 2017 09:02:06 -0700 (PDT) Date: Fri, 6 Oct 2017 17:02:04 +0100 From: Leif Lindholm To: Marcin Wojtas Cc: edk2-devel@lists.01.org, ard.biesheuvel@linaro.org, nadavh@marvell.com, neta@marvell.com, kostap@marvell.com, jinghua@marvell.com, jsd@semihalf.com Message-ID: <20171006160204.7cjh43zknjggz5as@bivouac.eciton.net> References: <1507276278-3608-1-git-send-email-mw@semihalf.com> <1507276278-3608-5-git-send-email-mw@semihalf.com> MIME-Version: 1.0 In-Reply-To: <1507276278-3608-5-git-send-email-mw@semihalf.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [platforms: PATCH 4/5] Marvell/Drivers: Pp2Dxe: Rework PHY handling X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Oct 2017 15:58:45 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Oct 06, 2017 at 09:51:17AM +0200, Marcin Wojtas wrote: > Hitherto PHY handling in Pp2Dxe was not flexible. It allowed for using > only single MDIO controller, which may not be true on Armada 80x0 SoCs. > For this purpose introduce the MDIO description, using the new structures > and template in MvHwDescLib. This change enables addition of multiple > CP110 hardware blocks with MDIO controllers. > > This change required different PHY handling and obtaining data over > desired MDIO bus. Now given Pp2 port is matched with the PHY via > its index in gMarvellTokenSpaceGuid.PcdPhyDeviceIds. The PHY itself > is mapped to the MDIO controller, using > gMarvellTokenSpaceGuid.PcdPhy2MdioController. Also obtaining > SMI addresses was moved to the PHY initialization routine. > All above allow for much cleaner and logical PHY description > in the .dsc file. > > Update PortingGuide documentation accordingly and Armada 70x0 DB > NIC/PHY description. Like for previous patches, can we have: - symbolic names for things that can be given symbolic names. - Pcds describing boolean arrays have an "Enabled" appended to their name? / Leif