From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::22f; helo=mail-wm0-x22f.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x22f.google.com (mail-wm0-x22f.google.com [IPv6:2a00:1450:400c:c09::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1602321EA15BA for ; Fri, 6 Oct 2017 12:54:00 -0700 (PDT) Received: by mail-wm0-x22f.google.com with SMTP id k4so9975221wmc.1 for ; Fri, 06 Oct 2017 12:57:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=xcy8MNOj8VQFdljXRftAiXNyBkujl9vYmTmyCLS+xus=; b=FtGy6ENJdBoSkRiC0f+kivuTB4HohcbIquPvwks/AA8hmGmdai1/lASEb8I4SEu3z1 Tj81b4O/79Pi/p4BNCiu0COawCBQH3Ntza4weLPz0VgnM4TvGiPWjOL7khQttwmCcrUY TTaLSaeI0MlD3mvfvN5X2jIpX/EdKHulW+aUk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=xcy8MNOj8VQFdljXRftAiXNyBkujl9vYmTmyCLS+xus=; b=HcG8ox8OoyptY0BeZX4vKGkvPBKAr/eCNnSaz7aHL7BTYet8+NHmsKDUTuTcLNY/0G kYBG2j0Z6GoL+SdMhXJCO5q6N+bdcdKg1jbBM4Wy+njjaX3nHfIamQotTEAr3Q1o9VrK thiwU1IcQ9R9C23cshH2AyTyzzXyHZExUj59jB9Xnu8xJF3Tphwz8jN5/M1cNG4jYg4W nTfkiMZM7FuhcBx9zPMDGJC0jD5+09vjAuRkuO0COdlG9Y9EFKJ/aYpF4zQYC/amR9ZJ aKTbObXuOI5u+bQLW1kC/P/XUDwuj+ytjckZVa2tl6PZc4HWmU1gDvN69sybrCoeiaa+ X+Uw== X-Gm-Message-State: AMCzsaXIatAndsy7beqtClREcBnWSLJWbcNaXE3GvHzYjGoL9I+zwvId GhKs9A2NA1P84brfCeinU6/NQA== X-Google-Smtp-Source: AOwi7QCMzq4DT3lon0qCA7nIJ5AQO+UWhUcPNcW4SXSXDa6yfhfimpfPYxHHMq4+KSBGl4VYwY+1sA== X-Received: by 10.223.161.139 with SMTP id u11mr3222050wru.207.1507319843594; Fri, 06 Oct 2017 12:57:23 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id q4sm2457723wmd.19.2017.10.06.12.57.22 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 06 Oct 2017 12:57:22 -0700 (PDT) Date: Fri, 6 Oct 2017 20:57:20 +0100 From: Leif Lindholm To: Marcin Wojtas Cc: edk2-devel-01 , Ard Biesheuvel , nadavh@marvell.com, Neta Zur Hershkovits , Kostya Porotchkin , Hua Jing , semihalf-dabros-jan Message-ID: <20171006195720.e366vmowwsqmgr63@bivouac.eciton.net> References: <1507276278-3608-1-git-send-email-mw@semihalf.com> <1507276278-3608-4-git-send-email-mw@semihalf.com> <20171006155743.f4sdanashx4htwbq@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [platforms: PATCH 3/5] Marvell/Library: UtmiLib: Move devices description to MvHwDescLib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Oct 2017 19:54:01 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Oct 06, 2017 at 09:26:43PM +0200, Marcin Wojtas wrote: > 2017-10-06 17:57 GMT+02:00 Leif Lindholm : > > On Fri, Oct 06, 2017 at 09:51:16AM +0200, Marcin Wojtas wrote: > >> This patch introduces UTMI description, using the new structures > >> and template in MvHwDescLib. This change enables more flexible > >> addition of multiple CP with UTMI PHY's and also significantly > >> reduces amount of used PCD's for that purpose. Update PortingGuide > >> documentation accordingly. > >> > >> This patch replaces string-based description of Utmi on > >> Armada 70x0 DB with new, reduced format. > >> > >> Contributed-under: TianoCore Contribution Agreement 1.1 > >> Signed-off-by: Marcin Wojtas > >> --- > >> Platform/Marvell/Armada/Armada70x0.dsc | 7 +- > >> Platform/Marvell/Include/Library/MvHwDescLib.h | 47 ++++++ > >> Platform/Marvell/Library/UtmiPhyLib/UtmiPhyLib.c | 149 ++++++++++---------- > >> Platform/Marvell/Library/UtmiPhyLib/UtmiPhyLib.h | 1 - > >> Platform/Marvell/Library/UtmiPhyLib/UtmiPhyLib.inf | 11 +- > >> Platform/Marvell/Marvell.dec | 7 +- > >> Silicon/Marvell/Documentation/PortingGuide.txt | 30 ++-- > >> 7 files changed, 142 insertions(+), 110 deletions(-) > >> > >> diff --git a/Platform/Marvell/Armada/Armada70x0.dsc b/Platform/Marvell/Armada/Armada70x0.dsc > >> index d9d126d..04bdf7c 100644 > >> --- a/Platform/Marvell/Armada/Armada70x0.dsc > >> +++ b/Platform/Marvell/Armada/Armada70x0.dsc > >> @@ -111,11 +111,8 @@ > >> gMarvellTokenSpaceGuid.PcdChip0ComPhySpeeds|{ 0x1, 0x6, 0xA, 0x6, 0x6, 0x6 } > >> > >> #UtmiPhy > >> - gMarvellTokenSpaceGuid.PcdUtmiPhyCount|2 > >> - gMarvellTokenSpaceGuid.PcdUtmiPhyRegUsbCfg|L"0xF2440420;0xF2440420" > >> - gMarvellTokenSpaceGuid.PcdUtmiPhyRegUtmiCfg|L"0xF2440440;0xF2440444" > >> - gMarvellTokenSpaceGuid.PcdUtmiPhyRegUtmiUnit|L"0xF2580000;0xF2581000" > >> - gMarvellTokenSpaceGuid.PcdUtmiPhyUtmiPort|L"0x0;0x1" > >> + gMarvellTokenSpaceGuid.PcdUtmiControllers|{ 0x1, 0x1 } > >> + gMarvellTokenSpaceGuid.PcdUtmiPortType|{ 0x0, 0x1 } > > > > Like for 1/5, could we have some entries under a [Define] in a .inc > > (reasonably the same .inc)? > > > > Ok. Any preferences in terms of the name of such file? Unless we can > just put it into Armada.dsc.inc... Not really any preference. Armada.dsc.inc might be fine. / Leif