Re: [platforms: PATCH 1/5] Marvell/Library: ComPhyLib: Remove PCD string parsing

[Leif Lindholm <leif.lindholm@linaro.org>]

On Sat, Oct 07, 2017 at 04:17:23PM +0200, Marcin Wojtas wrote:
> > > On average, we already have .dscs that end up with too long lines.
> > > I am not sure I care about the line length limit in .dsc files, to be
> > > honest.
> > > Certainly, my take on line length restrictions is that their intent is
> > > to increase visibility. If at any point breaking a rule improves
> > > visibility, that is still permissible.
> > >
> > >> 2. If I define stuff e.g. in the .dsc [Defines] section - will they be
> > >> visible in all modules, i.e. would I be able to remove the definitions
> > >> from the ComPhy header? If yes, I guess the longer version above will
> > >> have to be used...
> > >
> > > I will confess my ignorance. Not sure.
> > > If it does, that would mean less duplication, which would be good.
> > > But it would also make a name prefix more important.
> >
> > I need to check it. If it's visible in driver (I guess it is), then
> > let's go with the preix, to which I lean towards anyway.
> 
> The macros defined under [Defines] section are visible only within
> .fdf and .dsc files. I tried both 'DEFINE' and 'EDK_GLOBAL'
> statements, but the library couldn't use it and we have to define
> macros in the header anyway. So we have to make a choice - do you wish
> to use COMPHY_ prefix in PCD values? It may give 130+ signs in such
> case.

I would still prefer the COMPHY_ prefix.

It's a shame about the duplication, but this will still enhance
readability/reviewability.

/
    Leif