From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::236; helo=mail-wm0-x236.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x236.google.com (mail-wm0-x236.google.com [IPv6:2a00:1450:400c:c09::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E833F21FC749A for ; Sat, 7 Oct 2017 07:54:33 -0700 (PDT) Received: by mail-wm0-x236.google.com with SMTP id q124so13019099wmb.0 for ; Sat, 07 Oct 2017 07:57:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=KndwxzCLTzsWftzLbmlVKlVo8bJA62M4xKF7FqvlEwU=; b=N8MlTVw3bfwUCMOUZtpVzliUpXNJ9GTVw+vLv++Y1i1q3ZrXttrpjijFGe9eU9X+xZ bCdpgHLCkiGRRy+oDDc6G8psX8Eku7L07UfIHWGVQSSeHdJi/vHDizsQFTkKaITdhbQk SWkpS3lAX2NZGVzKdhyHqqy7npBrrwMnpr0Hs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=KndwxzCLTzsWftzLbmlVKlVo8bJA62M4xKF7FqvlEwU=; b=B0wFQXtVYn2h8UFokNGIzLsxrfDaDdX03OepkYaopk/jCyGB5yyP4ngjSPpAMz5GOH Tc7361d9tRzXnrn/Vld3OdVA8ozWQSJ19Wd1evXavwvLYvve2V3VUwZ2OGjLnkBMAr1e YbYpk6P0JZAhhOroxQWdWE4MCvyJ9wY7LBRhKBAodbb9QaWMkgPdgb/14rVHokmPuhj4 7phRZ9cmI5+vy3WAH/WBV3BM8g2aF6qMRA9DCng4pkpY8bdyg9G7rDxo+Ck8u4FshByB h94eQWg08xWIB8/z5M/HCcytxHCdDkTV3j1KwEkKotdXSZtKXBaZbCB13Z8sAeAgZBnk NpOA== X-Gm-Message-State: AMCzsaUEXoktLQ5VfyfHuDe86/qSReOfyZwd96diM2Q5DYSCN0y1zVY9 cd+zk8xdSLMOP7fi8N6ihTW43w== X-Google-Smtp-Source: AOwi7QDMTsVPrV8ldqRgHVgbuc7+t3O8KSlSHE4n6PhPsOwSOoDnK5HNWrCMeJn8hP83QWxaplM18w== X-Received: by 10.28.29.68 with SMTP id d65mr4459892wmd.93.1507388277105; Sat, 07 Oct 2017 07:57:57 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id l73sm4383836wmd.47.2017.10.07.07.57.55 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 07 Oct 2017 07:57:55 -0700 (PDT) Date: Sat, 7 Oct 2017 15:57:54 +0100 From: Leif Lindholm To: Marcin Wojtas Cc: edk2-devel-01 , Ard Biesheuvel , nadavh@marvell.com, Neta Zur Hershkovits , Kostya Porotchkin , Hua Jing , semihalf-dabros-jan Message-ID: <20171007145754.wndtw45ooyyawais@bivouac.eciton.net> References: <1507276278-3608-1-git-send-email-mw@semihalf.com> <1507276278-3608-2-git-send-email-mw@semihalf.com> <20171006155215.g63kakcrvhx7ocra@bivouac.eciton.net> <20171006195155.gf2cg3aaqr3dqhoe@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [platforms: PATCH 1/5] Marvell/Library: ComPhyLib: Remove PCD string parsing X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 Oct 2017 14:54:34 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sat, Oct 07, 2017 at 04:17:23PM +0200, Marcin Wojtas wrote: > > > On average, we already have .dscs that end up with too long lines. > > > I am not sure I care about the line length limit in .dsc files, to be > > > honest. > > > Certainly, my take on line length restrictions is that their intent is > > > to increase visibility. If at any point breaking a rule improves > > > visibility, that is still permissible. > > > > > >> 2. If I define stuff e.g. in the .dsc [Defines] section - will they be > > >> visible in all modules, i.e. would I be able to remove the definitions > > >> from the ComPhy header? If yes, I guess the longer version above will > > >> have to be used... > > > > > > I will confess my ignorance. Not sure. > > > If it does, that would mean less duplication, which would be good. > > > But it would also make a name prefix more important. > > > > I need to check it. If it's visible in driver (I guess it is), then > > let's go with the preix, to which I lean towards anyway. > > The macros defined under [Defines] section are visible only within > .fdf and .dsc files. I tried both 'DEFINE' and 'EDK_GLOBAL' > statements, but the library couldn't use it and we have to define > macros in the header anyway. So we have to make a choice - do you wish > to use COMPHY_ prefix in PCD values? It may give 130+ signs in such > case. I would still prefer the COMPHY_ prefix. It's a shame about the duplication, but this will still enhance readability/reviewability. / Leif