From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=104.47.1.80; helo=eur01-ve1-obe.outbound.protection.outlook.com; envelope-from=achin.gupta@arm.com; receiver=edk2-devel@lists.01.org Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0080.outbound.protection.outlook.com [104.47.1.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D96F62095B094 for ; Mon, 9 Oct 2017 01:47:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=yX+DUy7ROHrCYuLwB7nEKPAVyiabseVPg8rL1NX+rBQ=; b=OxfGBNky6I3US43cOW96bKHgPRud3EGIE/HvPDEFnJfC5CpTHKfP8TmtyxW1kXHkyqInHOowVKHD49yfRCNBM5foaVF7c+c+CgNpL1mWgUGDmWZpsXSpuGlRwyaZx8Fb88hS1SJF4xT6nQjGCG+lDPCC7zTH7qGo23Y0WpCY/oQ= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Achin.Gupta@arm.com; Received: from e104320-lin (217.140.96.140) by HE1PR08MB2699.eurprd08.prod.outlook.com (2603:10a6:7:2b::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Mon, 9 Oct 2017 08:51:14 +0000 Date: Mon, 9 Oct 2017 09:52:03 +0100 From: Achin Gupta To: Ard Biesheuvel , Supreeth Venkatesh Cc: Supreeth Venkatesh , "edk2-devel@lists.01.org" , Leif Lindholm , nd@arm.com Message-ID: <20171009085202.GW26498@e104320-lin> References: <20170927185859.27833-1-supreeth.venkatesh@arm.com> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Originating-IP: [217.140.96.140] X-ClientProxiedBy: AM5P190CA0012.EURP190.PROD.OUTLOOK.COM (2603:10a6:206:14::25) To HE1PR08MB2699.eurprd08.prod.outlook.com (2603:10a6:7:2b::30) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e4cf07dc-abf4-43a5-718f-08d50ef2e8e4 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254152)(48565401081)(2017052603199)(201703131423075)(201703031133081)(201702281549075); SRVR:HE1PR08MB2699; X-Microsoft-Exchange-Diagnostics: 1; HE1PR08MB2699; 3:s1L2AKMi/0wo3cZyVkU4ajv70gzXiuMhJqg5Bn6Gaodu0pLYSzLkHUBz9tGXAM2WmdeKb3EWQn3quPHF8OqYzuGHLYwo/8YHsxblLVR5nlSvi1hSs4r9ZgjbCOn5bGg6sX24jcfFNzVIP+g9E7inLUy+KiYYqj6LWnevuSys5iml+hHNhc712NA7TR6Gv7sF5aSxopMboEEw78bD2RDE6yuqjkNjfoA8J71t86HRpMiKc+lukXtVscZq+YqJM+d1; 25:/M1qqB0U61LU8Pf+Y1fvh7CsR/UpLzc7Vo+wazSqidDYwnpPBoHVPICubHNWxOA/QMRGRBGhKisUsUKNDQe7zzNnELqkpDlxnCK2Soi+bI2nwjSRJ+M9NzsQdzQFtfwMZTtxUlpyTXOH6b4tDcBADCjixvVnQIeDHpQUZEXLzJsc23NfOmX9kGdI2SLt60h8T7OLdQQc0tkyqCfbAOzHm/TL3XLRj/ja9VEfMyoBIpHED2m7+9GpCIg7dasYtuqv5OlJu6Xl3W0XZckDt8YmPu+Ocw6Fp4DEHVozCdhoB1bwgsoYljQbF1ZPUUxcXPzqacZZdrtcEIj1gLY8uldPjg==; 31:n3Bp3H0y3s4XxkBZgDk3No+zC+b1nOpHmevnuhLmF27lqNmG57Wzs+womqUXpIsM+nA5qfen9nWsZFgr5JHNcU+dkuRO8hu0BLALonn0baQV8SuHdVT8NvNfdUL8lQ8syG3DAUb7OGBQ+AJ0GwtXmef1jhtYjUzDuIGuwUs9EKDVZbyPKqnIofoNvjpfCNLe+2aj7A7zeCGNBdTfDgTo8E5QPXCvUM1/Hoa266pO8Fg= X-MS-TrafficTypeDiagnostic: HE1PR08MB2699: NoDisclaimer: True X-Microsoft-Exchange-Diagnostics: 1; HE1PR08MB2699; 20:SFYnctaEirQVME5aNgf9xWu+MUN0+lSZoTqlc9UIOLcq2rHxoWwGUjlZXsj5IMxWY1dmB94bAqwjh9Kx9rizWr36IXh6ThdQ4h4vmIYauifZq0haORmIxU9IMCmHraed41q9/xhsdZJn5QNQProdZzlqOaAX09tm0tmxF03P/3I=; 4:v3xQ3dRY3QDSwaNUX8Izg5NLfPS2D5zOrQlz/hfOZoCK5JT2M22+4/nW6k/7vGlVr6lQXWT8WkreUHX/0fvLL90nkud6U5YNUI7Czk7hs9TTDnZWPu/Jk39+0SpF+dQgv0FR1HCRurVzNJVBEQLlr1dnUgL6bWqq30TLeGPBxfSyV6ub41xHOb0gvaIh2viK4GPAyac9CBvRfskfkLw32uvwQnD/w3A0mTTQoNxQX87C1O22slGK+hRy2kdScn7L8x5v0MEWv0JVYTA8s30oY6E77YwljN1ZQ+QVNxtzqKM= X-Exchange-Antispam-Report-Test: UriScan:(180628864354917); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(10201501046)(3002001)(100000703101)(100105400095)(93006095)(93001095)(6055026)(6041248)(20161123555025)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123564025)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:HE1PR08MB2699; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:HE1PR08MB2699; X-Forefront-PRVS: 045584D28C X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(346002)(376002)(189002)(24454002)(199003)(229853002)(53546010)(6666003)(66066001)(966005)(47776003)(101416001)(6636002)(54356999)(50986999)(76176999)(68736007)(33716001)(478600001)(2906002)(33656002)(72206003)(4326008)(97736004)(6496005)(1076002)(6246003)(55016002)(9686003)(25786009)(6306002)(23726003)(189998001)(53936002)(50466002)(106356001)(105586002)(54906003)(81166006)(81156014)(8676002)(58126008)(316002)(5660300001)(2950100002)(305945005)(16586007)(3846002)(6116002)(110136005)(86362001)(8936002)(7736002)(83506001)(16526018)(18370500001)(107986001); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR08MB2699; H:e104320-lin; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; HE1PR08MB2699; 23:LP8VUL40dqrxMDBdLc8agrm+08KooD9WIqln8GS4S?= =?us-ascii?Q?uC4QzMCBjuGDDFZ6hHTKC3Dvqa0Oo6NBYDcwl9WRUflCQER5j7Nj9T/+HyUZ?= =?us-ascii?Q?/v+kQGQfJ8O8uXH9GMnogwJwBX78RdCY9GMMMfX7SuKcN29yMcigLezGybRT?= =?us-ascii?Q?uX++oOnV5+TpEAt0xuR1AgYUc44YM+Z0ncpSLLNP6nIebJrXV2JkIg2HvwwY?= =?us-ascii?Q?c4hhOPpSU1SRe/d+ko+nbpCcXm/iPev3RruAePxmTY0fnygcAKatjQT+P+ye?= =?us-ascii?Q?a3ekP9WIupcIpMAdCf0752DL/ziJfo7TeUXI1ya51sdgmU4HMzB7enFkMtBd?= =?us-ascii?Q?RFVSLdniwevSK3DUVbOWRR7QMD4gd4S6TbjayWm0t049xNSP9ZRICQ3Y0jBY?= =?us-ascii?Q?Hzrjdb9dl4TOwnpObcgLnwzm2nMEg0R4xG4Z5sMjyUy6DdZANM1Q39pGtJUa?= =?us-ascii?Q?tXij0zIXdRygiAlNlqLZe4/TJwbTFUwTgYfx5bdtvj/wAkmkgGyVLeWYXaVj?= =?us-ascii?Q?5boiuEJ/KvQgmQhVVvgNVq8idCE9e/bqHGp3lFySgxMR788BZXWY9a2PiOpV?= =?us-ascii?Q?LJajecho6eeCcXkBO5qgsW0Xg1O8CnKwzS2WevDJn2bDbp5f+QUwaToZqe8F?= =?us-ascii?Q?H5dWs6xwz0MqGkG5UlAmyUFaTDh+7MAGlk6IPvnHuq5XSb5QRMXeZr7B4X6L?= =?us-ascii?Q?wBX82d+TDXKZ6d53NQfUSHvh2QRWoF8RcwAWxjAxIbqjUrtWB5Ce1V9RxJAS?= =?us-ascii?Q?x8i1TXPIb3FcHpKZVS34Ljryj0cMpsRXur/OIQbMXlCVsW43S5HEVxGpv91X?= =?us-ascii?Q?KHMS+rDAPPCjTXEOlw2pa2J1A0PKazWJniDebwU1+uJcfxhEGNrIrb3ND+vz?= =?us-ascii?Q?pas9GRB4HmFaXpmxtxyBnWlvx/TE4gJuSLAXRRh1afFrKWrv5yav1OmwPy53?= =?us-ascii?Q?gko6GwZm88ybTp08R1My6RvhWkdWO5AFcCFQuDTP1NhQJOUwBLP4O45KMFvl?= =?us-ascii?Q?w9x1dk8doLuHBJniW00UTOAaN4QSrCF2t2PMXQLRJVBlCF/5/dMT0PmN1QzT?= =?us-ascii?Q?j3vnkqIJ7mCeyzx8wJwhDf5p9/0XMybhOaOmavaH7902D0pKPDUapz67Z5gQ?= =?us-ascii?Q?Yfn2Lb5ySt9cALpAZ+OJWNd84fn4iILCuJjr61gV3IAlceIXPSHgCrfZJkK5?= =?us-ascii?Q?twH3labISwODA4HftP37fVXGWeNN7b6ohFpnsZT9Kvy3mAW/j48Ej+MBpbND?= =?us-ascii?Q?iW3kTE9+Hnd+qLd4xBZz7TgYfgkvO6qB7SunlmDW9l9rEFmYxtLPvR25GOaw?= =?us-ascii?Q?761ikn3GDfB9HOJLWpN1mWL43oT0e2/pJffUK07f4uA?= X-Microsoft-Exchange-Diagnostics: 1; HE1PR08MB2699; 6:vggn/mLg/oSllPHafDW1b9D80iZPTl+A01R4pCS/rYP3KkP5iTewqdYFR9+xZcorFfb4YPcd2xnDhjr1KTFjDo+Gnx+90uOSegzg7gRxaP0ixnP7oTyIRflERI8oadULOQd3scCOmenXVPYuktArGBnzJDM1mycO1HVRNdSouW3lc/afERzl/CWe9fNTPxYrqL6RyNI9M/ne6Zg9Gui/engRJ94WcdC+zDK4isQf/0TV0nfPBmjHTQ26j3qkQiNRJ8H4E3wSF4c+JRkaAfz0C/qmpn77ouaocT4v2YjucZS2OMiLuqBsPRtq+QdwHSOQN5G2u0z3SNa8lHRmhLptOQ==; 5:5inb2yVY7f9nm0scIeuYAlPRH96goLrvvp8Q+rJLs6HKua1z+jj854Z/E6xtN7RKSKUo3ZNFnovy2LmcfnSOlDX2h5Flw5hKSNAgpQWLnrg8Z9ZcD6r0yg1RjP07H3Sz2xu0rvdrV1RB8HgXUW+hG5Hc1DAq6Ndwqg48j6XcIr8=; 24:8PcemHNaOIOkBN6n80lL9VDHc3+fMMG1wtWUVJM2IXyXZicSxKAlLHRC882toTw35idaeLCHeMI5PL0RbZzT90nld28wSvBrmKiyUvaFFwk=; 7:b67VFx3oiltd178IAjhiO6sUTL8SofZGJTmZ84OAMWjWHeFQMi/HR1hfoFxY+wj7QtqKsMHm9eqcjlqkqa0pLLB+QH4A1YgJSRIkLQmSqHtJ6QapBOkHYFRFlSO0SpFubKnMU+okQnSQafvuj2qzpzTsYDUM8llShYeAIKuWImZ/bjX0Hxg+CHwLwlCMshYn0HPM0IdaGF1F09nF4P/kAaIXJXQItnGzdC2vT/CkvjQ= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Oct 2017 08:51:14.1046 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR08MB2699 Subject: Re: [PATCH v2 1/2] ArmPkg/Include: Add standard SMC function IDs for MM interface. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Oct 2017 08:47:56 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Ard/Supreeth, On Fri, Oct 06, 2017 at 10:05:46PM +0100, Ard Biesheuvel wrote: > On 27 September 2017 at 19:58, Supreeth Venkatesh > wrote: > > This patch adds a list of function IDs that fall under the standard > > SMC range as defined in > > http://infocenter.arm.com/help/topic/com.arm.doc.den0060a/DEN0060A_ARM_MM_Interface_Specification.pdf. > > > > SMCs associated with Management Mode are in the range 0xC4000040 - > > 0xC400005f (64 bit) and 0x84000040 - 0x8400005f (32 bit). > > > > The function(s) available to the normal world: > > 1. Request services from the secure MM environment using MM_COMMUNICATE. > > > > It also defines MM return codes. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Achin Gupta > > Signed-off-by: Supreeth Venkatesh > > Both patches applied. Thanks. I should have spotted this earlier but the following define is not spec. compliant. It says: > +#define ARM_SMC_MM_RET_NO_MEMORY -4 but should be > +#define ARM_SMC_MM_RET_NO_MEMORY -5 Supreeth. Could you please submit a patch to rectify this? cheers, Achin > > > --- > > ArmPkg/Include/IndustryStandard/ArmStdSmc.h | 20 +++++++++++++++++++- > > 1 file changed, 19 insertions(+), 1 deletion(-) > > > > diff --git a/ArmPkg/Include/IndustryStandard/ArmStdSmc.h b/ArmPkg/Include/IndustryStandard/ArmStdSmc.h > > index 593a3ce729..37d0796649 100644 > > --- a/ArmPkg/Include/IndustryStandard/ArmStdSmc.h > > +++ b/ArmPkg/Include/IndustryStandard/ArmStdSmc.h > > @@ -1,6 +1,6 @@ > > /** @file > > * > > -* Copyright (c) 2012-2014, ARM Limited. All rights reserved. > > +* Copyright (c) 2012-2017, ARM Limited. All rights reserved. > > * > > * This program and the accompanying materials > > * are licensed and made available under the terms and conditions of the BSD License > > @@ -40,6 +40,24 @@ > > #define ARM_SMC_STD_REVISION_MAJOR 0x0 > > #define ARM_SMC_STD_REVISION_MINOR 0x1 > > > > +/* > > + * Management Mode (MM) calls cover a subset of the Standard Service Call range. > > + * The list below is not exhaustive. > > + */ > > +#define ARM_SMC_ID_MM_VERSION_AARCH32 0x84000040 > > +#define ARM_SMC_ID_MM_VERSION_AARCH64 0xC4000040 > > + > > +// Request service from secure standalone MM environment > > +#define ARM_SMC_ID_MM_COMMUNICATE_AARCH32 0x84000041 > > +#define ARM_SMC_ID_MM_COMMUNICATE_AARCH64 0xC4000041 > > + > > +/* MM return error codes */ > > +#define ARM_SMC_MM_RET_SUCCESS 0 > > +#define ARM_SMC_MM_RET_NOT_SUPPORTED -1 > > +#define ARM_SMC_MM_RET_INVALID_PARAMS -2 > > +#define ARM_SMC_MM_RET_DENIED -3 > > +#define ARM_SMC_MM_RET_NO_MEMORY -4 > > + > > /* > > * Power State Coordination Interface (PSCI) calls cover a subset of the > > * Standard Service Call range. > > -- > > 2.14.1 > >