From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::229; helo=mail-wm0-x229.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x229.google.com (mail-wm0-x229.google.com [IPv6:2a00:1450:400c:c09::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0DEFA21CF58DD for ; Mon, 9 Oct 2017 09:20:35 -0700 (PDT) Received: by mail-wm0-x229.google.com with SMTP id u138so24022017wmu.5 for ; Mon, 09 Oct 2017 09:24:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=UBjmq6tXtqEeLNYUFmf1mP+plzZv4YcKpduG5USgne8=; b=fFXfXxXG4tzSHb6j5mtY8CuMV4xS2uTcbvTxIKWn/+K7BuuP+hiU5sfcOWNWMPg2P4 /Ip6l4sbnDuUWC5TUddAxlEJxm5pK6E7RFQ9JGfni3vNGGzrJVJZ/vCNflPpxy7PIHrP cdMIXuh6jEfyD29mjGC4HWxpg4eduEogUKaDA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=UBjmq6tXtqEeLNYUFmf1mP+plzZv4YcKpduG5USgne8=; b=GjOwECSOeFKcORIsnJIpq/50mi96IevLNT34vcnTE5e893EzjseRiN3cpDv/408Y1R OYeGMz38OGKMKJnQV23uNqyFiOqYnGesiHIp8rMWH4/kGEmgYgNI90a0rKI+Pcy4X2r4 VFZxvk8uiH9K0zyvmLDNwnwGz/pf/xdOeaMNH8kXGmReLQAGTzpDK5TSChdvdOlMMUS8 c6bfsGCf0pmacFqW3hMp010JEbkurXkXZctnLVmExRFFS/3bTIzTQPJp1RA3yrjX3VTX aiM51fXm8MGPWkzDe5s1cwbrP+o8y0kPIWU/F0IZi6krwEAomdA0tZNOJsSqY0M29WYS Extg== X-Gm-Message-State: AMCzsaWmmXmzER5GVUoaXPYLLVAYWGMT2ynINPNLINAJN0C/BILsqNUt zhJrQNfTzqUfX1O+hJFNbeDs2g== X-Google-Smtp-Source: AOwi7QDfYd/DvCdiXhKZT7vD10NHddBSsfUIkU2ybwakXeVSAt5oXmQkgj+dExy6XGqIFzRjXqz/yg== X-Received: by 10.28.234.140 with SMTP id g12mr8302236wmi.73.1507566241759; Mon, 09 Oct 2017 09:24:01 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id o11sm6182987wrg.5.2017.10.09.09.24.00 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 09 Oct 2017 09:24:00 -0700 (PDT) Date: Mon, 9 Oct 2017 17:23:59 +0100 From: Leif Lindholm To: Marcin Wojtas Cc: edk2-devel-01 , Ard Biesheuvel , nadavh@marvell.com, Neta Zur Hershkovits , Kostya Porotchkin , Hua Jing , semihalf-dabros-jan Message-ID: <20171009162359.cqwmxb45mnvwg33r@bivouac.eciton.net> References: <1507460212-10323-1-git-send-email-mw@semihalf.com> <1507460212-10323-4-git-send-email-mw@semihalf.com> <20171009160002.lwqxkoytc4pvy75y@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [platforms: PATCH v2 3/5] Marvell/Library: UtmiLib: Move devices description to MvHwDescLib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Oct 2017 16:20:36 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Oct 09, 2017 at 06:06:53PM +0200, Marcin Wojtas wrote: > 2017-10-09 18:00 GMT+02:00 Leif Lindholm : > > On Sun, Oct 08, 2017 at 12:56:50PM +0200, Marcin Wojtas wrote: > >> This patch introduces UTMI description, using the new structures > >> and template in MvHwDescLib. This change enables more flexible > >> addition of multiple CP with UTMI PHY's and also significantly > >> reduces amount of used PCD's for that purpose. Update PortingGuide > >> documentation accordingly. > >> > >> This patch replaces string-based description of Utmi on > >> Armada 70x0 DB with new, reduced format, which uses macros > >> in Armada.dsc.inc file for better readability. > >> > >> Contributed-under: TianoCore Contribution Agreement 1.1 > >> Signed-off-by: Marcin Wojtas > >> --- > >> Platform/Marvell/Armada/Armada.dsc.inc | 5 + > >> Platform/Marvell/Armada/Armada70x0.dsc | 7 +- > >> Platform/Marvell/Include/Library/MvHwDescLib.h | 47 ++++++ > >> Platform/Marvell/Library/UtmiPhyLib/UtmiPhyLib.c | 150 ++++++++++---------- > >> Platform/Marvell/Library/UtmiPhyLib/UtmiPhyLib.h | 1 - > >> Platform/Marvell/Library/UtmiPhyLib/UtmiPhyLib.inf | 11 +- > >> Platform/Marvell/Marvell.dec | 7 +- > >> Silicon/Marvell/Documentation/PortingGuide.txt | 30 ++-- > >> 8 files changed, 148 insertions(+), 110 deletions(-) > >> > > This indentation does not appear to follow any of the patterns > > permitted by the coding style. Please address here and in the two > > instances below (calls to UtmiPhyConfig and UtmiPhyPowerUp). > > > > No need to resubmit the whole series - just the single patch. > > Sure, will send right away. Thx. > >> Example > >> ------- > >> > >> # UtmiPhy > >> - gMarvellTokenSpaceGuid.PcdUtmiPhyCount|2 > >> - gMarvellTokenSpaceGuid.PcdUtmiPhyRegUtmiUnit|L"0xF2580000;0xF2581000" > >> - gMarvellTokenSpaceGuid.PcdUtmiPhyRegUsbCfg|L"0xF2440420;0xF2440420" > >> - gMarvellTokenSpaceGuid.PcdUtmiPhyRegUtmiCfg|L"0xF2440440;0xF2440444" > >> - gMarvellTokenSpaceGuid.PcdUtmiPhyUtmiPort|L"0x0;0x1" > >> + gMarvellTokenSpaceGuid.PcdUtmiControllersEnabled|{ 0x1, 0x1 } > >> + gMarvellTokenSpaceGuid.PcdUtmiPortType|{ $(UTMI_USB_HOST0), $(UTMI_USB_HOST1) } > > > > Actually, looking at this bit made me realise the PortingGuide.txt > > uses tab characters and uses \n line endings. > > > > This is not caused by this set, so does not need to be addressed as > > part of this series, but if you could follow up with a patch adjusting > > the formating of documentation, I would be grateful. > > > > This is also made painfully clear when running CheckPatch.py. > > > > Well, yes. It's in Sphinx acceptable format Apart from a massive structure in Egypt, what is a Sphinx? > and it is generated into > Marvell documentation along with all other projects. If I align it to > edk2 coding style, I'd have to maintain 2 copies of this file... If > you insist, I'll change it, but I would be very grateful for accepting > this one exception, if possible:) Please let know your decision > (looking at my branch, there won't be much updates of this file). Well, I don't see how we can keep a file that makes PatchCheck.py barf whenever we touch it. If you want to keep this format, please send a proposal to exclude files of this type from said checks by PatchCheck.py to edk2-devel. Is there a default "Sphinx source" file extension that can be used to describe this format, rather than changing the rule for anything called ".txt"? (If not, should we make one?) / Leif