From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::22f; helo=mail-wm0-x22f.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x22f.google.com (mail-wm0-x22f.google.com [IPv6:2a00:1450:400c:c09::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 6CCF92095B071 for ; Mon, 9 Oct 2017 09:40:35 -0700 (PDT) Received: by mail-wm0-x22f.google.com with SMTP id 196so12325677wma.1 for ; Mon, 09 Oct 2017 09:44:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=H8Cdk5qY2LQfmWpWgcLtRQX+IulrjEcOMei88nT61C8=; b=P6hwBnXYvIYA1ml8tH5zV7yxVYAiP5Pw9ea0zQhhCnZUs+j064Vu8cLGma9qADkeCQ EHZ+LFMH/HvU2UkFcUBnSfuV0pR/MNAp+sB6VKrn3VSUw9kcW9m9Iiot6ZJdwWxMExbG SW1WGA3/45bah56fJbvEsyQWhs/io9qeXGwNk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=H8Cdk5qY2LQfmWpWgcLtRQX+IulrjEcOMei88nT61C8=; b=KROv772M5TgzESrsFSr3gNVOxbOsbNz42QxyiN/D+/qV5z3nkFgWFk7oIp4icN/LTt 6ZpCY2KsEZVNp1NNAQf8JU8jw99s+BYmjU3HVFbMWa1omkIoBbRmLGl5+thxTAoKNMrC FjWU/3RbOKSwzF6irGlbBRN+zLP7eiXDPLhT65kCxszjD5i0+xddHOlMJowRVj4ABY+d sO/KzcCqZwjPHUrkiOzxdtR70iVWRP+wLCBG4P9NBCTAOoTt12+xfgXcGw/+tuU7yXrm rZjU2KiBZ/stBA+sghWZIzhWL80HJ/3WZsGGE89udQlZLohLNHg7pN4SKsZuOqDnTMT0 nOyA== X-Gm-Message-State: AMCzsaV1uffsO1vpK5VxlfVrkU8FTpVfaCdq6aNnu6hqVXjVN0AqZrZg 1eTdrf5qHQKrgMqLaD/8m2HdZQ== X-Google-Smtp-Source: AOwi7QAP6oh+WDDIFTTQDWlp9pfZh9fq5KIohYnnFsoH40ee5XnP7mjSSQ/PpIAwHU+T6eh29V1EPg== X-Received: by 10.223.173.100 with SMTP id p91mr6613330wrc.53.1507567441148; Mon, 09 Oct 2017 09:44:01 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id b11sm20134075wrd.91.2017.10.09.09.43.59 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 09 Oct 2017 09:44:00 -0700 (PDT) Date: Mon, 9 Oct 2017 17:43:58 +0100 From: Leif Lindholm To: Marcin Wojtas Cc: edk2-devel-01 , Ard Biesheuvel , nadavh@marvell.com, Neta Zur Hershkovits , Kostya Porotchkin , Hua Jing , semihalf-dabros-jan Message-ID: <20171009164358.lxxwt7satnari4r4@bivouac.eciton.net> References: <1507460212-10323-1-git-send-email-mw@semihalf.com> <1507460212-10323-4-git-send-email-mw@semihalf.com> <20171009160002.lwqxkoytc4pvy75y@bivouac.eciton.net> <20171009162359.cqwmxb45mnvwg33r@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [platforms: PATCH v2 3/5] Marvell/Library: UtmiLib: Move devices description to MvHwDescLib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Oct 2017 16:40:35 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Oct 09, 2017 at 06:25:18PM +0200, Marcin Wojtas wrote: > 2017-10-09 18:23 GMT+02:00 Leif Lindholm : > > On Mon, Oct 09, 2017 at 06:06:53PM +0200, Marcin Wojtas wrote: > >> 2017-10-09 18:00 GMT+02:00 Leif Lindholm : > >> > On Sun, Oct 08, 2017 at 12:56:50PM +0200, Marcin Wojtas wrote: > >> >> This patch introduces UTMI description, using the new structures > >> >> and template in MvHwDescLib. This change enables more flexible > >> >> addition of multiple CP with UTMI PHY's and also significantly > >> >> reduces amount of used PCD's for that purpose. Update PortingGuide > >> >> documentation accordingly. > >> >> > >> >> This patch replaces string-based description of Utmi on > >> >> Armada 70x0 DB with new, reduced format, which uses macros > >> >> in Armada.dsc.inc file for better readability. > >> >> > >> >> Contributed-under: TianoCore Contribution Agreement 1.1 > >> >> Signed-off-by: Marcin Wojtas > >> >> --- > >> >> Platform/Marvell/Armada/Armada.dsc.inc | 5 + > >> >> Platform/Marvell/Armada/Armada70x0.dsc | 7 +- > >> >> Platform/Marvell/Include/Library/MvHwDescLib.h | 47 ++++++ > >> >> Platform/Marvell/Library/UtmiPhyLib/UtmiPhyLib.c | 150 ++++++++++---------- > >> >> Platform/Marvell/Library/UtmiPhyLib/UtmiPhyLib.h | 1 - > >> >> Platform/Marvell/Library/UtmiPhyLib/UtmiPhyLib.inf | 11 +- > >> >> Platform/Marvell/Marvell.dec | 7 +- > >> >> Silicon/Marvell/Documentation/PortingGuide.txt | 30 ++-- > >> >> 8 files changed, 148 insertions(+), 110 deletions(-) > >> >> > > > >> > This indentation does not appear to follow any of the patterns > >> > permitted by the coding style. Please address here and in the two > >> > instances below (calls to UtmiPhyConfig and UtmiPhyPowerUp). > >> > > >> > No need to resubmit the whole series - just the single patch. > >> > >> Sure, will send right away. > > > > Thx. > > Rebased patches are available here: > https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/parsepcd-upstream-r20171009 Thanks - for the series: Reviewed-by: Leif Lindholm Pushed as 7f0f07968b..a1b8b22b97 / Leif