public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH v2 1/2] ArmPkg/Include: Add standard SMC function IDs for MM interface.
@ 2017-09-27 18:58 Supreeth Venkatesh
  2017-09-27 18:58 ` [PATCH v2 2/2] ArmPkg/Include: Add SVC function IDs for Management Mode Supreeth Venkatesh
  2017-10-06 21:05 ` [PATCH v2 1/2] ArmPkg/Include: Add standard SMC function IDs for MM interface Ard Biesheuvel
  0 siblings, 2 replies; 6+ messages in thread
From: Supreeth Venkatesh @ 2017-09-27 18:58 UTC (permalink / raw)
  To: edk2-devel; +Cc: leif.lindholm, ard.biesheuvel, Supreeth Venkatesh, Achin Gupta

This patch adds a list of function IDs that fall under the standard
SMC range as defined in
http://infocenter.arm.com/help/topic/com.arm.doc.den0060a/DEN0060A_ARM_MM_Interface_Specification.pdf.

SMCs associated with Management Mode are in the range 0xC4000040 -
0xC400005f (64 bit) and 0x84000040 - 0x8400005f (32 bit).

The function(s) available to the normal world:
1. Request services from the secure MM environment using MM_COMMUNICATE.

It also defines MM return codes.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Achin Gupta <achin.gupta@arm.com>
Signed-off-by: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
---
 ArmPkg/Include/IndustryStandard/ArmStdSmc.h | 20 +++++++++++++++++++-
 1 file changed, 19 insertions(+), 1 deletion(-)

diff --git a/ArmPkg/Include/IndustryStandard/ArmStdSmc.h b/ArmPkg/Include/IndustryStandard/ArmStdSmc.h
index 593a3ce729..37d0796649 100644
--- a/ArmPkg/Include/IndustryStandard/ArmStdSmc.h
+++ b/ArmPkg/Include/IndustryStandard/ArmStdSmc.h
@@ -1,6 +1,6 @@
 /** @file
 *
-*  Copyright (c) 2012-2014, ARM Limited. All rights reserved.
+*  Copyright (c) 2012-2017, ARM Limited. All rights reserved.
 *
 *  This program and the accompanying materials
 *  are licensed and made available under the terms and conditions of the BSD License
@@ -40,6 +40,24 @@
 #define ARM_SMC_STD_REVISION_MAJOR    0x0
 #define ARM_SMC_STD_REVISION_MINOR    0x1
 
+/*
+ * Management Mode (MM) calls cover a subset of the Standard Service Call range.
+ * The list below is not exhaustive.
+ */
+#define ARM_SMC_ID_MM_VERSION_AARCH32              0x84000040
+#define ARM_SMC_ID_MM_VERSION_AARCH64              0xC4000040
+
+// Request service from secure standalone MM environment
+#define ARM_SMC_ID_MM_COMMUNICATE_AARCH32          0x84000041
+#define ARM_SMC_ID_MM_COMMUNICATE_AARCH64          0xC4000041
+
+/* MM return error codes */
+#define ARM_SMC_MM_RET_SUCCESS              0
+#define ARM_SMC_MM_RET_NOT_SUPPORTED       -1
+#define ARM_SMC_MM_RET_INVALID_PARAMS      -2
+#define ARM_SMC_MM_RET_DENIED              -3
+#define ARM_SMC_MM_RET_NO_MEMORY           -4
+
 /*
  * Power State Coordination Interface (PSCI) calls cover a subset of the
  * Standard Service Call range.
-- 
2.14.1



^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH v2 2/2] ArmPkg/Include: Add SVC function IDs for Management Mode.
  2017-09-27 18:58 [PATCH v2 1/2] ArmPkg/Include: Add standard SMC function IDs for MM interface Supreeth Venkatesh
@ 2017-09-27 18:58 ` Supreeth Venkatesh
  2017-10-06 21:05 ` [PATCH v2 1/2] ArmPkg/Include: Add standard SMC function IDs for MM interface Ard Biesheuvel
  1 sibling, 0 replies; 6+ messages in thread
From: Supreeth Venkatesh @ 2017-09-27 18:58 UTC (permalink / raw)
  To: edk2-devel; +Cc: leif.lindholm, ard.biesheuvel, Supreeth Venkatesh

SVCs are in the range 0xC4000060 - 0xC400007f.
The functions available to the secure MM partition:
1. Signal completion of MM event handling.
2. Set/Get memory attributes for a memory region at runtime.
3. Get version number of secure partition manager.

Also, it defines memory attributes required for set/get operations.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
---
 ArmPkg/Include/IndustryStandard/ArmMmSvc.h | 43 ++++++++++++++++++++++++++++++
 1 file changed, 43 insertions(+)
 create mode 100644 ArmPkg/Include/IndustryStandard/ArmMmSvc.h

diff --git a/ArmPkg/Include/IndustryStandard/ArmMmSvc.h b/ArmPkg/Include/IndustryStandard/ArmMmSvc.h
new file mode 100644
index 0000000000..4c7b6c3386
--- /dev/null
+++ b/ArmPkg/Include/IndustryStandard/ArmMmSvc.h
@@ -0,0 +1,43 @@
+/** @file
+*
+*  Copyright (c) 2012-2017, ARM Limited. All rights reserved.
+*
+*  This program and the accompanying materials
+*  are licensed and made available under the terms and conditions of the BSD License
+*  which accompanies this distribution.  The full text of the license may be found at
+*  http://opensource.org/licenses/bsd-license.php
+*
+*  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
+*  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
+*
+**/
+
+#ifndef __ARM_MM_SVC_H__
+#define __ARM_MM_SVC_H__
+
+/*
+ * SVC IDs to allow the MM secure partition to initialise itself, handle
+ * delegated events and request the Secure partition manager to perform
+ * privileged operations on its behalf.
+ */
+#define ARM_SVC_ID_SPM_VERSION_AARCH64             0xC4000060
+#define ARM_SVC_ID_SP_EVENT_COMPLETE_AARCH64       0xC4000061
+#define ARM_SVC_ID_SP_GET_MEM_ATTRIBUTES_AARCH64   0xC4000064
+#define ARM_SVC_ID_SP_SET_MEM_ATTRIBUTES_AARCH64   0xC4000065
+
+#define SET_MEM_ATTR_DATA_PERM_MASK       0x3
+#define SET_MEM_ATTR_DATA_PERM_SHIFT        0
+#define SET_MEM_ATTR_DATA_PERM_NO_ACCESS    0
+#define SET_MEM_ATTR_DATA_PERM_RW           1
+#define SET_MEM_ATTR_DATA_PERM_RO           3
+
+#define SET_MEM_ATTR_CODE_PERM_MASK   0x1
+#define SET_MEM_ATTR_CODE_PERM_SHIFT    2
+#define SET_MEM_ATTR_CODE_PERM_X        0
+#define SET_MEM_ATTR_CODE_PERM_XN       1
+
+#define SET_MEM_ATTR_MAKE_PERM_REQUEST(d_perm, c_perm)                            \
+    ((((c_perm) & SET_MEM_ATTR_CODE_PERM_MASK) << SET_MEM_ATTR_CODE_PERM_SHIFT) | \
+    (( (d_perm) & SET_MEM_ATTR_DATA_PERM_MASK) << SET_MEM_ATTR_DATA_PERM_SHIFT))
+
+#endif
-- 
2.14.1



^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH v2 1/2] ArmPkg/Include: Add standard SMC function IDs for MM interface.
  2017-09-27 18:58 [PATCH v2 1/2] ArmPkg/Include: Add standard SMC function IDs for MM interface Supreeth Venkatesh
  2017-09-27 18:58 ` [PATCH v2 2/2] ArmPkg/Include: Add SVC function IDs for Management Mode Supreeth Venkatesh
@ 2017-10-06 21:05 ` Ard Biesheuvel
  2017-10-09  8:52   ` Achin Gupta
  1 sibling, 1 reply; 6+ messages in thread
From: Ard Biesheuvel @ 2017-10-06 21:05 UTC (permalink / raw)
  To: Supreeth Venkatesh; +Cc: edk2-devel@lists.01.org, Leif Lindholm, Achin Gupta

On 27 September 2017 at 19:58, Supreeth Venkatesh
<supreeth.venkatesh@arm.com> wrote:
> This patch adds a list of function IDs that fall under the standard
> SMC range as defined in
> http://infocenter.arm.com/help/topic/com.arm.doc.den0060a/DEN0060A_ARM_MM_Interface_Specification.pdf.
>
> SMCs associated with Management Mode are in the range 0xC4000040 -
> 0xC400005f (64 bit) and 0x84000040 - 0x8400005f (32 bit).
>
> The function(s) available to the normal world:
> 1. Request services from the secure MM environment using MM_COMMUNICATE.
>
> It also defines MM return codes.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Achin Gupta <achin.gupta@arm.com>
> Signed-off-by: Supreeth Venkatesh <supreeth.venkatesh@arm.com>

Both patches applied. Thanks.

> ---
>  ArmPkg/Include/IndustryStandard/ArmStdSmc.h | 20 +++++++++++++++++++-
>  1 file changed, 19 insertions(+), 1 deletion(-)
>
> diff --git a/ArmPkg/Include/IndustryStandard/ArmStdSmc.h b/ArmPkg/Include/IndustryStandard/ArmStdSmc.h
> index 593a3ce729..37d0796649 100644
> --- a/ArmPkg/Include/IndustryStandard/ArmStdSmc.h
> +++ b/ArmPkg/Include/IndustryStandard/ArmStdSmc.h
> @@ -1,6 +1,6 @@
>  /** @file
>  *
> -*  Copyright (c) 2012-2014, ARM Limited. All rights reserved.
> +*  Copyright (c) 2012-2017, ARM Limited. All rights reserved.
>  *
>  *  This program and the accompanying materials
>  *  are licensed and made available under the terms and conditions of the BSD License
> @@ -40,6 +40,24 @@
>  #define ARM_SMC_STD_REVISION_MAJOR    0x0
>  #define ARM_SMC_STD_REVISION_MINOR    0x1
>
> +/*
> + * Management Mode (MM) calls cover a subset of the Standard Service Call range.
> + * The list below is not exhaustive.
> + */
> +#define ARM_SMC_ID_MM_VERSION_AARCH32              0x84000040
> +#define ARM_SMC_ID_MM_VERSION_AARCH64              0xC4000040
> +
> +// Request service from secure standalone MM environment
> +#define ARM_SMC_ID_MM_COMMUNICATE_AARCH32          0x84000041
> +#define ARM_SMC_ID_MM_COMMUNICATE_AARCH64          0xC4000041
> +
> +/* MM return error codes */
> +#define ARM_SMC_MM_RET_SUCCESS              0
> +#define ARM_SMC_MM_RET_NOT_SUPPORTED       -1
> +#define ARM_SMC_MM_RET_INVALID_PARAMS      -2
> +#define ARM_SMC_MM_RET_DENIED              -3
> +#define ARM_SMC_MM_RET_NO_MEMORY           -4
> +
>  /*
>   * Power State Coordination Interface (PSCI) calls cover a subset of the
>   * Standard Service Call range.
> --
> 2.14.1
>


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v2 1/2] ArmPkg/Include: Add standard SMC function IDs for MM interface.
  2017-10-06 21:05 ` [PATCH v2 1/2] ArmPkg/Include: Add standard SMC function IDs for MM interface Ard Biesheuvel
@ 2017-10-09  8:52   ` Achin Gupta
  2017-10-09 15:15     ` Supreeth Venkatesh
  0 siblings, 1 reply; 6+ messages in thread
From: Achin Gupta @ 2017-10-09  8:52 UTC (permalink / raw)
  To: Ard Biesheuvel, Supreeth Venkatesh
  Cc: Supreeth Venkatesh, edk2-devel@lists.01.org, Leif Lindholm, nd

Hi Ard/Supreeth,

On Fri, Oct 06, 2017 at 10:05:46PM +0100, Ard Biesheuvel wrote:
> On 27 September 2017 at 19:58, Supreeth Venkatesh
> <supreeth.venkatesh@arm.com> wrote:
> > This patch adds a list of function IDs that fall under the standard
> > SMC range as defined in
> > http://infocenter.arm.com/help/topic/com.arm.doc.den0060a/DEN0060A_ARM_MM_Interface_Specification.pdf.
> >
> > SMCs associated with Management Mode are in the range 0xC4000040 -
> > 0xC400005f (64 bit) and 0x84000040 - 0x8400005f (32 bit).
> >
> > The function(s) available to the normal world:
> > 1. Request services from the secure MM environment using MM_COMMUNICATE.
> >
> > It also defines MM return codes.
> >
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Achin Gupta <achin.gupta@arm.com>
> > Signed-off-by: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
>
> Both patches applied. Thanks.

I should have spotted this earlier but the following define is not
spec. compliant. It says:

> +#define ARM_SMC_MM_RET_NO_MEMORY           -4

but should be

> +#define ARM_SMC_MM_RET_NO_MEMORY           -5

Supreeth. Could you please submit a patch to rectify this?

cheers,
Achin

>
> > ---
> >  ArmPkg/Include/IndustryStandard/ArmStdSmc.h | 20 +++++++++++++++++++-
> >  1 file changed, 19 insertions(+), 1 deletion(-)
> >
> > diff --git a/ArmPkg/Include/IndustryStandard/ArmStdSmc.h b/ArmPkg/Include/IndustryStandard/ArmStdSmc.h
> > index 593a3ce729..37d0796649 100644
> > --- a/ArmPkg/Include/IndustryStandard/ArmStdSmc.h
> > +++ b/ArmPkg/Include/IndustryStandard/ArmStdSmc.h
> > @@ -1,6 +1,6 @@
> >  /** @file
> >  *
> > -*  Copyright (c) 2012-2014, ARM Limited. All rights reserved.
> > +*  Copyright (c) 2012-2017, ARM Limited. All rights reserved.
> >  *
> >  *  This program and the accompanying materials
> >  *  are licensed and made available under the terms and conditions of the BSD License
> > @@ -40,6 +40,24 @@
> >  #define ARM_SMC_STD_REVISION_MAJOR    0x0
> >  #define ARM_SMC_STD_REVISION_MINOR    0x1
> >
> > +/*
> > + * Management Mode (MM) calls cover a subset of the Standard Service Call range.
> > + * The list below is not exhaustive.
> > + */
> > +#define ARM_SMC_ID_MM_VERSION_AARCH32              0x84000040
> > +#define ARM_SMC_ID_MM_VERSION_AARCH64              0xC4000040
> > +
> > +// Request service from secure standalone MM environment
> > +#define ARM_SMC_ID_MM_COMMUNICATE_AARCH32          0x84000041
> > +#define ARM_SMC_ID_MM_COMMUNICATE_AARCH64          0xC4000041
> > +
> > +/* MM return error codes */
> > +#define ARM_SMC_MM_RET_SUCCESS              0
> > +#define ARM_SMC_MM_RET_NOT_SUPPORTED       -1
> > +#define ARM_SMC_MM_RET_INVALID_PARAMS      -2
> > +#define ARM_SMC_MM_RET_DENIED              -3
> > +#define ARM_SMC_MM_RET_NO_MEMORY           -4
> > +
> >  /*
> >   * Power State Coordination Interface (PSCI) calls cover a subset of the
> >   * Standard Service Call range.
> > --
> > 2.14.1
> >


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v2 1/2] ArmPkg/Include: Add standard SMC function IDs for MM interface.
  2017-10-09  8:52   ` Achin Gupta
@ 2017-10-09 15:15     ` Supreeth Venkatesh
  2017-10-09 22:19       ` Achin Gupta
  0 siblings, 1 reply; 6+ messages in thread
From: Supreeth Venkatesh @ 2017-10-09 15:15 UTC (permalink / raw)
  To: Achin Gupta, Ard Biesheuvel; +Cc: edk2-devel@lists.01.org, Leif Lindholm, nd

I can do that.
However, "-4" is missing in the specification. Is there a chance to rectify specification to add "-4", so that I can do both the defines.

Thanks,
Supreeth
-----Original Message-----
From: Achin Gupta
Sent: Monday, October 9, 2017 3:52 AM
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>; Supreeth Venkatesh <Supreeth.Venkatesh@arm.com>
Cc: Supreeth Venkatesh <Supreeth.Venkatesh@arm.com>; edk2-devel@lists.01.org; Leif Lindholm <leif.lindholm@linaro.org>; nd <nd@arm.com>
Subject: Re: [PATCH v2 1/2] ArmPkg/Include: Add standard SMC function IDs for MM interface.

Hi Ard/Supreeth,

On Fri, Oct 06, 2017 at 10:05:46PM +0100, Ard Biesheuvel wrote:
> On 27 September 2017 at 19:58, Supreeth Venkatesh
> <supreeth.venkatesh@arm.com> wrote:
> > This patch adds a list of function IDs that fall under the standard
> > SMC range as defined in
> > http://infocenter.arm.com/help/topic/com.arm.doc.den0060a/DEN0060A_ARM_MM_Interface_Specification.pdf.
> >
> > SMCs associated with Management Mode are in the range 0xC4000040 -
> > 0xC400005f (64 bit) and 0x84000040 - 0x8400005f (32 bit).
> >
> > The function(s) available to the normal world:
> > 1. Request services from the secure MM environment using MM_COMMUNICATE.
> >
> > It also defines MM return codes.
> >
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Achin Gupta <achin.gupta@arm.com>
> > Signed-off-by: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
>
> Both patches applied. Thanks.

I should have spotted this earlier but the following define is not spec. compliant. It says:

> +#define ARM_SMC_MM_RET_NO_MEMORY           -4

but should be

> +#define ARM_SMC_MM_RET_NO_MEMORY           -5

Supreeth. Could you please submit a patch to rectify this?

cheers,
Achin

>
> > ---
> >  ArmPkg/Include/IndustryStandard/ArmStdSmc.h | 20
> > +++++++++++++++++++-
> >  1 file changed, 19 insertions(+), 1 deletion(-)
> >
> > diff --git a/ArmPkg/Include/IndustryStandard/ArmStdSmc.h
> > b/ArmPkg/Include/IndustryStandard/ArmStdSmc.h
> > index 593a3ce729..37d0796649 100644
> > --- a/ArmPkg/Include/IndustryStandard/ArmStdSmc.h
> > +++ b/ArmPkg/Include/IndustryStandard/ArmStdSmc.h
> > @@ -1,6 +1,6 @@
> >  /** @file
> >  *
> > -*  Copyright (c) 2012-2014, ARM Limited. All rights reserved.
> > +*  Copyright (c) 2012-2017, ARM Limited. All rights reserved.
> >  *
> >  *  This program and the accompanying materials
> >  *  are licensed and made available under the terms and conditions
> > of the BSD License @@ -40,6 +40,24 @@
> >  #define ARM_SMC_STD_REVISION_MAJOR    0x0
> >  #define ARM_SMC_STD_REVISION_MINOR    0x1
> >
> > +/*
> > + * Management Mode (MM) calls cover a subset of the Standard Service Call range.
> > + * The list below is not exhaustive.
> > + */
> > +#define ARM_SMC_ID_MM_VERSION_AARCH32              0x84000040
> > +#define ARM_SMC_ID_MM_VERSION_AARCH64              0xC4000040
> > +
> > +// Request service from secure standalone MM environment
> > +#define ARM_SMC_ID_MM_COMMUNICATE_AARCH32          0x84000041
> > +#define ARM_SMC_ID_MM_COMMUNICATE_AARCH64          0xC4000041
> > +
> > +/* MM return error codes */
> > +#define ARM_SMC_MM_RET_SUCCESS              0
> > +#define ARM_SMC_MM_RET_NOT_SUPPORTED       -1
> > +#define ARM_SMC_MM_RET_INVALID_PARAMS      -2
> > +#define ARM_SMC_MM_RET_DENIED              -3
> > +#define ARM_SMC_MM_RET_NO_MEMORY           -4
> > +
> >  /*
> >   * Power State Coordination Interface (PSCI) calls cover a subset of the
> >   * Standard Service Call range.
> > --
> > 2.14.1
> >
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v2 1/2] ArmPkg/Include: Add standard SMC function IDs for MM interface.
  2017-10-09 15:15     ` Supreeth Venkatesh
@ 2017-10-09 22:19       ` Achin Gupta
  0 siblings, 0 replies; 6+ messages in thread
From: Achin Gupta @ 2017-10-09 22:19 UTC (permalink / raw)
  To: Supreeth Venkatesh
  Cc: Ard Biesheuvel, edk2-devel@lists.01.org, Leif Lindholm, nd

On Mon, Oct 09, 2017 at 04:15:27PM +0100, Supreeth Venkatesh wrote:
> I can do that.

Thanks!

> However, "-4" is missing in the specification. Is there a chance to rectify specification to add "-4", so that I can do both the defines.

To indicate what error? Anyways, lets take this offline. For the time being, the
code should match the spec.

cheers,
Achin

>
> Thanks,
> Supreeth
> -----Original Message-----
> From: Achin Gupta
> Sent: Monday, October 9, 2017 3:52 AM
> To: Ard Biesheuvel <ard.biesheuvel@linaro.org>; Supreeth Venkatesh <Supreeth.Venkatesh@arm.com>
> Cc: Supreeth Venkatesh <Supreeth.Venkatesh@arm.com>; edk2-devel@lists.01.org; Leif Lindholm <leif.lindholm@linaro.org>; nd <nd@arm.com>
> Subject: Re: [PATCH v2 1/2] ArmPkg/Include: Add standard SMC function IDs for MM interface.
>
> Hi Ard/Supreeth,
>
> On Fri, Oct 06, 2017 at 10:05:46PM +0100, Ard Biesheuvel wrote:
> > On 27 September 2017 at 19:58, Supreeth Venkatesh
> > <supreeth.venkatesh@arm.com> wrote:
> > > This patch adds a list of function IDs that fall under the standard
> > > SMC range as defined in
> > > http://infocenter.arm.com/help/topic/com.arm.doc.den0060a/DEN0060A_ARM_MM_Interface_Specification.pdf.
> > >
> > > SMCs associated with Management Mode are in the range 0xC4000040 -
> > > 0xC400005f (64 bit) and 0x84000040 - 0x8400005f (32 bit).
> > >
> > > The function(s) available to the normal world:
> > > 1. Request services from the secure MM environment using MM_COMMUNICATE.
> > >
> > > It also defines MM return codes.
> > >
> > > Contributed-under: TianoCore Contribution Agreement 1.1
> > > Signed-off-by: Achin Gupta <achin.gupta@arm.com>
> > > Signed-off-by: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
> >
> > Both patches applied. Thanks.
>
> I should have spotted this earlier but the following define is not spec. compliant. It says:
>
> > +#define ARM_SMC_MM_RET_NO_MEMORY           -4
>
> but should be
>
> > +#define ARM_SMC_MM_RET_NO_MEMORY           -5
>
> Supreeth. Could you please submit a patch to rectify this?
>
> cheers,
> Achin
>
> >
> > > ---
> > >  ArmPkg/Include/IndustryStandard/ArmStdSmc.h | 20
> > > +++++++++++++++++++-
> > >  1 file changed, 19 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/ArmPkg/Include/IndustryStandard/ArmStdSmc.h
> > > b/ArmPkg/Include/IndustryStandard/ArmStdSmc.h
> > > index 593a3ce729..37d0796649 100644
> > > --- a/ArmPkg/Include/IndustryStandard/ArmStdSmc.h
> > > +++ b/ArmPkg/Include/IndustryStandard/ArmStdSmc.h
> > > @@ -1,6 +1,6 @@
> > >  /** @file
> > >  *
> > > -*  Copyright (c) 2012-2014, ARM Limited. All rights reserved.
> > > +*  Copyright (c) 2012-2017, ARM Limited. All rights reserved.
> > >  *
> > >  *  This program and the accompanying materials
> > >  *  are licensed and made available under the terms and conditions
> > > of the BSD License @@ -40,6 +40,24 @@
> > >  #define ARM_SMC_STD_REVISION_MAJOR    0x0
> > >  #define ARM_SMC_STD_REVISION_MINOR    0x1
> > >
> > > +/*
> > > + * Management Mode (MM) calls cover a subset of the Standard Service Call range.
> > > + * The list below is not exhaustive.
> > > + */
> > > +#define ARM_SMC_ID_MM_VERSION_AARCH32              0x84000040
> > > +#define ARM_SMC_ID_MM_VERSION_AARCH64              0xC4000040
> > > +
> > > +// Request service from secure standalone MM environment
> > > +#define ARM_SMC_ID_MM_COMMUNICATE_AARCH32          0x84000041
> > > +#define ARM_SMC_ID_MM_COMMUNICATE_AARCH64          0xC4000041
> > > +
> > > +/* MM return error codes */
> > > +#define ARM_SMC_MM_RET_SUCCESS              0
> > > +#define ARM_SMC_MM_RET_NOT_SUPPORTED       -1
> > > +#define ARM_SMC_MM_RET_INVALID_PARAMS      -2
> > > +#define ARM_SMC_MM_RET_DENIED              -3
> > > +#define ARM_SMC_MM_RET_NO_MEMORY           -4
> > > +
> > >  /*
> > >   * Power State Coordination Interface (PSCI) calls cover a subset of the
> > >   * Standard Service Call range.
> > > --
> > > 2.14.1
> > >


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2017-10-09 22:15 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-27 18:58 [PATCH v2 1/2] ArmPkg/Include: Add standard SMC function IDs for MM interface Supreeth Venkatesh
2017-09-27 18:58 ` [PATCH v2 2/2] ArmPkg/Include: Add SVC function IDs for Management Mode Supreeth Venkatesh
2017-10-06 21:05 ` [PATCH v2 1/2] ArmPkg/Include: Add standard SMC function IDs for MM interface Ard Biesheuvel
2017-10-09  8:52   ` Achin Gupta
2017-10-09 15:15     ` Supreeth Venkatesh
2017-10-09 22:19       ` Achin Gupta

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox