From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=104.47.1.77; helo=eur01-ve1-obe.outbound.protection.outlook.com; envelope-from=achin.gupta@arm.com; receiver=edk2-devel@lists.01.org Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0077.outbound.protection.outlook.com [104.47.1.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id EFAE321F3C195 for ; Mon, 9 Oct 2017 15:15:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=9QsGLZTIZreH4VISpM3KLtVcJzls9yoSeTcA7kdoePM=; b=f8+xhMQBhdtJJBQuZow2HmlNpg7g62OeFN1v8jUBCFqG6Mwm23j1LAY/t67AuHaFVGVtr1ZVD/a5kDq2+TihPolwUgTPBbon6pspmazxrClci2wGcePgR/Gma8ucPWWPyALSZagrIMlfBdwG4wlCxwDHMV3ylzeUuRXlPVMI7dE= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Achin.Gupta@arm.com; Received: from e104320-lin (217.140.96.140) by DB6PR08MB2693.eurprd08.prod.outlook.com (2603:10a6:6:25::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Mon, 9 Oct 2017 22:18:59 +0000 Date: Mon, 9 Oct 2017 23:19:43 +0100 From: Achin Gupta To: Supreeth Venkatesh Cc: Ard Biesheuvel , "edk2-devel@lists.01.org" , Leif Lindholm , nd Message-ID: <20171009221942.GG26498@e104320-lin> References: <20170927185859.27833-1-supreeth.venkatesh@arm.com> <20171009085202.GW26498@e104320-lin> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Originating-IP: [217.140.96.140] X-ClientProxiedBy: AM6PR0202CA0024.eurprd02.prod.outlook.com (2603:10a6:209:15::37) To DB6PR08MB2693.eurprd08.prod.outlook.com (2603:10a6:6:25::14) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e39e8265-5514-43e9-3c4f-08d50f63bd44 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254152)(48565401081)(2017052603199)(201703131423075)(201703031133081)(201702281549075); SRVR:DB6PR08MB2693; X-Microsoft-Exchange-Diagnostics: 1; DB6PR08MB2693; 3:v4M1muKwuCJBf/qBEWXbYtHtzIYWSBgnRssZfR1o6TlB2PtgMDh0fRpxcDP4BS/1Q6cgVXCOzC19ilJ5AR5e314sjIzRi/RjISkcOWPueVjDUMYzXsdfa+ZXQJTIJ+2VWAtKaogS1hM1duLOdTuXAu1t2hK4PZsHMKqnHCI/Jk8qNLZOTMC1NQES4MZ6XNZ7xrgRUuJzUFFcu+vTwHV6E690X257nIQjzV/dibelTPeAxCi820Rw9QO+pKcFYLwZ; 25:OstnmARPGZ5qWc41JhvIOQO5idmx0qf4+1uQ54p9aqDr5XQHSZcNsGbCZHy2YcR/OpzmNxDH+TqhUiW9rmKeSiC3F1apbir/eUW+G/9W4j25kfTAfaBMkVubLbX/+JTrGrxmVErGbC2g5VwUMJjBdnYNl8Cc0Ytzj3zy7RBY2lbr1y8cQbn0Z0ObBY3aKrWbO96xw9g5S6AiPL0jvzQSQ5dKdiREX5k+xKw8yKpQnOr7wRDF5PJ6Fh7QJdKn04ixesUxZdlDXvCfzrsaRkK/Tb+OcQ20Cc+rH14LAR6rS62T7+em0eCBqWuDN5hv+IOaPw6ash77pu5TmQ9ZQfHHAw==; 31:ZQbmbFGSUtczIQqRk5oCng06yIIfTWwFx8PjQRUlpSFu2DlBiibQhmEBQfYPF9w2sXv3zGDXrSi+NXSNP8iRNunQG/58AJjX4sfKpRjukryvllTbclqgqQumos0IUgOuCTJyinJjg8+A7vcS4Gr3j9yVXGBx3PD78kwfwiKs2YQ41jp/kstDmi85zle3IRmVcXuk9Ke4MS0kND0+7hQu3GbDJL5U+qasPUD0xGq2ktE= X-MS-TrafficTypeDiagnostic: DB6PR08MB2693: NoDisclaimer: True X-Microsoft-Exchange-Diagnostics: 1; DB6PR08MB2693; 20:+/B4Ae9zbQf4CZ3oLTNa9vw9LAVdi/JiyqobKOFJeHYqJzJGiO23MrNSU66IhwK3UqnOucmU+U0zK2O/+CpgiN+JSXIsJRnZPgZEsvrnXdMIYCCQnMijjHoUTAHK5UiD6Df9jGI4dcikdw69CC2mglnQAoZj2cR6tYdh70gBZMI=; 4:Dx6p5ESCVHzuOehVtleYAOk30cqRcq84rI9rVb6pu/bYjt+xceBCQhwVBfpMWLzDOIB45vOtMVyvxyXzpZW7zACP8NfwU5rN8OB+TDAL7Ffy55mG1/n1vOUTvHtNgchSc6KqatiEYJgonazK4zkq5Hx8e5Ti4tjKGtbNnwu3MXIFXImYIdTyBK/0wzDa/EY2V2l07Ew2zAVvaBU4QbNPagJTvvHY5Uk4HPaYFEpxZecLUlFMN+RdGIGLNRTCi/sYhEkZ3WEhgmsxob6xHbS/TYjBlJr78fqEqGHnPmjRuNvqp2q+eXWf+GwZlodGT8i9NnxkHbtZy+KxzvX313JVTA== X-Exchange-Antispam-Report-Test: UriScan:(180628864354917)(162533806227266); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(10201501046)(100000703101)(100105400095)(93006095)(93001095)(3002001)(6055026)(6041248)(20161123560025)(20161123564025)(20161123562025)(20161123558100)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:DB6PR08MB2693; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:DB6PR08MB2693; X-Forefront-PRVS: 045584D28C X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(376002)(39860400002)(346002)(199003)(24454002)(189002)(377454003)(13464003)(83506001)(316002)(4326008)(1076002)(6246003)(6306002)(9686003)(54906003)(6862004)(2906002)(81166006)(81156014)(8936002)(8676002)(305945005)(106356001)(16526018)(53546010)(105586002)(55016002)(101416001)(33656002)(97736004)(66066001)(76176999)(189998001)(50986999)(478600001)(54356999)(86362001)(25786009)(72206003)(6636002)(229853002)(2950100002)(6666003)(966005)(50466002)(23726003)(3846002)(6116002)(6496005)(58126008)(7736002)(53936002)(16586007)(68736007)(33716001)(5660300001)(93886005)(47776003)(18370500001)(107986001); DIR:OUT; SFP:1101; SCL:1; SRVR:DB6PR08MB2693; H:e104320-lin; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DB6PR08MB2693; 23:CRWPtGeopNNmyX3W0TGg1dCFx1RVcr8cNis0RNFjj?= =?us-ascii?Q?kLly8V97BxcWI3KFV7ZW5EUoCTrsEYE7FXccEuDdNxfGlnB5VzmMZTLPsh4J?= =?us-ascii?Q?hkVSMAZAZOgSpVKnAjVNJE6FdpvSFllaQv9q9d9PLe+4eZx7sGjC+92uoloa?= =?us-ascii?Q?m2T1gM76dvjgp8/kLL6HntEwJm+kEn4vqpN72OKupaFJfJEEVuiyzbw/qeqP?= =?us-ascii?Q?7zdw+2UQ7wypasOPxQ1neKkYvGyQRxgA0Hr4shD3Pnf9s0PIb/08dv7b6ncf?= =?us-ascii?Q?W5gnu/jvTT6ORGLxhGcZVRug4f49ZuvU+jub9FA9cAnKD0/OD2OrA8kXFeB+?= =?us-ascii?Q?hJv1fEIdrxJl6xlnDXCEzs/gaKiCJGj65HhkT5q7oJrBKFnrp2OStrjNSvT7?= =?us-ascii?Q?ehWgBp/UdxLbBaoshq8wjY4VNe43Y//dT90Z/Mnyp16de+0Sod8toaNSmm0L?= =?us-ascii?Q?ZjXQeHGYIbscQj7AJwXg4cUhOfzYABe9bOsN/Tcz28ZkckevW8ocgMxdrzQB?= =?us-ascii?Q?Q83FbL12f5haOJ8navuXr4c53vnQcHj92MiL8rDEDEPjKIF/+1gNqjJnuamz?= =?us-ascii?Q?LvbIT21UJMxdC1QUAj3PXIkduYV327kXARsYzi59fyvapIvgpuGPiAqoE/1F?= =?us-ascii?Q?tUKJPCOKuvvV/6dsN2lxle0WoTARAig1sNsNiv733Lfd52ZK0g6bSrUOjxuk?= =?us-ascii?Q?RIjTelwmS4gYKUne4RB/nR9AZm6PlB4+QS9GaIpNU2dtbp5fyEUjKi1ErxTu?= =?us-ascii?Q?rADM1t2kTdBpb8D3kXu+5D4mYgzgfpH+XuV5u1TAGq4v1zVidiRTxzZoEp87?= =?us-ascii?Q?7GffEuYPVVLfkikKKKmcJhP9pFWFW0jlyuBSSwdeF7NNbCHu4sthcegiRhvk?= =?us-ascii?Q?JiAwqqyVPXp2lTXxtM5rUWjpbnjZI7SXjJ6gdFwQjBuaoBK3HWPgCga9ZmhC?= =?us-ascii?Q?inPATTW5FwrDWQQLBD51f/+GuSrNDtb1ESqfxmEcuylYjnTzlmuThiLC1MoI?= =?us-ascii?Q?2045ncfEp7KMHDAW7XJVYhNyXCGFYzSgxz+GrzY0kBI2ygBuR+7dH+XKm2lr?= =?us-ascii?Q?Ie7DTIIGkV5SMJlTvMOhCyNy/TuOQL/wjLMWXC8+dB8wDQ1FYIqtV756dku4?= =?us-ascii?Q?seDYQ/k6qhiOXdT8xmubC0m1Bqu/9p+UY21uQ7TlKff0xOlTaoIx59Fh0pe9?= =?us-ascii?Q?3Xwa42Pt9SPs/I92/cKI5+f22KizobSx3SwU9Gsu/Ozh6Tgx4wCp1ygQhNzG?= =?us-ascii?Q?3bG90yBoB8pPRgxEUwmF0w77kXEmpfphYfrAXZiSz51aNQvjtb3Zn5bxQCDH?= =?us-ascii?Q?4L28/qqUh1fU6bpEuzhyCyHVA4N0f40K4AfoDkhMiLYusNSLGmD73pLDvSUz?= =?us-ascii?Q?jRM6ozwmqD99TgRjcm1IoMEg31dubGhwzS7jlzY0aChFOqhs0qa7vCj0WdCw?= =?us-ascii?Q?j3VxQtYsg=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; DB6PR08MB2693; 6:RVP3XA0f1C53duuIrbTkiKzCs/FkKKDS/e0G2czRupS+71Z5m+oTDzwTZdfkcTZOJYFnERLNfmPJMeTCaUlJsAretFJDYET2cQI4ZZY/ryDWbLso1bcq2BI57Wy5321V52ul4CsRFortnrZFFMn3DnhsPNhPhYsPSm9F9wlJyoqJ8yqfbyUWlzpD5vkVcy4/q2CXikcXi0Q4hObIKhe9lRPQUboAmbHoyqsmoHS2DrKQQsz+nSa+La095O1Adyqhvx/0b+hk3lglDC1enHCtIMfELt4WuKlW/mKy/ToMBrSF91A2OBgB4LwhthTJwmHSNi5gFP5rPJyOJFTQBRszdg==; 5:gPnLLSyyhGdGxg45kjYx/DGcL5sFLhU2TCQB+dA5fvEo7TpK6Uxp05x8+ltDCEhRpg30ABNECPOyv2j6nYMgmVTK83qq3WmFUV0Qv4NFxPYlp7lQ9HVKIBEH0rn9qjYFYT4mawpXQi8cM6BfkBstow==; 24:U/7KaVJxaEF50X0JIpHjXgyqjh3w5AFp3el1MsyjitnyKmGhBKPMfAoXLZm53G8efkWB+RfzCD4uq9PTtDg2Z7BeMTYk1GYcN3e0SJ+CPyU=; 7:EUkhEPziC8FuwPETXzB1GmvqsbOzGc9zeF83wMWkwlzRoWRqwdgWHLOqvD3MJnCHUUBoZEShClWglHxakDJapHaeBrv5aiD4eqymCfCC1jhj1Q3yMLF3zTgQbLn+9kmu7yzeJFiswGirOZeb+q2d02u4egIq6KsTdzYScC3kcTLz0p1UAKJbYcShy5VgM1MBA/kjA8fC0bUhtk5B4bqhEOaIMwOE7F/pyBBCXAPvGXY= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Oct 2017 22:18:59.1681 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR08MB2693 Subject: Re: [PATCH v2 1/2] ArmPkg/Include: Add standard SMC function IDs for MM interface. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Oct 2017 22:15:35 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Oct 09, 2017 at 04:15:27PM +0100, Supreeth Venkatesh wrote: > I can do that. Thanks! > However, "-4" is missing in the specification. Is there a chance to rectify specification to add "-4", so that I can do both the defines. To indicate what error? Anyways, lets take this offline. For the time being, the code should match the spec. cheers, Achin > > Thanks, > Supreeth > -----Original Message----- > From: Achin Gupta > Sent: Monday, October 9, 2017 3:52 AM > To: Ard Biesheuvel ; Supreeth Venkatesh > Cc: Supreeth Venkatesh ; edk2-devel@lists.01.org; Leif Lindholm ; nd > Subject: Re: [PATCH v2 1/2] ArmPkg/Include: Add standard SMC function IDs for MM interface. > > Hi Ard/Supreeth, > > On Fri, Oct 06, 2017 at 10:05:46PM +0100, Ard Biesheuvel wrote: > > On 27 September 2017 at 19:58, Supreeth Venkatesh > > wrote: > > > This patch adds a list of function IDs that fall under the standard > > > SMC range as defined in > > > http://infocenter.arm.com/help/topic/com.arm.doc.den0060a/DEN0060A_ARM_MM_Interface_Specification.pdf. > > > > > > SMCs associated with Management Mode are in the range 0xC4000040 - > > > 0xC400005f (64 bit) and 0x84000040 - 0x8400005f (32 bit). > > > > > > The function(s) available to the normal world: > > > 1. Request services from the secure MM environment using MM_COMMUNICATE. > > > > > > It also defines MM return codes. > > > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > > Signed-off-by: Achin Gupta > > > Signed-off-by: Supreeth Venkatesh > > > > Both patches applied. Thanks. > > I should have spotted this earlier but the following define is not spec. compliant. It says: > > > +#define ARM_SMC_MM_RET_NO_MEMORY -4 > > but should be > > > +#define ARM_SMC_MM_RET_NO_MEMORY -5 > > Supreeth. Could you please submit a patch to rectify this? > > cheers, > Achin > > > > > > --- > > > ArmPkg/Include/IndustryStandard/ArmStdSmc.h | 20 > > > +++++++++++++++++++- > > > 1 file changed, 19 insertions(+), 1 deletion(-) > > > > > > diff --git a/ArmPkg/Include/IndustryStandard/ArmStdSmc.h > > > b/ArmPkg/Include/IndustryStandard/ArmStdSmc.h > > > index 593a3ce729..37d0796649 100644 > > > --- a/ArmPkg/Include/IndustryStandard/ArmStdSmc.h > > > +++ b/ArmPkg/Include/IndustryStandard/ArmStdSmc.h > > > @@ -1,6 +1,6 @@ > > > /** @file > > > * > > > -* Copyright (c) 2012-2014, ARM Limited. All rights reserved. > > > +* Copyright (c) 2012-2017, ARM Limited. All rights reserved. > > > * > > > * This program and the accompanying materials > > > * are licensed and made available under the terms and conditions > > > of the BSD License @@ -40,6 +40,24 @@ > > > #define ARM_SMC_STD_REVISION_MAJOR 0x0 > > > #define ARM_SMC_STD_REVISION_MINOR 0x1 > > > > > > +/* > > > + * Management Mode (MM) calls cover a subset of the Standard Service Call range. > > > + * The list below is not exhaustive. > > > + */ > > > +#define ARM_SMC_ID_MM_VERSION_AARCH32 0x84000040 > > > +#define ARM_SMC_ID_MM_VERSION_AARCH64 0xC4000040 > > > + > > > +// Request service from secure standalone MM environment > > > +#define ARM_SMC_ID_MM_COMMUNICATE_AARCH32 0x84000041 > > > +#define ARM_SMC_ID_MM_COMMUNICATE_AARCH64 0xC4000041 > > > + > > > +/* MM return error codes */ > > > +#define ARM_SMC_MM_RET_SUCCESS 0 > > > +#define ARM_SMC_MM_RET_NOT_SUPPORTED -1 > > > +#define ARM_SMC_MM_RET_INVALID_PARAMS -2 > > > +#define ARM_SMC_MM_RET_DENIED -3 > > > +#define ARM_SMC_MM_RET_NO_MEMORY -4 > > > + > > > /* > > > * Power State Coordination Interface (PSCI) calls cover a subset of the > > > * Standard Service Call range. > > > -- > > > 2.14.1 > > >