From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::22c; helo=mail-wm0-x22c.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x22c.google.com (mail-wm0-x22c.google.com [IPv6:2a00:1450:400c:c09::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 99C2321F3C1AE for ; Tue, 10 Oct 2017 07:35:05 -0700 (PDT) Received: by mail-wm0-x22c.google.com with SMTP id l68so5983469wmd.5 for ; Tue, 10 Oct 2017 07:38:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=uPa1IZ3Y3zYOnYxYoEh2RXLLZIaoUQXbFi76a0zpT+Q=; b=YSAOYzuoKsiQkAQ+Dhurz7r54lcTOtZTvyHUc18VLTHcEDUjG5dcRdOQaoKGtp6NhK MoVs4s4iyUYtRNor+YjbGqn+RtHX1zF5nJm6/LBc/7FWt35TVO/Ixx5ADrTDcc606ecT ODKrhTYahKzVDVD3Fx0gag6f1x1K7kmc2gHpE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=uPa1IZ3Y3zYOnYxYoEh2RXLLZIaoUQXbFi76a0zpT+Q=; b=Is0Pou4xZOITzqIVg4tD/OMCVNa9lz5YX1qoCeTLDrOzc2K9jqOu5iqvyXDXGDpdoC QKSx7Z6UppdhMmONoaeGGPUXmSoyBKhRzNwLlyQ09psLRJOIAIVzTXCM18zaMFE5tCHy pmEuGYBP7gMJnRQTKMkWV9LTNh/s+QSJyWN1fRz2QObSImJ/d0EQp7OBgsRwsHddtDw8 0juXtdcOLTA/cOckrrE8uMtjAKL1brbOBtazU/ug0IcCzYsxCgtoe6KOeG38ULF4Om7O Pp5jdmfVKz5/GPGel2gSLzgb3UBwiND2aOYuDB8FI6p6OBNF5loJOx13t9bzJBJxzjHR v76A== X-Gm-Message-State: AMCzsaV7sSWEG1P1f16dwRtpGmp8pKwotRbdYIMMrq38p/4x+kvcM5pt f1tlQQrlnA4gWnSBZBK2XfDLHg== X-Google-Smtp-Source: AOwi7QB44SjW9dBhlW96K57xno8zFujFWhUFGl1PskYg7fzveLDQjY+RLgCqzVOHFRSuDK6I3kXgDA== X-Received: by 10.223.130.194 with SMTP id 60mr13363459wrc.50.1507646312509; Tue, 10 Oct 2017 07:38:32 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id 69sm10635404wmm.2.2017.10.10.07.38.31 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 10 Oct 2017 07:38:31 -0700 (PDT) Date: Tue, 10 Oct 2017 15:38:29 +0100 From: Leif Lindholm To: Marcin Wojtas Cc: edk2-devel@lists.01.org, ard.biesheuvel@linaro.org, nadavh@marvell.com, neta@marvell.com, kostap@marvell.com, jinghua@marvell.com, jsd@semihalf.com Message-ID: <20171010143829.7zgnndchsv2jxi4h@bivouac.eciton.net> References: <1507568462-28775-1-git-send-email-mw@semihalf.com> <1507568462-28775-3-git-send-email-mw@semihalf.com> MIME-Version: 1.0 In-Reply-To: <1507568462-28775-3-git-send-email-mw@semihalf.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [platforms: PATCH 02/13] Marvell/Armada: Switch to dynamic PCDs X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Oct 2017 14:35:05 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Oct 09, 2017 at 07:00:51PM +0200, Marcin Wojtas wrote: > From: Ard Biesheuvel > > For full functionality, including HII forms wired to non-volatile UEFI > variables, we need dynamic PCDs as well. So let's enable those. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel > Signed-off-by: Marcin Wojtas Reviewed-by: Leif Lindholm > --- > Platform/Marvell/Armada/Armada.dsc.inc | 10 +++++++--- > Platform/Marvell/Armada/Armada70x0.fdf | 1 + > 2 files changed, 8 insertions(+), 3 deletions(-) > > diff --git a/Platform/Marvell/Armada/Armada.dsc.inc b/Platform/Marvell/Armada/Armada.dsc.inc > index 417bb0c..433892e 100644 > --- a/Platform/Marvell/Armada/Armada.dsc.inc > +++ b/Platform/Marvell/Armada/Armada.dsc.inc > @@ -67,8 +67,7 @@ > UefiHiiServicesLib|MdeModulePkg/Library/UefiHiiServicesLib/UefiHiiServicesLib.inf > UefiRuntimeLib|MdePkg/Library/UefiRuntimeLib/UefiRuntimeLib.inf > > - # Assume everything is fixed at build. do not use runtime PCD feature > - PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf > + PcdLib|MdePkg/Library/DxePcdLib/DxePcdLib.inf > > BaseMemoryLib|MdePkg/Library/BaseMemoryLibOptDxe/BaseMemoryLibOptDxe.inf > > @@ -150,6 +149,7 @@ > PrePiHobListPointerLib|ArmPlatformPkg/Library/PrePiHobListPointerLib/PrePiHobListPointerLib.inf > PlatformPeiLib|ArmPlatformPkg/PlatformPei/PlatformPeiLib.inf > ArmGicArchLib|ArmPkg/Library/ArmGicArchSecLib/ArmGicArchSecLib.inf > + PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf > > [LibraryClasses.common.SEC, LibraryClasses.common.PEIM] > MemoryInitPeiLib|ArmPlatformPkg/MemoryInitPei/MemoryInitPeiLib.inf > @@ -368,10 +368,14 @@ > # DXE > MdeModulePkg/Core/Dxe/DxeMain.inf { > > - PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf > NULL|MdeModulePkg/Library/DxeCrc32GuidedSectionExtractLib/DxeCrc32GuidedSectionExtractLib.inf > } > > + MdeModulePkg/Universal/PCD/Dxe/Pcd.inf { > + > + PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf > + } > + > # Architectural Protocols DXE > ArmPkg/Drivers/CpuDxe/CpuDxe.inf > ArmPkg/Drivers/ArmGic/ArmGicDxe.inf > diff --git a/Platform/Marvell/Armada/Armada70x0.fdf b/Platform/Marvell/Armada/Armada70x0.fdf > index 763d76a..b3d1c60 100644 > --- a/Platform/Marvell/Armada/Armada70x0.fdf > +++ b/Platform/Marvell/Armada/Armada70x0.fdf > @@ -95,6 +95,7 @@ FvNameGuid = 5eda4200-2c5f-43cb-9da3-0baf74b1b30c > INF Platform/Marvell/Armada/Drivers/PlatInitDxe/PlatInitDxe.inf > > # PI DXE Drivers producing Architectural Protocols (EFI Services) > + INF MdeModulePkg/Universal/PCD/Dxe/Pcd.inf > INF ArmPkg/Drivers/CpuDxe/CpuDxe.inf > INF ArmPkg/Drivers/ArmGic/ArmGicDxe.inf > INF ArmPkg/Drivers/TimerDxe/TimerDxe.inf > -- > 1.8.3.1 >