From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::22e; helo=mail-wm0-x22e.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x22e.google.com (mail-wm0-x22e.google.com [IPv6:2a00:1450:400c:c09::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 16DE021F3C1AE for ; Tue, 10 Oct 2017 07:35:39 -0700 (PDT) Received: by mail-wm0-x22e.google.com with SMTP id f4so6029112wme.0 for ; Tue, 10 Oct 2017 07:39:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=HJ85chXalMYhXx+pF/KyQ4NAJcF6v5FdCSsF6vXmkTk=; b=kSxHk1+0HoWwP+v5lvEtSKBixXRUa1BfOxM59ac9rdqH261NJZgniIb+F201OYgbQK eciUa5EIl6gqOYSuJbAUGNYM4ufBNt7oAkKDJIRnDScWwMW58vKfiGXJsfGcv440xBYO msCh94o70ZnT0KKFMgVX/Cccgx3RWtMPWQNbA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=HJ85chXalMYhXx+pF/KyQ4NAJcF6v5FdCSsF6vXmkTk=; b=i++bluKb0aoAku2HaVhd4EDy6/R3J0NnOHOruTTHKt2/JDnBgR0R2Si8vavIYRgW69 n1bY3NNQadIcH5tRKWava6YbnOUoWfM9ddSMsQ2R3sifr/I2/V1PlecASL86JfVe1reB 8rwmDvruEi8I7yRiG6RpfrifomGyLNUyyCC0Dv5zSc6tmJ6AI1EjHAybxSl0iglV36PI MBBB7cp35vbsjry3+kKujVac/Y1thvrOjzuA3XO3rKILNOX0tYDRoJS1EAoZRHgCLFDj l4FjM6U2IFOkFU6b1SofGsQkWSrK+xSIQ8QI+4ejVp7ktPTDvWzGYA/PxluaOdHatquB TP2g== X-Gm-Message-State: AMCzsaUFGo50JOx6Oz3+vcy0jtWMagLt6nJ01SWOq3FvLnQ3/LpjhWR5 d3L33QfFhzIsJdc+/3iexGN1sg== X-Google-Smtp-Source: AOwi7QCdg0NIiiVTdW6u8/PqEdoorFT7AUV7Hox+X9ZoDDQW+ZmvPuMi/nRoxbfNCAl8/IAg09vqVw== X-Received: by 10.28.232.138 with SMTP id f10mr10809341wmi.130.1507646346023; Tue, 10 Oct 2017 07:39:06 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id o20sm10611778wro.71.2017.10.10.07.39.04 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 10 Oct 2017 07:39:04 -0700 (PDT) Date: Tue, 10 Oct 2017 15:39:03 +0100 From: Leif Lindholm To: Marcin Wojtas Cc: edk2-devel@lists.01.org, ard.biesheuvel@linaro.org, nadavh@marvell.com, neta@marvell.com, kostap@marvell.com, jinghua@marvell.com, jsd@semihalf.com Message-ID: <20171010143903.bhlnqjqn4vzgc4mz@bivouac.eciton.net> References: <1507568462-28775-1-git-send-email-mw@semihalf.com> <1507568462-28775-4-git-send-email-mw@semihalf.com> MIME-Version: 1.0 In-Reply-To: <1507568462-28775-4-git-send-email-mw@semihalf.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [platforms: PATCH 03/13] Marvell/Armada: Armada70x0Lib: Terminate call stack list at entry X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Oct 2017 14:35:39 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Oct 09, 2017 at 07:00:52PM +0200, Marcin Wojtas wrote: > From: Ard Biesheuvel > > To avoid dereferencing junk when walking the call stack in exception > handlers (which may prevent us from getting a full backtrace), set > the frame pointer to 0x0 when first entering UEFI. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel > Signed-off-by: Marcin Wojtas Reviewed-by: Leif Lindholm > --- > Platform/Marvell/Armada/Library/Armada70x0Lib/AArch64/ArmPlatformHelper.S | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Platform/Marvell/Armada/Library/Armada70x0Lib/AArch64/ArmPlatformHelper.S b/Platform/Marvell/Armada/Library/Armada70x0Lib/AArch64/ArmPlatformHelper.S > index 9265636..72f8cfc 100644 > --- a/Platform/Marvell/Armada/Library/Armada70x0Lib/AArch64/ArmPlatformHelper.S > +++ b/Platform/Marvell/Armada/Library/Armada70x0Lib/AArch64/ArmPlatformHelper.S > @@ -16,6 +16,7 @@ > #include > > ASM_FUNC(ArmPlatformPeiBootAction) > + mov x29, xzr > ret > > //UINTN > -- > 1.8.3.1 >