From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::233; helo=mail-wm0-x233.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x233.google.com (mail-wm0-x233.google.com [IPv6:2a00:1450:400c:c09::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id CE3BF21F3C1B9 for ; Tue, 10 Oct 2017 07:42:05 -0700 (PDT) Received: by mail-wm0-x233.google.com with SMTP id f4so6089731wme.0 for ; Tue, 10 Oct 2017 07:45:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=YlfCIoV97GiZSgBa1WolvC4CQDZSgbjEPiN1moLoKSc=; b=XkEOo6vSBuy1Hv2anACVoEfDCXI2HSzmzSDldUGTJPq8FMcnA+leJ+a3053gNT6anJ OU7aW/svdG81KaPJMCUiq/KM89qSWIZHAwerCl9jo8kiRF5C9w743+2DmOTjK6zrVmpt IHw+Lz2aCYcEmjA+n0fPKV5eiCgRHSbjuZctg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=YlfCIoV97GiZSgBa1WolvC4CQDZSgbjEPiN1moLoKSc=; b=SWfRgvNKbrZykmEOz9Ps3/mn+H1eL2YeQ+h+DJZKAqqvMZFB4zze60QRzXHU0QO2Y5 emoncEXyLR1wWr95nbeCNZv5ycRzNpyaUz7turBx/ckmC3dDwvWZGH8Pfk321oynLPFz PVXRwptshooFTcEQ0DpqanH8QseIoQndOuF/K8ZQheOurdwrUfBknlSZH0ymC0TGNAJF tET20SudKaLwouD95wKAODy6Iva9HsZ9NWXbajGDrtCmrNAcVNgrX07pmmvAUyWMK349 jzowGbUri5ZdtlV3/BC886MMB2E5IbjckBnWBEtYrKiiIsi0eotlx9ldrQPin0j8bNuk VhkA== X-Gm-Message-State: AMCzsaVDFoGiq/JAUgpDFvv4sX6y8o/5W3/OhrJ8cwUX/bPkKgb0Uya1 CmwRJo1dOqSGuMaEMUrhXb4h6w== X-Google-Smtp-Source: AOwi7QCYrxeTC10f3QHIw+l7GRJt2eNiqf7rSDdPBt497B6WnVyblkWqcBMsHYpXlAwwh804lAR2zA== X-Received: by 10.223.136.90 with SMTP id e26mr12549112wre.143.1507646732709; Tue, 10 Oct 2017 07:45:32 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id 10sm8600739wmy.35.2017.10.10.07.45.31 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 10 Oct 2017 07:45:31 -0700 (PDT) Date: Tue, 10 Oct 2017 15:45:30 +0100 From: Leif Lindholm To: Marcin Wojtas Cc: edk2-devel@lists.01.org, ard.biesheuvel@linaro.org, nadavh@marvell.com, neta@marvell.com, kostap@marvell.com, jinghua@marvell.com, jsd@semihalf.com Message-ID: <20171010144530.yjn32rqgytyf6xqt@bivouac.eciton.net> References: <1507568462-28775-1-git-send-email-mw@semihalf.com> <1507568462-28775-7-git-send-email-mw@semihalf.com> MIME-Version: 1.0 In-Reply-To: <1507568462-28775-7-git-send-email-mw@semihalf.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [platforms: PATCH 06/13] Marvell/Armada: Switch to generic BDS X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Oct 2017 14:42:06 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Oct 09, 2017 at 07:00:55PM +0200, Marcin Wojtas wrote: > From: Ard Biesheuvel > > Switch from the Intel BDS to the generic BDS, which is preferred for > ARM platforms given that it is completely legacy free. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel > Signed-off-by: Marcin Wojtas Reviewed-by: Leif Lindholm > --- > Platform/Marvell/Armada/Armada.dsc.inc | 19 ++++++++++++++++--- > Platform/Marvell/Armada/Armada70x0.fdf | 3 ++- > 2 files changed, 18 insertions(+), 4 deletions(-) > > diff --git a/Platform/Marvell/Armada/Armada.dsc.inc b/Platform/Marvell/Armada/Armada.dsc.inc > index 1b4e713..e920461 100644 > --- a/Platform/Marvell/Armada/Armada.dsc.inc > +++ b/Platform/Marvell/Armada/Armada.dsc.inc > @@ -126,8 +126,9 @@ > > # BDS Libraries > CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf > - GenericBdsLib|IntelFrameworkModulePkg/Library/GenericBdsLib/GenericBdsLib.inf > - PlatformBdsLib|ArmPlatformPkg/Library/PlatformIntelBdsLib/PlatformIntelBdsLib.inf > + BootLogoLib|MdeModulePkg/Library/BootLogoLib/BootLogoLib.inf > + FileExplorerLib|MdeModulePkg/Library/FileExplorerLib/FileExplorerLib.inf > + PlatformBootManagerLib|ArmPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf > CustomizedDisplayLib|MdeModulePkg/Library/CustomizedDisplayLib/CustomizedDisplayLib.inf > FdtLib|EmbeddedPkg/Library/FdtLib/FdtLib.inf > > @@ -350,6 +351,12 @@ > # Shell. > gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE > > + # GUID of the generic BDS UiApp > + gEfiMdeModulePkgTokenSpaceGuid.PcdBootManagerMenuFile|{ 0x21, 0xaa, 0x2c, 0x46, 0x14, 0x76, 0x03, 0x45, 0x83, 0x6e, 0x8a, 0xb6, 0xf4, 0x66, 0x23, 0x31 } > + > + # use the 'TTYTERM' terminal type for optimal compatibility with Linux terminal emulators > + gEfiMdePkgTokenSpaceGuid.PcdDefaultTerminalType|4 > + > # ARM Pcds > gArmTokenSpaceGuid.PcdSystemMemoryBase|0 > gArmTokenSpaceGuid.PcdSystemMemorySize|0x40000000 > @@ -459,7 +466,13 @@ > MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf > MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf > MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf > - IntelFrameworkModulePkg/Universal/BdsDxe/BdsDxe.inf > + MdeModulePkg/Universal/BdsDxe/BdsDxe.inf > + MdeModulePkg/Application/UiApp/UiApp.inf { > + > + NULL|MdeModulePkg/Library/DeviceManagerUiLib/DeviceManagerUiLib.inf > + NULL|MdeModulePkg/Library/BootManagerUiLib/BootManagerUiLib.inf > + NULL|MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenanceManagerUiLib.inf > + } > > # UEFI application (Shell Embedded Boot Loader) > ShellPkg/Application/Shell/Shell.inf { > diff --git a/Platform/Marvell/Armada/Armada70x0.fdf b/Platform/Marvell/Armada/Armada70x0.fdf > index b3d1c60..999b968 100644 > --- a/Platform/Marvell/Armada/Armada70x0.fdf > +++ b/Platform/Marvell/Armada/Armada70x0.fdf > @@ -175,7 +175,8 @@ FvNameGuid = 5eda4200-2c5f-43cb-9da3-0baf74b1b30c > INF MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf > INF MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf > INF MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf > - INF IntelFrameworkModulePkg/Universal/BdsDxe/BdsDxe.inf > + INF MdeModulePkg/Universal/BdsDxe/BdsDxe.inf > + INF MdeModulePkg/Application/UiApp/UiApp.inf > > > # PEI phase firmware volume > -- > 1.8.3.1 >