From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::235; helo=mail-wm0-x235.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x235.google.com (mail-wm0-x235.google.com [IPv6:2a00:1450:400c:c09::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1345121F3C1B9 for ; Tue, 10 Oct 2017 07:42:55 -0700 (PDT) Received: by mail-wm0-x235.google.com with SMTP id i124so5848360wmf.3 for ; Tue, 10 Oct 2017 07:46:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=FKurKE4icfmESNrRwhh1WMSTO15PbrJImgJl20kNMFI=; b=OcTecx3Y0vpb/2xFu7vh/0RWM3Ue0i9hzQe5Fa6WjAvGKIBTU6fijlfzEwVNCwoh7w SeFGqwzkW7VL9y89j/33VJoGQPua2CrcYOxTZxQSuoT7cCFaBIVqDYrHW7RISvsc8ltH Mz1B6ZLU7r89BIl9Yo47/zWBSvl+lFMrRUWSo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=FKurKE4icfmESNrRwhh1WMSTO15PbrJImgJl20kNMFI=; b=MI274J8pLHURNI+Z/rD6ibfR5bPU4+0PNPFt4eIVhIPT5fB+LGEoLv8Ult7yBL6YLr id+3EDfuIIgIsRdZjrpOiWhdLT0v/Y9vbObBWmOo6HZcMk50mzvcwu/LQDeUM3uDAc31 k7U3RSr2dGUduNykUVjirMbR4eIdjfIzwPljPc+YXp++xvJkHo4ICOV9fLGmttObZzwQ wWTNZQjqkl7+O3yCT0UUFsj8kUk7jD7BE1lGHzDSKs1vLDOBfsQBjugZMadWyOulcwVw cdaHwqdFRC347NUVcQJJxBCT05Qgh+omI87FGf2KA/ZmP41vyDT9bjt1tWU3kXciFSgC prrg== X-Gm-Message-State: AMCzsaU7+A9oEthw+nJ/oXIILFx+5vPVGO1pcllXAEwcz5pC+sb9tAzd zsKz4VG8hORTfUFoI3lMjDRfmw== X-Google-Smtp-Source: AOwi7QAFPNzsHLXI+E6XdGLyXfI5144itvSFxvP1bDqHhhspJCQqysuN0dglw1bUHQSGViLCONU9gw== X-Received: by 10.28.29.130 with SMTP id d124mr13187601wmd.73.1507646782087; Tue, 10 Oct 2017 07:46:22 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id g25sm16352144wmc.16.2017.10.10.07.46.20 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 10 Oct 2017 07:46:21 -0700 (PDT) Date: Tue, 10 Oct 2017 15:46:19 +0100 From: Leif Lindholm To: Marcin Wojtas Cc: edk2-devel@lists.01.org, ard.biesheuvel@linaro.org, nadavh@marvell.com, neta@marvell.com, kostap@marvell.com, jinghua@marvell.com, jsd@semihalf.com Message-ID: <20171010144619.56asjr3itlz3htmm@bivouac.eciton.net> References: <1507568462-28775-1-git-send-email-mw@semihalf.com> <1507568462-28775-8-git-send-email-mw@semihalf.com> MIME-Version: 1.0 In-Reply-To: <1507568462-28775-8-git-send-email-mw@semihalf.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [platforms: PATCH 07/13] Marvell/Armada: Re-enable driver model diagnostics PCDs X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Oct 2017 14:42:55 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Oct 09, 2017 at 07:00:56PM +0200, Marcin Wojtas wrote: > From: Ard Biesheuvel > > For some reason, one of the early ARM platforms disabled all the > diagnostics related to the UEFI driver model, resulting in the > output of UEFI shell utilities such as 'devices' or 'drivers' to > become completely useless. Armada's shared .DSC include file > inherited this for no good reason, so let's revert it. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel > Signed-off-by: Marcin Wojtas Reviewed-by: Leif Lindholm > --- > Platform/Marvell/Armada/Armada.dsc.inc | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/Platform/Marvell/Armada/Armada.dsc.inc b/Platform/Marvell/Armada/Armada.dsc.inc > index e920461..5071bd5 100644 > --- a/Platform/Marvell/Armada/Armada.dsc.inc > +++ b/Platform/Marvell/Armada/Armada.dsc.inc > @@ -207,10 +207,6 @@ > ################################################################################ > > [PcdsFeatureFlag.common] > - gEfiMdePkgTokenSpaceGuid.PcdComponentNameDisable|TRUE > - gEfiMdePkgTokenSpaceGuid.PcdDriverDiagnosticsDisable|TRUE > - gEfiMdePkgTokenSpaceGuid.PcdComponentName2Disable|TRUE > - gEfiMdePkgTokenSpaceGuid.PcdDriverDiagnostics2Disable|TRUE > > # > # Control what commands are supported from the UI > -- > 1.8.3.1 >