From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::235; helo=mail-wm0-x235.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x235.google.com (mail-wm0-x235.google.com [IPv6:2a00:1450:400c:c09::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5ED7521F3C1AE for ; Tue, 10 Oct 2017 07:55:15 -0700 (PDT) Received: by mail-wm0-x235.google.com with SMTP id t69so6037713wmt.2 for ; Tue, 10 Oct 2017 07:58:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=wnRzr+O66CKkfrM1Haw/r7p/+l5K4X2Iaa5hZlvsAsg=; b=d+9vgxkjleSEWPAeVJyE5aVYriKQR+C12qdTZp3HZBI61waKBS7Hw/Gw17Tfru6B39 JLtHvWreIw077Y0MY5aQr7dsewcwy0XPpfWCO4wojEZHntnoifAyTTl+BOx4kN/qNqXI PGIdpkUBPIJPFzNUA+xUm3JOSSefPhV9zXjK0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=wnRzr+O66CKkfrM1Haw/r7p/+l5K4X2Iaa5hZlvsAsg=; b=Zm8F3rOdoJtRfCcntH5hvBFVuYuPNifO0YUNolI3WWTRaJ5O/zqAzWBJJJD0kF6Jhg nkANMF0E9LfmCbcZ+KOWpCCY77IWtZWEhLSEc5oPZLbSMtaGsW77qgB3pECxd1xy0Swh icF4l6gGzlY9Hbg3M+fSHDM1e06NGlIqYgP935Jse+Ma6LFpb1prj6on66Ddn9pU1+sR Y7EZ9fq5mfZuKqrAmDDAPkZ4qZeAwnUJul3l95c7F8Sbbcoq3B3+iTT/oYGI7QrDzxlL SHiM6U5LBUJL89GoZcz4ow6go9JFEE42yRJpL8JOk/W9nazPKMIbZ5jk1Ita/Kmvw527 ym/A== X-Gm-Message-State: AMCzsaWy4wpHr3sOKOFjaeg9LqbSiLIdTdsU1k5YooSLL+YAVvwQJcfZ 6fI5PR8dACCJphVhB7EIwMqRDw== X-Google-Smtp-Source: AOwi7QD4awdO979I5a+qgLpG7XEFNERWaFqpYb36tcNPHwEd1nqdEs+sgy8gUkwV6g+6+1G/PsOoKQ== X-Received: by 10.223.135.3 with SMTP id a3mr12039242wra.109.1507647522178; Tue, 10 Oct 2017 07:58:42 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id 38sm4259806wrl.76.2017.10.10.07.58.41 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 10 Oct 2017 07:58:41 -0700 (PDT) Date: Tue, 10 Oct 2017 15:58:39 +0100 From: Leif Lindholm To: Marcin Wojtas Cc: edk2-devel@lists.01.org, ard.biesheuvel@linaro.org, nadavh@marvell.com, neta@marvell.com, kostap@marvell.com, jinghua@marvell.com, jsd@semihalf.com Message-ID: <20171010145839.nxoiifoqrw6s4fnt@bivouac.eciton.net> References: <1507568462-28775-1-git-send-email-mw@semihalf.com> <1507568462-28775-12-git-send-email-mw@semihalf.com> MIME-Version: 1.0 In-Reply-To: <1507568462-28775-12-git-send-email-mw@semihalf.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [platforms: PATCH 11/13] Marvell/Armada: Remove outdated SEC alignment override X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Oct 2017 14:55:15 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Oct 09, 2017 at 07:01:00PM +0200, Marcin Wojtas wrote: > From: Ard Biesheuvel > > The FDFs no longer require explicit alignment for sections containing > aligned objects, so change it to 'Auto' and FIXED (which allows some > padding to be removed), and remove some other cruft while at it. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel > Signed-off-by: Marcin Wojtas > --- > Platform/Marvell/Armada/Armada70x0.fdf | 11 ++--------- > 1 file changed, 2 insertions(+), 9 deletions(-) > > diff --git a/Platform/Marvell/Armada/Armada70x0.fdf b/Platform/Marvell/Armada/Armada70x0.fdf > index 2c3efe0..15ae52b 100644 > --- a/Platform/Marvell/Armada/Armada70x0.fdf > +++ b/Platform/Marvell/Armada/Armada70x0.fdf > @@ -235,16 +235,9 @@ READ_LOCK_STATUS = TRUE > # > ############################################################################ > > -[Rule.ARM.SEC] > - FILE SEC = $(NAMED_GUID) RELOCS_STRIPPED { > - TE TE Align = 32 $(INF_OUTPUT)/$(MODULE_NAME).efi > - } > - > -# The AArch64 Vector Table requires a 2K alignment that is not supported by the FDF specification. > -# It is the reason 4K is used instead of 2K for the module alignment. > [Rule.AARCH64.SEC] > - FILE SEC = $(NAMED_GUID) RELOCS_STRIPPED { > - TE TE Align = 4K $(INF_OUTPUT)/$(MODULE_NAME).efi > + FILE SEC = $(NAMED_GUID) RELOCS_STRIPPED FIXED { > + TE TE Align = Auto $(INF_OUTPUT)/$(MODULE_NAME).efi This does appear to arbitrarily increase indentation of the last entry on the line by 2, shifting it out of alignment with later entries in the file? / Leif > } > > [Rule.Common.PEI_CORE] > -- > 1.8.3.1 >