From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::230; helo=mail-wm0-x230.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x230.google.com (mail-wm0-x230.google.com [IPv6:2a00:1450:400c:c09::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id A95F421E78212 for ; Tue, 10 Oct 2017 08:00:03 -0700 (PDT) Received: by mail-wm0-x230.google.com with SMTP id m72so6076132wmc.1 for ; Tue, 10 Oct 2017 08:03:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=uHfoT50/jcBBjoPvvro3Wb7U7szBHUfgk9GIhvnVkiQ=; b=CqVEonVIrgWgaxKiRpCPl1TdUsoxiFImyYlbKV/nIECZqcXjKH/5+MLplHwb7VEBi/ GKVMHNIPwVDR7WXl9H7Rr0kGeJqXrE0qjnoCuwsamveHpKF0L1r4KRYESdqQScpcsp1K MoDnPgw4XKTnAsvcHU0hFB0Xl6MEkQ2ZTnXI0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=uHfoT50/jcBBjoPvvro3Wb7U7szBHUfgk9GIhvnVkiQ=; b=gQ5qe78qJ+gaXnUsE4O2qbSejMcElAXS7uR8vbP9VEkGjTseNrnxf4q88ae+P6fq2D 7XfceM8oRXVMFgpKv0nm7+RxvOyP7+047Fo3Iao/b1peA+Z60/4aYBsQSrZfS4Rqk8H6 husUpnbiy/rh3RBEUdSnh3ZL+ZLq5kGlujIiE0KIL6Htu72AIU4/RUak7cdHZDwyl6so 54T2nd2TKC3fxJB1nI49gparRPRl2tZSJwb3dShrp8KyjxI5ljj3FMbWG4j9HO5ZZTki gZA+kp4Oj8uvcvFLPkrt7+ulUo+tCQKKVA9Kc++471bvDa9mc5IRPk6cE0X+TCP7lvME tvSg== X-Gm-Message-State: AMCzsaWcwgMJjlAXwkpiz3lZQ+cgmM+QIeUNqK63iSsMfi8QyNl9yIdn GzzikCe4i1Cy2bUFsTVBkfXLnQ== X-Google-Smtp-Source: AOwi7QBZzrIg1up1GNVOjdJ/2jghouxA2DNR73D5GPjmt/3vshY76pWCYGnAACkXChSd4G6Jw3nC0g== X-Received: by 10.28.26.138 with SMTP id a132mr12144739wma.124.1507647810391; Tue, 10 Oct 2017 08:03:30 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id p38sm13723183wrb.41.2017.10.10.08.03.29 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 10 Oct 2017 08:03:29 -0700 (PDT) Date: Tue, 10 Oct 2017 16:03:27 +0100 From: Leif Lindholm To: Marcin Wojtas Cc: edk2-devel-01 , Ard Biesheuvel , nadavh@marvell.com, Neta Zur Hershkovits , Kostya Porotchkin , Hua Jing , semihalf-dabros-jan Message-ID: <20171010150327.43zpe5x6gjo4umrx@bivouac.eciton.net> References: <1507568462-28775-1-git-send-email-mw@semihalf.com> <1507568462-28775-2-git-send-email-mw@semihalf.com> <20171010143715.w4glyje3pw24kvsm@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [platforms: PATCH 01/13] Marvell/Armada: Introduce platform initialization driver X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Oct 2017 15:00:04 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Oct 10, 2017 at 04:45:10PM +0200, Marcin Wojtas wrote: > Hi Leif, > > 2017-10-10 16:37 GMT+02:00 Leif Lindholm : > > On Mon, Oct 09, 2017 at 07:00:50PM +0200, Marcin Wojtas wrote: > >> In order to enable modification of dynamic PCD's for the libraries > >> and DXE drivers, this patch introduces new driver. It is > >> executed prior to other drivers. Mpp, ComPhy and Utmi libraries > >> initialization were moved from PrePi stage to DXE. > >> > >> To force the correct driver dispatch sequence, introduce a protocol GUID > >> and install the protocol as a NULL protocol when PlatInitDxe executes. > >> > >> Contributed-under: TianoCore Contribution Agreement 1.1 > >> Signed-off-by: Marcin Wojtas > >> Signed-off-by: Ard Biesheuvel > > > > What does Ard's Signed-off-by signify here? > > (I know the authorship on some of these is a bit blurred, since you've > > been working together, but I'd like to be clear.) > > These were the lines, introducing/installing protocol GUID stuff. It > was in a small separate patch, but I squashed it into bigger one. Personally, I would in this instance do: Ard It's verbose, but reasonably clear. > > > >> --- > >> Platform/Marvell/Armada/Armada.dsc.inc | 3 ++ > >> Platform/Marvell/Armada/Armada70x0.fdf | 5 +++ > >> Platform/Marvell/Armada/Drivers/PlatInitDxe/PlatInitDxe.c | 44 ++++++++++++++++++++ > >> Platform/Marvell/Armada/Drivers/PlatInitDxe/PlatInitDxe.inf | 44 ++++++++++++++++++++ > >> Platform/Marvell/Armada/Library/Armada70x0Lib/Armada70x0Lib.c | 11 ----- > >> Platform/Marvell/Marvell.dec | 5 +++ > >> 6 files changed, 101 insertions(+), 11 deletions(-) > >> > >> diff --git a/Platform/Marvell/Armada/Armada.dsc.inc b/Platform/Marvell/Armada/Armada.dsc.inc > >> index 89fb7e7..417bb0c 100644 > >> --- a/Platform/Marvell/Armada/Armada.dsc.inc > >> +++ b/Platform/Marvell/Armada/Armada.dsc.inc > >> @@ -378,6 +378,9 @@ > >> ArmPkg/Drivers/TimerDxe/TimerDxe.inf > >> ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdogDxe.inf > >> > >> + # Platform Initialization > >> + Platform/Marvell/Armada/Drivers/PlatInitDxe/PlatInitDxe.inf > >> + > >> # Platform drivers > >> Platform/Marvell/Drivers/I2c/MvI2cDxe/MvI2cDxe.inf > >> MdeModulePkg/Bus/I2c/I2cDxe/I2cDxe.inf > >> diff --git a/Platform/Marvell/Armada/Armada70x0.fdf b/Platform/Marvell/Armada/Armada70x0.fdf > >> index c861e78..763d76a 100644 > >> --- a/Platform/Marvell/Armada/Armada70x0.fdf > >> +++ b/Platform/Marvell/Armada/Armada70x0.fdf > >> @@ -89,6 +89,11 @@ FvNameGuid = 5eda4200-2c5f-43cb-9da3-0baf74b1b30c > >> > >> INF MdeModulePkg/Core/Dxe/DxeMain.inf > >> > >> + # > >> + # Platform Initialization > >> + # > >> + INF Platform/Marvell/Armada/Drivers/PlatInitDxe/PlatInitDxe.inf > >> + > >> # PI DXE Drivers producing Architectural Protocols (EFI Services) > >> INF ArmPkg/Drivers/CpuDxe/CpuDxe.inf > >> INF ArmPkg/Drivers/ArmGic/ArmGicDxe.inf > >> diff --git a/Platform/Marvell/Armada/Drivers/PlatInitDxe/PlatInitDxe.c b/Platform/Marvell/Armada/Drivers/PlatInitDxe/PlatInitDxe.c > >> new file mode 100644 > >> index 0000000..919454b > >> --- /dev/null > >> +++ b/Platform/Marvell/Armada/Drivers/PlatInitDxe/PlatInitDxe.c > >> @@ -0,0 +1,44 @@ > >> +/** @file > >> + Copyright (C) Marvell International Ltd. and its affiliates > > > > We normally need a year here as well. > > If Ard has co-authored parts, I guess we should have Linaro copyright > > notice on affected files as well. > > I have no problem with that, if you find it appropriate, given my > explanation above. Personally I dont mind much, but I think it would be more correct. / Leif