From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::229; helo=mail-wm0-x229.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x229.google.com (mail-wm0-x229.google.com [IPv6:2a00:1450:400c:c09::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0B6D52095B093 for ; Tue, 10 Oct 2017 08:23:25 -0700 (PDT) Received: by mail-wm0-x229.google.com with SMTP id f4so6474586wme.0 for ; Tue, 10 Oct 2017 08:26:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=pmQxO8bKFz4vX/i+cLY9Uk84GT1CvIlpmbX4uHE2wSk=; b=eYlY3spppV0MUyk+Zu+g4Urlc1sqyMfkZzxh+cUVDPhoDvgn2saFYoSweSfer0sm+t 9PKA8Feg/uMzMIup12FsVkLA62w11rieYnANBIq5E0pBY3goEVTMC439K3nonWl11YXR KydmEXWEPK9LQz4Lj1HyzWY3HaBCOyWK+Gx5o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=pmQxO8bKFz4vX/i+cLY9Uk84GT1CvIlpmbX4uHE2wSk=; b=AbM0d4nNYwbs7SM3IGUYyuJZjOYFMrEBgU6IM2sKRjoWc/Fg6f4MxhPClGilhnzJ/m IpctXoMOYBr5cw4tfR8v1RhoEJMBjMms/py/W18NOmVlRnJcVzJHFd6R1Boq5PQwNPh7 kV7DZilpDnegiymQJ6kKq7W2qQ+9T/L7aY405xUbtyKJS4d9HMFv4oeIkWUdy10KaK2s RFk5i5xR9JCvujumwS8o0sfTr0/jwLBSK+1VA4vCGOowl6865i6ndPORAMQcQv6VIuzg c3tFAVw86hFdS5/kP5PdLH1DqdXWVIqnEmFTw2jcEyQNaa8nH1qA9GRd/9aqMU+HV9CP Vnsw== X-Gm-Message-State: AMCzsaVwVpJ4K/aJtVaY6FufteQeQuu+eSg/3fTtSqufHPdzavDAHBP7 rlrCqV90WgBIJJ8pADHci59tig== X-Google-Smtp-Source: AOwi7QBlSj+IukJFD5RSCaOzw1oUNLu+l4lH7lxlsjHbA+rwFJ3IEf1LH/4GKLkuflWKF5kNXDd65A== X-Received: by 10.28.58.81 with SMTP id h78mr11657889wma.10.1507649212916; Tue, 10 Oct 2017 08:26:52 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id v80sm4292730wrc.49.2017.10.10.08.26.50 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 10 Oct 2017 08:26:51 -0700 (PDT) Date: Tue, 10 Oct 2017 16:26:49 +0100 From: Leif Lindholm To: Marcin Wojtas Cc: edk2-devel-01 , Ard Biesheuvel , nadavh@marvell.com, Neta Zur Hershkovits , Kostya Porotchkin , Hua Jing , semihalf-dabros-jan Message-ID: <20171010152649.oau3kjesmjtogb4w@bivouac.eciton.net> References: <1507568462-28775-1-git-send-email-mw@semihalf.com> <1507568462-28775-2-git-send-email-mw@semihalf.com> <20171010143715.w4glyje3pw24kvsm@bivouac.eciton.net> <20171010150327.43zpe5x6gjo4umrx@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [platforms: PATCH 01/13] Marvell/Armada: Introduce platform initialization driver X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Oct 2017 15:23:26 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Oct 10, 2017 at 05:06:42PM +0200, Marcin Wojtas wrote: > 2017-10-10 17:03 GMT+02:00 Leif Lindholm : > > On Tue, Oct 10, 2017 at 04:45:10PM +0200, Marcin Wojtas wrote: > >> Hi Leif, > >> > >> 2017-10-10 16:37 GMT+02:00 Leif Lindholm : > >> > On Mon, Oct 09, 2017 at 07:00:50PM +0200, Marcin Wojtas wrote: > >> >> In order to enable modification of dynamic PCD's for the libraries > >> >> and DXE drivers, this patch introduces new driver. It is > >> >> executed prior to other drivers. Mpp, ComPhy and Utmi libraries > >> >> initialization were moved from PrePi stage to DXE. > >> >> > >> >> To force the correct driver dispatch sequence, introduce a protocol GUID > >> >> and install the protocol as a NULL protocol when PlatInitDxe executes. > >> >> > >> >> Contributed-under: TianoCore Contribution Agreement 1.1 > >> >> Signed-off-by: Marcin Wojtas > >> >> Signed-off-by: Ard Biesheuvel > >> > > >> > What does Ard's Signed-off-by signify here? > >> > (I know the authorship on some of these is a bit blurred, since you've > >> > been working together, but I'd like to be clear.) > >> > >> These were the lines, introducing/installing protocol GUID stuff. It > >> was in a small separate patch, but I squashed it into bigger one. > > > > Personally, I would in this instance do: > > > > Ard > > > > > > It's verbose, but reasonably clear. > > > > How about: > > In order to enable modification of dynamic PCD's for the libraries > and DXE drivers, this patch introduces new driver. It is > executed prior to other drivers. Mpp, ComPhy and Utmi libraries > initialization were moved from PrePi stage to DXE. > > Signed-off-by: Marcin Wojtas > > To force the correct driver dispatch sequence, introduce a protocol GUID > and install the protocol as a NULL protocol when PlatInitDxe executes. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel > Signed-off-by: Marcin Wojtas > > ? > > Was that, what you meant? I think Contibuted-under: still needs to come first. I don't think we have an explicit policy for how to deal with multi-contributor patches. The ones we do see tend to just keep a single commit message and list the contributors. In Linux. it would be something like Signed-off-by: Marcin Wojtas [Introduce protocol GUID to force correct driver dispatch order] Signed-off-by: Ard Biesheuvel Signed-off-by: Marcin Wojtas I would be quite happy to use the same format here. / Leif