From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::229; helo=mail-wm0-x229.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x229.google.com (mail-wm0-x229.google.com [IPv6:2a00:1450:400c:c09::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 6336F21F7D50A for ; Wed, 11 Oct 2017 10:54:57 -0700 (PDT) Received: by mail-wm0-x229.google.com with SMTP id m72so6987568wmc.1 for ; Wed, 11 Oct 2017 10:58:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=XBh1KLOAAoAAH9Htyeh5XbqBCjMCoT353I2gM6hjzvc=; b=iX1zOmgtImJkhdeXb/IPUh59uUB74qd8mOw7AcJlrN5qwcJrk0SmY+n1o0/nz5k0Bz D580s9Oes7VSvzoTA1cLiUr1WBH+Xb8uUB/JYcpObmnEIlI9jqJzirJbTrzGqdglLPOL 5oJmhkcxSNQ2ulRGGDxN9PxVEppWwvvpPYOls= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=XBh1KLOAAoAAH9Htyeh5XbqBCjMCoT353I2gM6hjzvc=; b=DWwTFmg8RdOppTrokCPiNSJhVSB4T4I8LdIdZSt1Ozo8NHLIp+XgtSjr8vJJ8UiCW3 9yI1BRrRvKeimm4SGVsjEGW9BotNtwist4UUNgsLjcQsuKvzQloq3TfvbaGbZaUPtOW6 LCLmEotFywQ8oQRtbL2B0L8RBN48IHLgGrqQEqk/+jebh6I3ziPmDc/sHUPHK5Nqh3KL 33YhDfBu0HXt+HWdCjM7m11zfR53HLDgPeKmcPC4e7y79xGB0SXEZ3kLxq4KCVNHDaG8 cIB2VnnUPGyZQL857FmEohpEFxUcZXGPXuXrujrLceVqwjils9sR3zQYIIPbNy4cExER HlJA== X-Gm-Message-State: AMCzsaWIacHoMnmc+nCOUZm8exBOZXwVwGtfDqMeDjxPE8PgZpe2LUta u4TWOYTJrMDcc4Aq/V8XPnPQJQ== X-Google-Smtp-Source: AOwi7QAj/+c4PjWYanwFilJFBYFJV0UABFcCusWtjw5333EDORjuR2OgjhEt3tkGuw3+9aUz8GkgMg== X-Received: by 10.28.24.7 with SMTP id 7mr387356wmy.78.1507744705655; Wed, 11 Oct 2017 10:58:25 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id t8sm9006111wra.52.2017.10.11.10.58.24 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 11 Oct 2017 10:58:24 -0700 (PDT) Date: Wed, 11 Oct 2017 18:58:23 +0100 From: Leif Lindholm To: Marcin Wojtas Cc: edk2-devel@lists.01.org, ard.biesheuvel@linaro.org, nadavh@marvell.com, neta@marvell.com, kostap@marvell.com, jinghua@marvell.com, jsd@semihalf.com Message-ID: <20171011175823.n7gelbueh55ytlbe@bivouac.eciton.net> References: <1507736449-6073-1-git-send-email-mw@semihalf.com> <1507736449-6073-9-git-send-email-mw@semihalf.com> MIME-Version: 1.0 In-Reply-To: <1507736449-6073-9-git-send-email-mw@semihalf.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [platforms: PATCH 8/8] Marvell/Armada: Add 32-bit ARM support X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Oct 2017 17:54:57 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Oct 11, 2017 at 05:40:49PM +0200, Marcin Wojtas wrote: > From: Ard Biesheuvel > > Update the included components and library classes to make this platform > build for 32-bit ARM. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel > Signed-off-by: Marcin Wojtas Very neat! Reviewed-by: Leif Lindholm > --- > Platform/Marvell/Armada/Armada.dsc.inc | 3 +-- > Platform/Marvell/Armada/Armada70x0.dsc | 4 ++-- > Platform/Marvell/Armada/Armada70x0.fdf | 2 +- > 3 files changed, 4 insertions(+), 5 deletions(-) > > diff --git a/Platform/Marvell/Armada/Armada.dsc.inc b/Platform/Marvell/Armada/Armada.dsc.inc > index b0a8240..b9fc384 100644 > --- a/Platform/Marvell/Armada/Armada.dsc.inc > +++ b/Platform/Marvell/Armada/Armada.dsc.inc > @@ -132,7 +132,6 @@ > CustomizedDisplayLib|MdeModulePkg/Library/CustomizedDisplayLib/CustomizedDisplayLib.inf > FdtLib|EmbeddedPkg/Library/FdtLib/FdtLib.inf > > -[LibraryClasses.AARCH64] > ArmLib|ArmPkg/Library/ArmLib/ArmBaseLib.inf > ArmMmuLib|ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf > ArmGenericTimerCounterLib|ArmPkg/Library/ArmGenericTimerPhyCounterLib/ArmGenericTimerPhyCounterLib.inf > @@ -362,7 +361,7 @@ > # ARM Pcds > gArmTokenSpaceGuid.PcdSystemMemoryBase|0 > gArmTokenSpaceGuid.PcdSystemMemorySize|0x40000000 > - gArmTokenSpaceGuid.PcdArmScr|0x531 > + gEmbeddedTokenSpaceGuid.PcdPrePiCpuMemorySize|36 > > # Secure region reservation > gMarvellTokenSpaceGuid.PcdSecureRegionBase|0x4000000 > diff --git a/Platform/Marvell/Armada/Armada70x0.dsc b/Platform/Marvell/Armada/Armada70x0.dsc > index 946c93e..0396e8e 100644 > --- a/Platform/Marvell/Armada/Armada70x0.dsc > +++ b/Platform/Marvell/Armada/Armada70x0.dsc > @@ -39,8 +39,8 @@ > PLATFORM_GUID = f837e231-cfc7-4f56-9a0f-5b218d746ae3 > PLATFORM_VERSION = 0.1 > DSC_SPECIFICATION = 0x00010005 > - OUTPUT_DIRECTORY = Build/$(PLATFORM_NAME) > - SUPPORTED_ARCHITECTURES = AARCH64 > + OUTPUT_DIRECTORY = Build/$(PLATFORM_NAME)-$(ARCH) > + SUPPORTED_ARCHITECTURES = AARCH64|ARM > BUILD_TARGETS = DEBUG|RELEASE > SKUID_IDENTIFIER = DEFAULT > FLASH_DEFINITION = Platform/Marvell/Armada/Armada70x0.fdf > diff --git a/Platform/Marvell/Armada/Armada70x0.fdf b/Platform/Marvell/Armada/Armada70x0.fdf > index a94a9ff..ec2c368 100644 > --- a/Platform/Marvell/Armada/Armada70x0.fdf > +++ b/Platform/Marvell/Armada/Armada70x0.fdf > @@ -237,7 +237,7 @@ READ_LOCK_STATUS = TRUE > # > ############################################################################ > > -[Rule.AARCH64.SEC] > +[Rule.Common.SEC] > FILE SEC = $(NAMED_GUID) RELOCS_STRIPPED FIXED { > TE TE Align = Auto $(INF_OUTPUT)/$(MODULE_NAME).efi > } > -- > 2.7.4 >