From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::233; helo=mail-wm0-x233.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x233.google.com (mail-wm0-x233.google.com [IPv6:2a00:1450:400c:c09::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id F25FE21F38824 for ; Thu, 12 Oct 2017 12:04:14 -0700 (PDT) Received: by mail-wm0-x233.google.com with SMTP id i124so15927481wmf.3 for ; Thu, 12 Oct 2017 12:07:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=/58A59d/8fYdbe63X7BBtVwo+sNdncu6m3hKMXrZng0=; b=bhXG9f2bjvzWnwTsaTw2SiNWxR9A9wR6rPm2nJe+ORFUkUAIELNk5tyxL5YCiy9My8 YE27xAAtPzH9G3PucSuVOUQk52VehMz4ApqKH7BaVzAuLpqdvkJmvC5DgJAJGC7y9vpA 6BiVJosJVhxlDwXhBlP/iB5Q3DNIOEhzEczK0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=/58A59d/8fYdbe63X7BBtVwo+sNdncu6m3hKMXrZng0=; b=VLA0mCPPg0B6ZRZeZeKOPBxfS6zbBcpkEFX6cXQ2FhjwQ74eCIyty8H5eXm4AMyAbq lXK3a6mu0NHv4EXhkJ9xl4iywnTfcJ2hC+6sfJexXMdV/oJeKWenPD+1+Vy92JIrwxew 9h6v6zSYp7+nTt4KakvezvA8uBL9mjRkUJFRLzfYnP9fbCfMKLYTVRkuuN1dKpcBVioK 6hbZ8GVKjJ1nDVN8l777aoN3BxGOemPLGLqXT0/9kFeMuisv8nH3ZY80V64yl/juop2Q q5V+dEHycBSUGGtXVL1zMdcSjFOn+ti5IRf744WnqxxQorNzP/x/cOKgEC1yny91SW+2 dEXA== X-Gm-Message-State: AMCzsaWp5DdSsfEXRnTG4vKM+KoaW+4qIBD7d3MTtWZLs8AHGvqsCJpH zLepwwaFreBxZpa6jXZV9zZ/Fg== X-Google-Smtp-Source: AOwi7QCZjio140mt4UEFG/YSkOJw9jH92gHpqkl6slMRmiEawyqSUrbNUmdGidBe9w/zC/XlWF4ptw== X-Received: by 10.28.196.79 with SMTP id u76mr2743124wmf.95.1507835264306; Thu, 12 Oct 2017 12:07:44 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id u4sm8643062wre.1.2017.10.12.12.07.43 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 12 Oct 2017 12:07:43 -0700 (PDT) Date: Thu, 12 Oct 2017 20:07:41 +0100 From: Leif Lindholm To: evan.lloyd@arm.com Cc: edk2-devel@lists.01.org Message-ID: <20171012190741.ytycqap3qfcgz5rr@bivouac.eciton.net> References: <20170926201529.11644-1-evan.lloyd@arm.com> <20170926201529.11644-4-evan.lloyd@arm.com> MIME-Version: 1.0 In-Reply-To: <20170926201529.11644-4-evan.lloyd@arm.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH 03/19] ArmPlatformPkg: PL111 and HDLCD: add const qualifier X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Oct 2017 19:04:15 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Sep 26, 2017 at 09:15:13PM +0100, evan.lloyd@arm.com wrote: > From: Girish Pathak > > This change adds some STATIC and CONST qualifiers (mainly to arguments > of functions) in PL111 and HdLcd modules. > > It doesn't add or modify any functionality. If you delete the line above: Reviewed-by: Leif Lindholm (These changes are highly likely to affect code generation, so I still consider it a functional change - if not an algorithmic one.) / Leif > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Girish Pathak > Signed-off-by: Evan Lloyd > --- > ArmPlatformPkg/ArmVExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpress.c | 34 ++++++++++---------- > ArmPlatformPkg/ArmVExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmVExpress.c | 34 ++++++++++---------- > ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/HdLcd.c | 4 +-- > ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/PL111Lcd.c | 4 +-- > 4 files changed, 38 insertions(+), 38 deletions(-) > > diff --git a/ArmPlatformPkg/ArmVExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpress.c b/ArmPlatformPkg/ArmVExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpress.c > index cfe3259d3c737de240350e8c3eab867b80c40948..b9859a56988f7e5be0adbaa49048a683fe586bfe 100644 > --- a/ArmPlatformPkg/ArmVExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpress.c > +++ b/ArmPlatformPkg/ArmVExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpress.c > @@ -46,7 +46,7 @@ typedef struct { > > /** The display modes supported by the platform. > **/ > -LCD_RESOLUTION mResolutions[] = { > +STATIC CONST LCD_RESOLUTION mResolutions[] = { > { // Mode 0 : VGA : 640 x 480 x 24 bpp > VGA, VGA_H_RES_PIXELS, VGA_V_RES_PIXELS, LCD_BITS_PER_PIXEL_24, > VGA_OSC_FREQUENCY, > @@ -144,8 +144,8 @@ LcdPlatformInitializeDisplay ( > **/ > EFI_STATUS > LcdPlatformGetVram ( > - OUT EFI_PHYSICAL_ADDRESS* VramBaseAddress, > - OUT UINTN* VramSize > + OUT EFI_PHYSICAL_ADDRESS * CONST VramBaseAddress, > + OUT UINTN * CONST VramSize > ) > { > EFI_STATUS Status; > @@ -209,7 +209,7 @@ LcdPlatformGetMaxMode(VOID) > **/ > EFI_STATUS > LcdPlatformSetMode ( > - IN UINT32 ModeNumber > + IN CONST UINT32 ModeNumber > ) > { > EFI_STATUS Status; > @@ -267,8 +267,8 @@ LcdPlatformSetMode ( > **/ > EFI_STATUS > LcdPlatformQueryMode ( > - IN UINT32 ModeNumber, > - OUT EFI_GRAPHICS_OUTPUT_MODE_INFORMATION *Info > + IN CONST UINT32 ModeNumber, > + OUT EFI_GRAPHICS_OUTPUT_MODE_INFORMATION * CONST Info > ) > { > if (ModeNumber >= LcdPlatformGetMaxMode ()) { > @@ -322,15 +322,15 @@ LcdPlatformQueryMode ( > **/ > EFI_STATUS > LcdPlatformGetTimings ( > - IN UINT32 ModeNumber, > - OUT UINT32* HRes, > - OUT UINT32* HSync, > - OUT UINT32* HBackPorch, > - OUT UINT32* HFrontPorch, > - OUT UINT32* VRes, > - OUT UINT32* VSync, > - OUT UINT32* VBackPorch, > - OUT UINT32* VFrontPorch > + IN CONST UINT32 ModeNumber, > + OUT UINT32 * CONST HRes, > + OUT UINT32 * CONST HSync, > + OUT UINT32 * CONST HBackPorch, > + OUT UINT32 * CONST HFrontPorch, > + OUT UINT32 * CONST VRes, > + OUT UINT32 * CONST VSync, > + OUT UINT32 * CONST VBackPorch, > + OUT UINT32 * CONST VFrontPorch > ) > { > if (ModeNumber >= LcdPlatformGetMaxMode ()) { > @@ -359,8 +359,8 @@ LcdPlatformGetTimings ( > **/ > EFI_STATUS > LcdPlatformGetBpp ( > - IN UINT32 ModeNumber, > - OUT LCD_BPP * Bpp > + IN CONST UINT32 ModeNumber, > + OUT LCD_BPP * CONST Bpp > ) > { > if (ModeNumber >= LcdPlatformGetMaxMode ()) { > diff --git a/ArmPlatformPkg/ArmVExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmVExpress.c b/ArmPlatformPkg/ArmVExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmVExpress.c > index 84880e5fd1dfe6f824b27e53926f9bb32ff6cdf7..6ae13f06d8b396ea1c67f0bcd735a9d70f476400 100644 > --- a/ArmPlatformPkg/ArmVExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmVExpress.c > +++ b/ArmPlatformPkg/ArmVExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmVExpress.c > @@ -43,7 +43,7 @@ typedef struct { > > /** The display modes supported by the platform. > **/ > -LCD_RESOLUTION mResolutions[] = { > +STATIC CONST LCD_RESOLUTION mResolutions[] = { > { // Mode 0 : VGA : 640 x 480 x 24 bpp > VGA, VGA_H_RES_PIXELS, VGA_V_RES_PIXELS, LCD_BITS_PER_PIXEL_24, > VGA_OSC_FREQUENCY, > @@ -195,8 +195,8 @@ LcdPlatformInitializeDisplay ( > **/ > EFI_STATUS > LcdPlatformGetVram ( > - OUT EFI_PHYSICAL_ADDRESS* VramBaseAddress, > - OUT UINTN* VramSize > + OUT EFI_PHYSICAL_ADDRESS * CONST VramBaseAddress, > + OUT UINTN * CONST VramSize > ) > { > EFI_STATUS Status; > @@ -283,7 +283,7 @@ LcdPlatformGetMaxMode(VOID) > **/ > EFI_STATUS > LcdPlatformSetMode ( > - IN UINT32 ModeNumber > + IN CONST UINT32 ModeNumber > ) > { > EFI_STATUS Status; > @@ -363,8 +363,8 @@ LcdPlatformSetMode ( > **/ > EFI_STATUS > LcdPlatformQueryMode ( > - IN UINT32 ModeNumber, > - OUT EFI_GRAPHICS_OUTPUT_MODE_INFORMATION *Info > + IN CONST UINT32 ModeNumber, > + OUT EFI_GRAPHICS_OUTPUT_MODE_INFORMATION * CONST Info > ) > { > if (ModeNumber >= LcdPlatformGetMaxMode ()) { > @@ -418,15 +418,15 @@ LcdPlatformQueryMode ( > **/ > EFI_STATUS > LcdPlatformGetTimings ( > - IN UINT32 ModeNumber, > - OUT UINT32* HRes, > - OUT UINT32* HSync, > - OUT UINT32* HBackPorch, > - OUT UINT32* HFrontPorch, > - OUT UINT32* VRes, > - OUT UINT32* VSync, > - OUT UINT32* VBackPorch, > - OUT UINT32* VFrontPorch > + IN CONST UINT32 ModeNumber, > + OUT UINT32 * CONST HRes, > + OUT UINT32 * CONST HSync, > + OUT UINT32 * CONST HBackPorch, > + OUT UINT32 * CONST HFrontPorch, > + OUT UINT32 * CONST VRes, > + OUT UINT32 * CONST VSync, > + OUT UINT32 * CONST VBackPorch, > + OUT UINT32 * CONST VFrontPorch > ) > { > if (ModeNumber >= LcdPlatformGetMaxMode ()) { > @@ -455,8 +455,8 @@ LcdPlatformGetTimings ( > **/ > EFI_STATUS > LcdPlatformGetBpp ( > - IN UINT32 ModeNumber, > - OUT LCD_BPP * Bpp > + IN CONST UINT32 ModeNumber, > + OUT LCD_BPP * CONST Bpp > ) > { > if (ModeNumber >= LcdPlatformGetMaxMode ()) { > diff --git a/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/HdLcd.c b/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/HdLcd.c > index 744dd3d556b5071defc6bcad5a9a30881bcb4b6f..5f950579720fb69e0a481f697a5cc4038158b409 100644 > --- a/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/HdLcd.c > +++ b/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/HdLcd.c > @@ -37,7 +37,7 @@ > **/ > EFI_STATUS > LcdInitialize ( > - IN EFI_PHYSICAL_ADDRESS VramBaseAddress > + IN CONST EFI_PHYSICAL_ADDRESS VramBaseAddress > ) > { > // Disable the controller > @@ -81,7 +81,7 @@ LcdInitialize ( > **/ > EFI_STATUS > LcdSetMode ( > - IN UINT32 ModeNumber > + IN CONST UINT32 ModeNumber > ) > { > EFI_STATUS Status; > diff --git a/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/PL111Lcd.c b/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/PL111Lcd.c > index f8a3c1f8266c0a11f111c3747688defc0d49877c..386e6140a69b045f77ee7fa60c4587d8bf4e7d54 100644 > --- a/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/PL111Lcd.c > +++ b/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/PL111Lcd.c > @@ -62,7 +62,7 @@ LcdIdentify ( > **/ > EFI_STATUS > LcdInitialize ( > - IN EFI_PHYSICAL_ADDRESS VramBaseAddress > + IN CONST EFI_PHYSICAL_ADDRESS VramBaseAddress > ) > { > // Define start of the VRAM. This never changes for any graphics mode > @@ -83,7 +83,7 @@ LcdInitialize ( > **/ > EFI_STATUS > LcdSetMode ( > - IN UINT32 ModeNumber > + IN CONST UINT32 ModeNumber > ) > { > EFI_STATUS Status; > -- > Guid("CE165669-3EF3-493F-B85D-6190EE5B9759") >