Re: [PATCH 05/19] ArmPlatformPkg: PL111LcdArmVExpressLib: Minor code cleanup

[Leif Lindholm <leif.lindholm@linaro.org>]

On Tue, Sep 26, 2017 at 09:15:15PM +0100, evan.lloyd@arm.com wrote:
> From: Girish Pathak <girish.pathak@arm.com>
> 
> This minor change removes some unecessary initializations and variables
> in PL111LcdArmVExpress.c
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Girish Pathak <girish.pathak@arm.com>
> Signed-off-by: Evan Lloyd <evan.lloyd@arm.com>

Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

> ---
>  ArmPlatformPkg/ArmVExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmVExpress.c | 11 +++--------
>  1 file changed, 3 insertions(+), 8 deletions(-)
> 
> diff --git a/ArmPlatformPkg/ArmVExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmVExpress.c b/ArmPlatformPkg/ArmVExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmVExpress.c
> index 5a4abd4c6f9e84d3d690af7233c1cebfe1ad339b..b25a1ba93dbfd8f6450dbdf97194c15c30defa20 100644
> --- a/ArmPlatformPkg/ArmVExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmVExpress.c
> +++ b/ArmPlatformPkg/ArmVExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmVExpress.c
> @@ -202,8 +202,6 @@ LcdPlatformGetVram (
>  {
>    EFI_STATUS              Status;
>  
> -  Status = EFI_SUCCESS;
> -
>    // Check VramBaseAddress and VramSize are not NULL.
>    if (VramBaseAddress == NULL || VramSize == NULL) {
>      ASSERT (VramBaseAddress != NULL);
> @@ -217,6 +215,7 @@ LcdPlatformGetVram (
>    case ARM_VE_MOTHERBOARD_SITE:
>      *VramBaseAddress = (EFI_PHYSICAL_ADDRESS)PL111_CLCD_VRAM_MOTHERBOARD_BASE;
>      *VramSize = LCD_VRAM_SIZE;
> +    Status = EFI_SUCCESS;
>      break;
>  
>    case ARM_VE_DAUGHTERBOARD_1_SITE:
> @@ -245,7 +244,6 @@ LcdPlatformGetVram (
>      if (EFI_ERROR (Status)) {
>        ASSERT_EFI_ERROR (Status);
>        gBS->FreePages (*VramBaseAddress, EFI_SIZE_TO_PAGES (*VramSize));
> -      return Status;
>      }
>      break;
>  
> @@ -296,7 +294,6 @@ LcdPlatformSetMode (
>    )
>  {
>    EFI_STATUS            Status;
> -  UINT32                LcdSite;
>    UINT32                OscillatorId;
>    SYS_CONFIG_FUNCTION   Function;
>    UINT32                SysId;
> @@ -306,9 +303,7 @@ LcdPlatformSetMode (
>      return EFI_INVALID_PARAMETER;
>    }
>  
> -  LcdSite = PL111_CLCD_SITE;
> -
> -  switch (LcdSite) {
> +  switch (PL111_CLCD_SITE) {
>    case ARM_VE_MOTHERBOARD_SITE:
>      Function = SYS_CFG_OSC;
>      OscillatorId = PL111_CLCD_MOTHERBOARD_VIDEO_MODE_OSC_ID;
> @@ -353,7 +348,7 @@ LcdPlatformSetMode (
>    }
>  
>    // Set the multiplexer
> -  Status = ArmPlatformSysConfigSet (SYS_CFG_MUXFPGA, LcdSite);
> +  Status = ArmPlatformSysConfigSet (SYS_CFG_MUXFPGA, PL111_CLCD_SITE);
>    if (EFI_ERROR (Status)) {
>      ASSERT_EFI_ERROR (Status);
>      return Status;
> -- 
> Guid("CE165669-3EF3-493F-B85D-6190EE5B9759")
>