From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::231; helo=mail-wm0-x231.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x231.google.com (mail-wm0-x231.google.com [IPv6:2a00:1450:400c:c09::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5E63221F3884B for ; Thu, 12 Oct 2017 12:30:29 -0700 (PDT) Received: by mail-wm0-x231.google.com with SMTP id m72so15927257wmc.1 for ; Thu, 12 Oct 2017 12:34:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=OZjX9IgKtFYXo2EOp4wgQYFeWL19j5HORZpBfmHl1lU=; b=U8kAMZ1RpXeHdUTSqLXHsi/EOL9qMS0oX5s7UtXzS7tASVYb3WE6TTH3h73uno7NT3 Jh0knXABe+UG6lBFZBazE19GXfro5nzid6QrF4uKy5RL8xxxBUQVVxT1Sii97mjMx6rV exlqO7CT6axZTb3Q5z141CVmDq/CUaclNzyiA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=OZjX9IgKtFYXo2EOp4wgQYFeWL19j5HORZpBfmHl1lU=; b=MDO9PzxFR8Zi0Jz3csLPkukHJrRQqVwVL/MTvC8gPfba0myj2c2cTJvz8LXxVQ8njV btdWmxHEPBhaAblpdpHis4hbWtonOvcDdh0HkkruFcQKJC3EXNJKlfKp2FVkB+DJc1R7 Wwp98qPshOgc8GmYRIhHH/skJ6zh5BxW386lIboLJa1GUxYH6IA0rfO2gD4FfnDqPtZK bb8fK21pmqoToxi/1B9PuU1IlEOeRpt9G3+aneg2ur3Nz30uxbSWyvd0nXno09/PzUC1 dNXayCtF91UJ7jDMVXVqBHO4zjzkL5pp2GnoHxjD3lkDRUrIupg0sSnvjCq4BL90OmOt hycA== X-Gm-Message-State: AMCzsaUbQdrUn3tkz+QsGpsnO2+HuCPoYBXzG/y+QCVvAxJvK4HS0f2+ QsRUV3LVIMIeuk6E4iBEKi+cxHzLmI8= X-Google-Smtp-Source: AOwi7QAGLxP4cHNYhajtDmsGaz9lC8Ij5mBInE9VZB0T4pU2Zd24lLyY0uCSYtbp0EgeFWSLNepX4Q== X-Received: by 10.223.161.211 with SMTP id v19mr2962947wrv.211.1507836838860; Thu, 12 Oct 2017 12:33:58 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id w82sm1285676wme.5.2017.10.12.12.33.57 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 12 Oct 2017 12:33:57 -0700 (PDT) Date: Thu, 12 Oct 2017 20:33:56 +0100 From: Leif Lindholm To: evan.lloyd@arm.com Cc: edk2-devel@lists.01.org Message-ID: <20171012193356.acwippocfyomwad6@bivouac.eciton.net> References: <20170926201529.11644-1-evan.lloyd@arm.com> <20170926201529.11644-6-evan.lloyd@arm.com> MIME-Version: 1.0 In-Reply-To: <20170926201529.11644-6-evan.lloyd@arm.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH 05/19] ArmPlatformPkg: PL111LcdArmVExpressLib: Minor code cleanup X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Oct 2017 19:30:29 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Sep 26, 2017 at 09:15:15PM +0100, evan.lloyd@arm.com wrote: > From: Girish Pathak > > This minor change removes some unecessary initializations and variables > in PL111LcdArmVExpress.c > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Girish Pathak > Signed-off-by: Evan Lloyd Reviewed-by: Leif Lindholm > --- > ArmPlatformPkg/ArmVExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmVExpress.c | 11 +++-------- > 1 file changed, 3 insertions(+), 8 deletions(-) > > diff --git a/ArmPlatformPkg/ArmVExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmVExpress.c b/ArmPlatformPkg/ArmVExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmVExpress.c > index 5a4abd4c6f9e84d3d690af7233c1cebfe1ad339b..b25a1ba93dbfd8f6450dbdf97194c15c30defa20 100644 > --- a/ArmPlatformPkg/ArmVExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmVExpress.c > +++ b/ArmPlatformPkg/ArmVExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmVExpress.c > @@ -202,8 +202,6 @@ LcdPlatformGetVram ( > { > EFI_STATUS Status; > > - Status = EFI_SUCCESS; > - > // Check VramBaseAddress and VramSize are not NULL. > if (VramBaseAddress == NULL || VramSize == NULL) { > ASSERT (VramBaseAddress != NULL); > @@ -217,6 +215,7 @@ LcdPlatformGetVram ( > case ARM_VE_MOTHERBOARD_SITE: > *VramBaseAddress = (EFI_PHYSICAL_ADDRESS)PL111_CLCD_VRAM_MOTHERBOARD_BASE; > *VramSize = LCD_VRAM_SIZE; > + Status = EFI_SUCCESS; > break; > > case ARM_VE_DAUGHTERBOARD_1_SITE: > @@ -245,7 +244,6 @@ LcdPlatformGetVram ( > if (EFI_ERROR (Status)) { > ASSERT_EFI_ERROR (Status); > gBS->FreePages (*VramBaseAddress, EFI_SIZE_TO_PAGES (*VramSize)); > - return Status; > } > break; > > @@ -296,7 +294,6 @@ LcdPlatformSetMode ( > ) > { > EFI_STATUS Status; > - UINT32 LcdSite; > UINT32 OscillatorId; > SYS_CONFIG_FUNCTION Function; > UINT32 SysId; > @@ -306,9 +303,7 @@ LcdPlatformSetMode ( > return EFI_INVALID_PARAMETER; > } > > - LcdSite = PL111_CLCD_SITE; > - > - switch (LcdSite) { > + switch (PL111_CLCD_SITE) { > case ARM_VE_MOTHERBOARD_SITE: > Function = SYS_CFG_OSC; > OscillatorId = PL111_CLCD_MOTHERBOARD_VIDEO_MODE_OSC_ID; > @@ -353,7 +348,7 @@ LcdPlatformSetMode ( > } > > // Set the multiplexer > - Status = ArmPlatformSysConfigSet (SYS_CFG_MUXFPGA, LcdSite); > + Status = ArmPlatformSysConfigSet (SYS_CFG_MUXFPGA, PL111_CLCD_SITE); > if (EFI_ERROR (Status)) { > ASSERT_EFI_ERROR (Status); > return Status; > -- > Guid("CE165669-3EF3-493F-B85D-6190EE5B9759") >