From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::234; helo=mail-wm0-x234.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x234.google.com (mail-wm0-x234.google.com [IPv6:2a00:1450:400c:c09::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D880621F3884B for ; Thu, 12 Oct 2017 12:31:17 -0700 (PDT) Received: by mail-wm0-x234.google.com with SMTP id 196so25202983wma.1 for ; Thu, 12 Oct 2017 12:34:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=R8mzLIYA+G2JZBIhv+Z+SF07P+Ib3LCRBj3WVeUy/yU=; b=M+Pfypu4Ih0j4EZ0W4/L8XchnqJrG8u/HYPusQ3dEUMGag1wmDi3jLVs5NXjJBKcpc RMf9tWzZrNAS/D1D2c44SfcNd8f4/ELcTc0cosvWmCT+3aaz56HJiECa3sw396xwU6b8 sFqdZnW1OJhOsX3hqSkfCgekNoo6aIgpW1mEo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=R8mzLIYA+G2JZBIhv+Z+SF07P+Ib3LCRBj3WVeUy/yU=; b=K6KaNUcu7uZRwbX3BcSyD+y004FiJXjzxqigsiwIK6rb6qOI3Jwat7G6D6+GdHclOa /8Eyp1p697vn4tLK5jDTeHLiN9mpXtD9yX0zo5/JfMr2U4VymyulMz1V+gNHcrIbd22w 0rX9HRcxBIu+75YdDy3wp1AF9NE23ZiInRsV3HEko48TFjNBdM9QddgGTVg5g1AB6LAt sj1pswDP9QgGuQXF8ALcWgjtr+7Lenip0177mbzAM+IXbGHqegR5GcC5mRMqwvnbP3Bu OMvDtYAkW5oWKvqFRZU/k9bLolS0SzcO6ByKLHwKOG7mHqUQA+BB26r2w3CvA0lOEJVc QVDw== X-Gm-Message-State: AMCzsaWMlgRjF7R6Znme1qEy/7mjaQUAHt8X/j2wE0jkC7oAv/9/zcYK oJcrAM3QXe+fZhWVd2rLakNgE/CCK2s= X-Google-Smtp-Source: AOwi7QCxImWQAsjqU7r/RAVcbTrIR+poX3lCzt2GFUofIr3dP7u/bijfBAeitEngsCTsm33Ay4qW5Q== X-Received: by 10.28.109.220 with SMTP id b89mr2939666wmi.30.1507836887336; Thu, 12 Oct 2017 12:34:47 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id r1sm14976778wrr.56.2017.10.12.12.34.46 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 12 Oct 2017 12:34:46 -0700 (PDT) Date: Thu, 12 Oct 2017 20:34:44 +0100 From: Leif Lindholm To: evan.lloyd@arm.com Cc: edk2-devel@lists.01.org Message-ID: <20171012193444.6kykh6gm7ccusbcz@bivouac.eciton.net> References: <20170926201529.11644-1-evan.lloyd@arm.com> <20170926201529.11644-7-evan.lloyd@arm.com> MIME-Version: 1.0 In-Reply-To: <20170926201529.11644-7-evan.lloyd@arm.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH 06/19] ArmPlatformPkg: PL111Lcd: Replace magic number with macro X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Oct 2017 19:31:18 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Sep 26, 2017 at 09:15:16PM +0100, evan.lloyd@arm.com wrote: > From: Girish Pathak > > Minor code change, replaces magic number with macro in LCD disable. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Girish Pathak > Signed-off-by: Evan Lloyd Always appreciated. Reviewed-by: Leif Lindholm > --- > ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/PL111Lcd.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/PL111Lcd.c b/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/PL111Lcd.c > index f432c8d802614e8a0e4ddab3898f6e0dbf9a1572..12db9d910ed1d7874095a5f79fe588491811f75a 100644 > --- a/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/PL111Lcd.c > +++ b/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/PL111Lcd.c > @@ -122,8 +122,7 @@ LcdSetMode ( > } > > // Disable the CLCD_LcdEn bit > - LcdControl = MmioRead32 (PL111_REG_LCD_CONTROL); > - MmioWrite32 (PL111_REG_LCD_CONTROL, LcdControl & ~1); > + MmioAnd32 (PL111_REG_LCD_CONTROL, ~PL111_CTRL_LCD_EN); > > // Set Timings > MmioWrite32 ( > -- > Guid("CE165669-3EF3-493F-B85D-6190EE5B9759") >