From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::22e; helo=mail-wm0-x22e.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x22e.google.com (mail-wm0-x22e.google.com [IPv6:2a00:1450:400c:c09::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 59F2721F3884B for ; Thu, 12 Oct 2017 12:31:57 -0700 (PDT) Received: by mail-wm0-x22e.google.com with SMTP id t69so15939433wmt.2 for ; Thu, 12 Oct 2017 12:35:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=q3S2Ivjmif1F2yJfaCiVeCN0XmuqCrsJxHDmQV2NHPg=; b=aFAjrpf3UufY8iYhovGglPRf7NYYPxrI9c+NcQaynpaRiQfoeK0u7C/VgbZntHSgmR soWicNOBsSdie4NpPEBIKDKmovndusLdwSA5M8kjXwwAKHxiykeFutsS+TMLxw3fHFsu a55aso707JC8FeD71kDu7rs0rGATp0KkyY/nA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=q3S2Ivjmif1F2yJfaCiVeCN0XmuqCrsJxHDmQV2NHPg=; b=cFQkHJPxvu3epsJ+ZpiyIzD7cyitZfFzKkMjTfDLJdktubYzCXeKlHOQjw1pxxjVPD 3osQXP9HQc0B2xNcAg3Ba8V36J9m/fMl+2G5OGja8tk0Os1TScURyUyqM83ADkyJEoRS Z62HO22mgo6VAOB+MTH545yq7OOG0VKnNnORFxEJl+mgmn8l5jgj4R2p8XbEv/f41VzL 4rD433KZxIbdHnnvn1RG20YaXE7mivrq/2cNVmb4zOHVo9xFShaBb30t/qWo3Ec3jw50 FKy9fJ/xq1Zeuu5VWhNqmfpFWQL3H5jDtMlMheJsGgYFgAjGUpQxS10YVT6HDDRCt76v mltg== X-Gm-Message-State: AMCzsaWThlthNu/f2yV+bOVJfUzro2V2kKqAG6EH436xqFgUWAxsL5e7 lxelRnSMfrU/07Du6wV6qDLCYQ== X-Google-Smtp-Source: AOwi7QBHnkG8Lnl7DPNNMGE6fUA1jYuG5je8BoHLywS3XHF2sEqs2LHSxyz9/JnHztkQE+t7bYK47Q== X-Received: by 10.28.48.150 with SMTP id w144mr2439494wmw.23.1507836926794; Thu, 12 Oct 2017 12:35:26 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id 9sm1001605wml.24.2017.10.12.12.35.25 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 12 Oct 2017 12:35:25 -0700 (PDT) Date: Thu, 12 Oct 2017 20:35:24 +0100 From: Leif Lindholm To: evan.lloyd@arm.com Cc: edk2-devel@lists.01.org Message-ID: <20171012193524.l5q2qeqaonjjkkor@bivouac.eciton.net> References: <20170926201529.11644-1-evan.lloyd@arm.com> <20170926201529.11644-8-evan.lloyd@arm.com> MIME-Version: 1.0 In-Reply-To: <20170926201529.11644-8-evan.lloyd@arm.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH 07/19] ArmPlatformPkg: PL111LcdArmVExpressLib: Use FixedPcdGet32 X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Oct 2017 19:31:57 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Sep 26, 2017 at 09:15:17PM +0100, evan.lloyd@arm.com wrote: > From: Girish Pathak > > PcdPL111LcdVideoModeOscId and PcdPL111LcdMaxMode are declared as fixed > PCDs. However code uses PcdGet32 call to get these values. > This change replaces PcdGet32 with FixedPcdGet32. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Girish Pathak > Signed-off-by: Evan Lloyd Reviewed-by: Leif Lindholm > --- > ArmPlatformPkg/ArmVExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmVExpressLib.inf | 2 +- > ArmPlatformPkg/ArmVExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmVExpress.c | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/ArmPlatformPkg/ArmVExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmVExpressLib.inf b/ArmPlatformPkg/ArmVExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmVExpressLib.inf > index 3fde707c33dbcbd8adbbf18bbba718b823194abc..1a044baf4698aa6bfa5cd6038f01e84f7a633ea9 100644 > --- a/ArmPlatformPkg/ArmVExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmVExpressLib.inf > +++ b/ArmPlatformPkg/ArmVExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmVExpressLib.inf > @@ -39,6 +39,6 @@ [Protocols] > gEfiEdidDiscoveredProtocolGuid # Produced > gEfiEdidActiveProtocolGuid # Produced > > -[Pcd] > +[FixedPcd] > gArmVExpressTokenSpaceGuid.PcdPL111LcdMaxMode > gArmVExpressTokenSpaceGuid.PcdPL111LcdVideoModeOscId > diff --git a/ArmPlatformPkg/ArmVExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmVExpress.c b/ArmPlatformPkg/ArmVExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmVExpress.c > index b25a1ba93dbfd8f6450dbdf97194c15c30defa20..59006c4cfd771fdd7ca1dab91728d4dafe2fe831 100644 > --- a/ArmPlatformPkg/ArmVExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmVExpress.c > +++ b/ArmPlatformPkg/ArmVExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmVExpress.c > @@ -277,7 +277,7 @@ LcdPlatformGetMaxMode(VOID) > */ > > // Set the maximum mode allowed > - return (PcdGet32 (PcdPL111LcdMaxMode)); > + return (FixedPcdGet32 (PcdPL111LcdMaxMode)); > } > > /** Set the requested display mode. > @@ -310,7 +310,7 @@ LcdPlatformSetMode ( > break; > case ARM_VE_DAUGHTERBOARD_1_SITE: > Function = SYS_CFG_OSC_SITE1; > - OscillatorId = (UINT32)PcdGet32 (PcdPL111LcdVideoModeOscId); > + OscillatorId = FixedPcdGet32 (PcdPL111LcdVideoModeOscId); > break; > default: > return EFI_UNSUPPORTED; > -- > Guid("CE165669-3EF3-493F-B85D-6190EE5B9759") >