From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::230; helo=mail-wm0-x230.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x230.google.com (mail-wm0-x230.google.com [IPv6:2a00:1450:400c:c09::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 3647621F3884B for ; Thu, 12 Oct 2017 12:35:23 -0700 (PDT) Received: by mail-wm0-x230.google.com with SMTP id i124so16119253wmf.3 for ; Thu, 12 Oct 2017 12:38:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=kQvBOlZsffBleV4uXhDDPwIlmValHKIWRT6PzDu7dXg=; b=iOkFcmy35XgigzUBC81crIcEJJimACIfi359LnfgiDGcV0ijVHOfC4uIdgZ8kwbYkg hfja6q8q3IXNyOGA5n81nPBF5uEfciimcoW7/Y/ih56VW8euBizuc9colzTvd/+cdHt6 Zfn23KksUndBPNjBWqZS/JNVH5pms3W3V972U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=kQvBOlZsffBleV4uXhDDPwIlmValHKIWRT6PzDu7dXg=; b=mA3N/NgPsedOD79Yb9h/TAUwfigX0Nf8VRz4u6H+LteLMrPUjU6wfsSHDzHY8PoAmF upbMgzIQjfj+K74vUkFsS+0obcwCPRR6NFsJw+/Zmkn1n/mTnVenIm2WeGDZIPc4V2f5 fSfCmDRWQbOEQeFahHDpQ5eobGXcrj9ymB9FN8YI/RRRmivIRxZAPyGIvzXcw2GVayqz Ui4zspuO8T85ts5DQhMw9onqbjjOMpJxoZHZ3NiNEUtY+SeAAHrnqL14gIrYjStJ+AbZ iu50gu1ezmYtiYaYYj1sBhEOcZqyPD/lfHSKVooaB3TwkEsvnicKaLElJbKddtaPIJ+X aSKw== X-Gm-Message-State: AMCzsaV6G9kChtwEJmJSbCWOL7v3fxpCyhBuvtJpQFmTdBqavhiPcOU9 lr9sfdoitqzJqw3UzuLMxV5aNFHtJiA= X-Google-Smtp-Source: AOwi7QCmYCTiRxZ0mEvNZkK6aHXhs3j+Y4raUkxVI8aQQD///PnzW0l7MhrJoD/ff3D2v8hxavYs1w== X-Received: by 10.223.186.201 with SMTP id w9mr2960158wrg.230.1507837133521; Thu, 12 Oct 2017 12:38:53 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id w14sm882288wmf.13.2017.10.12.12.38.52 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 12 Oct 2017 12:38:52 -0700 (PDT) Date: Thu, 12 Oct 2017 20:38:51 +0100 From: Leif Lindholm To: evan.lloyd@arm.com Cc: edk2-devel@lists.01.org Message-ID: <20171012193851.abfvbderdbcx2woi@bivouac.eciton.net> References: <20170926201529.11644-1-evan.lloyd@arm.com> <20170926201529.11644-10-evan.lloyd@arm.com> MIME-Version: 1.0 In-Reply-To: <20170926201529.11644-10-evan.lloyd@arm.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH 09/19] ArmPlatformPkg: HdLcdArmVExpressLib: Use FixedPcdGet32 X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Oct 2017 19:35:24 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Sep 26, 2017 at 09:15:19PM +0100, evan.lloyd@arm.com wrote: > From: Girish Pathak > > PcdHdLcdVideoModeOscId is declared as a fixed PCD. However code > uses the PcdGet32 call to get this value. > This change replaces PcdGet32 with FixedPcdGet32. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Girish Pathak > Signed-off-by: Evan Lloyd For reference, I would have been happy for this one to be folded in with the other fix of the same variant. > --- > ArmPlatformPkg/ArmVExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpressLib.inf | 2 +- > ArmPlatformPkg/ArmVExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpress.c | 10 +++++----- > 2 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/ArmPlatformPkg/ArmVExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpressLib.inf b/ArmPlatformPkg/ArmVExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpressLib.inf > index 4733bb8e662d64eca0976af21b2abb7036b4424b..bba851c9bd6089cee748b45f40599b24c1293785 100644 > --- a/ArmPlatformPkg/ArmVExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpressLib.inf > +++ b/ArmPlatformPkg/ArmVExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpressLib.inf > @@ -39,6 +39,6 @@ [Protocols] > gEfiEdidDiscoveredProtocolGuid # Produced > gEfiEdidActiveProtocolGuid # Produced > > -[Pcd] > +[FixedPcd] > gArmVExpressTokenSpaceGuid.PcdPL111LcdMaxMode > gArmVExpressTokenSpaceGuid.PcdHdLcdVideoModeOscId > diff --git a/ArmPlatformPkg/ArmVExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpress.c b/ArmPlatformPkg/ArmVExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpress.c > index 58dd9f0c77e1bc9af559a71d0c7cce72d71c6da5..7b258f1fc9291ed2086da1e32dd5d0c7e4818dbd 100644 > --- a/ArmPlatformPkg/ArmVExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpress.c > +++ b/ArmPlatformPkg/ArmVExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpress.c > @@ -230,11 +230,11 @@ LcdPlatformSetMode ( > > // Set the video mode oscillator > do { > - Status = ArmPlatformSysConfigSetDevice ( > - SYS_CFG_OSC_SITE1, > - PcdGet32 (PcdHdLcdVideoModeOscId), > - mResolutions[ModeNumber].OscFreq > - ); > + Status = ArmPlatformSysConfigSetDevice ( > + SYS_CFG_OSC_SITE1, > + FixedPcdGet32 (PcdHdLcdVideoModeOscId), > + mResolutions[ModeNumber].OscFreq > + ); However, something seems to have gone wrong with indentation here. / Leif > } while (Status == EFI_TIMEOUT); > if (EFI_ERROR (Status)) { > ASSERT_EFI_ERROR (Status); > -- > Guid("CE165669-3EF3-493F-B85D-6190EE5B9759") > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel