From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::236; helo=mail-wm0-x236.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x236.google.com (mail-wm0-x236.google.com [IPv6:2a00:1450:400c:c09::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0858E21F3884B for ; Thu, 12 Oct 2017 12:37:14 -0700 (PDT) Received: by mail-wm0-x236.google.com with SMTP id b189so15846706wmd.4 for ; Thu, 12 Oct 2017 12:40:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=AQn4j7p3NefuoHMZLH7Ub/2fXL702IOi9QNDxG9i6N4=; b=LpkmJOHK6DUBxOIWnF5HnThIeaqhCPfN4bH1UzEFiZftMcPVj0w/dGXhC/UtemEPzV 8JsKc/4KqZpuUYUl1+IryN1thIM1aNVc6/6y1np2D75LakZtSoSwgyupu+MM0U7XSEax IWvcujJ1X/tDHq0+OOGaOK6lHV0/lf+NLSymk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=AQn4j7p3NefuoHMZLH7Ub/2fXL702IOi9QNDxG9i6N4=; b=bW/Ox+nyYZ53itgxvQar6x5TvV8ciHoQsg6onE8/fegVl0HhE8hfpxu0jrSWj/MhSs BBbMC2NxwESNmYjjYFKgDQ7ipDsxXfiQiGFAJtyVX/Gi1NCGwDrH/1JmwTKWW0D7+4qW 9GwFkuU723fM01MBIQrpynIRgp/ZCn7NEyzaFLNnZ/xWkCDNeJWOsRkMzDL+5pJaC45q 4eE2C8cjdcnsmNnIKeZN+4DzN2T8ZhIVWIVjha22cSzy0v8/uoOD29zZCPfORFq3A1D1 W7dazfQiImOp5rzmNIcJi6/LoSYtUu4Py7BDkOUvss/bqUiLrkV/Yahwr4ZiKf/LsNJA RGpA== X-Gm-Message-State: AMCzsaXITbys7BwhyMk7EkjsqjaNIdzbpRpoptA38w2682amOdnTE1MD VJYsx46GWCId0LDhFpzsdF8mJd2yFsE= X-Google-Smtp-Source: AOwi7QB4ORCXHxO3xZCV0+GWCQ45m77zmE8BeaffcT9K7TtJ93yFjvoU3B9pvmP4ilaZ4rgygtnYXw== X-Received: by 10.223.143.105 with SMTP id p96mr3201524wrb.266.1507837244517; Thu, 12 Oct 2017 12:40:44 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id r134sm757518wmf.3.2017.10.12.12.40.43 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 12 Oct 2017 12:40:43 -0700 (PDT) Date: Thu, 12 Oct 2017 20:40:42 +0100 From: Leif Lindholm To: evan.lloyd@arm.com Cc: edk2-devel@lists.01.org Message-ID: <20171012194042.j6oa4qkomunimpif@bivouac.eciton.net> References: <20170926201529.11644-1-evan.lloyd@arm.com> <20170926201529.11644-11-evan.lloyd@arm.com> MIME-Version: 1.0 In-Reply-To: <20170926201529.11644-11-evan.lloyd@arm.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH 10/19] ArmPlatformPkg: HdLcdArmVExpressLib: Remove status check EFI_TIMEOUT X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Oct 2017 19:37:15 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Sep 26, 2017 at 09:15:20PM +0100, evan.lloyd@arm.com wrote: > From: Girish Pathak > > None of the ArmPlatformSys* functions return EFI_TIMEOUT. Hence checking > this in the do {} while loop in LcdPlatformSetMode is wrong. Therefore > remove this comparision and as a result remove the do {} while loop. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Girish Pathak > Signed-off-by: Evan Lloyd > --- > ArmPlatformPkg/ArmVExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpress.c | 12 ++++-------- > 1 file changed, 4 insertions(+), 8 deletions(-) > > diff --git a/ArmPlatformPkg/ArmVExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpress.c b/ArmPlatformPkg/ArmVExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpress.c > index 7b258f1fc9291ed2086da1e32dd5d0c7e4818dbd..a6c4f414685db907a3fbc9a009969be8a09f7415 100644 > --- a/ArmPlatformPkg/ArmVExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpress.c > +++ b/ArmPlatformPkg/ArmVExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpress.c > @@ -229,25 +229,21 @@ LcdPlatformSetMode ( > } > > // Set the video mode oscillator > - do { > Status = ArmPlatformSysConfigSetDevice ( > SYS_CFG_OSC_SITE1, > FixedPcdGet32 (PcdHdLcdVideoModeOscId), > mResolutions[ModeNumber].OscFreq > ); > - } while (Status == EFI_TIMEOUT); And now I see the cause of the incorrect indentation in the previous patch. > if (EFI_ERROR (Status)) { > ASSERT_EFI_ERROR (Status); > return Status; > } > > // Set the DVI into the new mode > - do { > - Status = ArmPlatformSysConfigSet ( > - SYS_CFG_DVIMODE, > - mResolutions[ModeNumber].Mode > - ); > - } while (Status == EFI_TIMEOUT); > + Status = ArmPlatformSysConfigSet ( > + SYS_CFG_DVIMODE, > + mResolutions[ModeNumber].Mode > + ); Still, this is a 3-space indentation that should be a 2-space indentation. / Leif > if (EFI_ERROR (Status)) { > ASSERT_EFI_ERROR (Status); > return Status; > -- > Guid("CE165669-3EF3-493F-B85D-6190EE5B9759") >