From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::233; helo=mail-wm0-x233.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x233.google.com (mail-wm0-x233.google.com [IPv6:2a00:1450:400c:c09::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id DAA2B21F3882E for ; Fri, 13 Oct 2017 00:49:35 -0700 (PDT) Received: by mail-wm0-x233.google.com with SMTP id q124so19070676wmb.0 for ; Fri, 13 Oct 2017 00:53:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=qMKeeOcSGBpUHdnGnCwtNfEGJB3jpKRe+UOQuqVJ/ok=; b=NIB0tF7IB0rn84bdNwQGsWi7TMPlXBOdiia3ZYei0XB5N1jk4pVvjjv/ALhWk0mRhQ D03kRhP9Xk9+gdf0NWtgDMvwXlbbi/g3xte8JwCp6jSjADiMUcTBZREB+SqkcL4PiWeE SLXfSPKmhQLd+Dbkurj9LRVN51enljx7AbCGU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=qMKeeOcSGBpUHdnGnCwtNfEGJB3jpKRe+UOQuqVJ/ok=; b=fPNL96yUZsOuZ7XVDRUqfsX/YNal6NRU93DsRPP5O2XISBBCtfXhdUwqnfjUYgf5dQ QG6xhwKX41ZzSTlmK8UlRlTiTueshpCOd2ObeXs/brfnApazlJt1BkqFqgRYEAa38VIa UoFt0N9NxOMh6aE5TDc9iPRZrNiCz7eVw9TCNEmU9UMPeZCbk9DjS5b0bySpbd2Uqv+v mCpI+bqcXuJ5zKoxbAvGO1EzVAcHj/QPzQM7tJGKud/s1FpXhIqL0Vn8Y06E2f65rvTt 8Nx7QXqdMWrz763Ga3WyAk5A70c2PqY1+Pz6lJJ55+xpHgKpLooLvWEYIiyakjPkgOPI bR5Q== X-Gm-Message-State: AMCzsaX7OJi1IAcRwfbpQXFQhRqHNJO7Ko/82Qk7ZoOAm0G5jBPFT0RW pDHhk595/U50g8MSkRarJE24Gw== X-Google-Smtp-Source: AOwi7QAh300VWNbhHtpMhFhO9N1KUy97TSMjJS/Le6IajUfu/q1VA8ETFM5nIG9LDshNUeC+OgpdvA== X-Received: by 10.223.150.25 with SMTP id b25mr552903wra.147.1507881185629; Fri, 13 Oct 2017 00:53:05 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id x185sm377953wmx.35.2017.10.13.00.53.04 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 13 Oct 2017 00:53:04 -0700 (PDT) Date: Fri, 13 Oct 2017 08:53:03 +0100 From: Leif Lindholm To: evan.lloyd@arm.com Cc: edk2-devel@lists.01.org Message-ID: <20171013075303.crtv45upaupgscxx@bivouac.eciton.net> References: <20170926201529.11644-1-evan.lloyd@arm.com> <20170926201529.11644-14-evan.lloyd@arm.com> MIME-Version: 1.0 In-Reply-To: <20170926201529.11644-14-evan.lloyd@arm.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH 13/19] ArmPlatformPkg: HdLcd Remove redundant Bpp X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Oct 2017 07:49:36 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Sep 26, 2017 at 09:15:23PM +0100, evan.lloyd@arm.com wrote: > From: EvanLloyd > > Because of copy/paste effects, HdLcdArmVExpress.c contained a > table entry "LCD_BPP Bpp;" specifying the Bits per Pixel for each mode. > However, all modes are LCD_BITS_PER_PIXEL_24. > > This change removes the table entry and related use of the field. Since it looks to be modifying some of the same lines, I would prefer to see this patch before the previous one. Or am I misreading that? / Leif > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Girish Pathak > Signed-off-by: Evan Lloyd > --- > ArmPlatformPkg/ArmVExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpress.c | 42 ++++++-------------- > 1 file changed, 13 insertions(+), 29 deletions(-) > > diff --git a/ArmPlatformPkg/ArmVExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpress.c b/ArmPlatformPkg/ArmVExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpress.c > index dc2c5fb89923304c46d137ec8eaefc9418548d06..2401cdb30cb7252964ce1f363aa26d99933c09be 100644 > --- a/ArmPlatformPkg/ArmVExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpress.c > +++ b/ArmPlatformPkg/ArmVExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpress.c > @@ -30,7 +30,6 @@ > > typedef struct { > UINT32 Mode; > - LCD_BPP Bpp; > UINT32 OscFreq; > > // These are used by HDLCD > @@ -42,37 +41,37 @@ typedef struct { > **/ > STATIC CONST DISPLAY_MODE mDisplayModes[] = { > { // Mode 0 : VGA : 640 x 480 x 24 bpp > - VGA, LCD_BITS_PER_PIXEL_24, > + VGA, > VGA_OSC_FREQUENCY, > {VGA_H_RES_PIXELS, VGA_H_SYNC, VGA_H_BACK_PORCH, VGA_H_FRONT_PORCH}, > {VGA_V_RES_PIXELS, VGA_V_SYNC, VGA_V_BACK_PORCH, VGA_V_FRONT_PORCH} > }, > { // Mode 1 : SVGA : 800 x 600 x 24 bpp > - SVGA, LCD_BITS_PER_PIXEL_24, > + SVGA, > SVGA_OSC_FREQUENCY, > {SVGA_H_RES_PIXELS, SVGA_H_SYNC, SVGA_H_BACK_PORCH, SVGA_H_FRONT_PORCH}, > {SVGA_V_RES_PIXELS, SVGA_V_SYNC, SVGA_V_BACK_PORCH, SVGA_V_FRONT_PORCH} > }, > { // Mode 2 : XGA : 1024 x 768 x 24 bpp > - XGA, LCD_BITS_PER_PIXEL_24, > + XGA, > XGA_OSC_FREQUENCY, > {XGA_H_RES_PIXELS, XGA_H_SYNC, XGA_H_BACK_PORCH, XGA_H_FRONT_PORCH}, > {XGA_V_RES_PIXELS, XGA_V_SYNC, XGA_V_BACK_PORCH, XGA_V_FRONT_PORCH} > }, > { // Mode 3 : SXGA : 1280 x 1024 x 24 bpp > - SXGA, LCD_BITS_PER_PIXEL_24, > + SXGA, > (SXGA_OSC_FREQUENCY/2), > {SXGA_H_RES_PIXELS, SXGA_H_SYNC, SXGA_H_BACK_PORCH, SXGA_H_FRONT_PORCH}, > {SXGA_V_RES_PIXELS, SXGA_V_SYNC, SXGA_V_BACK_PORCH, SXGA_V_FRONT_PORCH} > }, > { // Mode 4 : UXGA : 1600 x 1200 x 24 bpp > - UXGA, LCD_BITS_PER_PIXEL_24, > + UXGA, > (UXGA_OSC_FREQUENCY/2), > {UXGA_H_RES_PIXELS, UXGA_H_SYNC, UXGA_H_BACK_PORCH, UXGA_H_FRONT_PORCH}, > {UXGA_V_RES_PIXELS, UXGA_V_SYNC, UXGA_V_BACK_PORCH, UXGA_V_FRONT_PORCH} > }, > { // Mode 5 : HD : 1920 x 1080 x 24 bpp > - HD, LCD_BITS_PER_PIXEL_24, > + HD, > (HD_OSC_FREQUENCY/2), > {HD_H_RES_PIXELS, HD_H_SYNC, HD_H_BACK_PORCH, HD_H_FRONT_PORCH}, > {HD_V_RES_PIXELS, HD_V_SYNC, HD_V_BACK_PORCH, HD_V_FRONT_PORCH} > @@ -283,27 +282,12 @@ LcdPlatformQueryMode ( > Info->VerticalResolution = mDisplayModes[ModeNumber].Vertical.Resolution; > Info->PixelsPerScanLine = mDisplayModes[ModeNumber].Horizontal.Resolution; > > - switch (mDisplayModes[ModeNumber].Bpp) { > - case LCD_BITS_PER_PIXEL_24: > - Info->PixelFormat = PixelRedGreenBlueReserved8BitPerColor; > - Info->PixelInformation.RedMask = LCD_24BPP_RED_MASK; > - Info->PixelInformation.GreenMask = LCD_24BPP_GREEN_MASK; > - Info->PixelInformation.BlueMask = LCD_24BPP_BLUE_MASK; > - Info->PixelInformation.ReservedMask = LCD_24BPP_RESERVED_MASK; > - break; > - > - case LCD_BITS_PER_PIXEL_16_555: > - case LCD_BITS_PER_PIXEL_16_565: > - case LCD_BITS_PER_PIXEL_12_444: > - case LCD_BITS_PER_PIXEL_8: > - case LCD_BITS_PER_PIXEL_4: > - case LCD_BITS_PER_PIXEL_2: > - case LCD_BITS_PER_PIXEL_1: > - default: > - // These are not supported > - ASSERT (FALSE); > - break; > - } > + /* Bits per Pixel is always LCD_BITS_PER_PIXEL_24 */ > + Info->PixelFormat = PixelRedGreenBlueReserved8BitPerColor; > + Info->PixelInformation.RedMask = LCD_24BPP_RED_MASK; > + Info->PixelInformation.GreenMask = LCD_24BPP_GREEN_MASK; > + Info->PixelInformation.BlueMask = LCD_24BPP_BLUE_MASK; > + Info->PixelInformation.ReservedMask = LCD_24BPP_RESERVED_MASK; > > return EFI_SUCCESS; > } > @@ -365,7 +349,7 @@ LcdPlatformGetBpp ( > return EFI_INVALID_PARAMETER; > } > > - *Bpp = mDisplayModes[ModeNumber].Bpp; > + *Bpp = LCD_BITS_PER_PIXEL_24; > > return EFI_SUCCESS; > } > -- > Guid("CE165669-3EF3-493F-B85D-6190EE5B9759") >