From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::229; helo=mail-wm0-x229.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x229.google.com (mail-wm0-x229.google.com [IPv6:2a00:1450:400c:c09::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id CA515202E60ED for ; Tue, 17 Oct 2017 06:56:53 -0700 (PDT) Received: by mail-wm0-x229.google.com with SMTP id 196so9118970wma.1 for ; Tue, 17 Oct 2017 07:00:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ZkSGdGszqyNs7qtfuXZ0vAnsvE8AH/hC2zh3HY4J+ZM=; b=czEJq+6xeB0HPn2z8h0GT5iJPTeeSDVUakUm+xf/C6E40uz63Dv1VWa9o4N2eyZBrl SnNRBCJ9O0rHRogZEfsu0oEJDPuVB1w6fzqlEtbniHbDxDsvIH7WaRS+fNmDfdqzgLJS UYFBRjolyTtWY5OIQ/bYHedyt/pv1V+8Fd2K0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ZkSGdGszqyNs7qtfuXZ0vAnsvE8AH/hC2zh3HY4J+ZM=; b=rK0Hj+BNesUnMyVFvw9pz0urkiMs4LI0QtUgI1cG7Bgtl631N4c21AbHGFlStgJ5fz pNzkH3EYgEbqWvX5XppGXb4ewd2zZ5NgmdXcMhM+VNz+G8rnfcsQ5wBdFSaLjtvJKSkn DdovLOXunQ8wPQEcbDcgeEpidrhx0R18LSdH1qgBCR24R8J/a5xArGd35Y5eya7wpXmI 67jTcVkFc7SHV/mv+scFSQyLXt+uMyVmrDl+SNrtBZNhLWFPSRVeua2OFCRYm5hLW/ys FVdv8XklPlYeEMlrw5ClNMH9fBAI16XPikxFn8lIl5pt1Da52TNagLgQYVrcZqpJMURN /ckw== X-Gm-Message-State: AMCzsaW7sI4r28NPq7t11mgAoT+thRrmTOdX9D2NnWQDy0jbXULuWnnU 3uyTsRxBc7OMc5OiQFGAMMg+6Q== X-Google-Smtp-Source: ABhQp+Qbg7FSWbkAVrwKzsyAcmnOzQJ3fOCQiXkZSM7ZcWqGbyTfUiyPP2u7fIVRQyKXS5sOx/PH4g== X-Received: by 10.28.214.212 with SMTP id n203mr3314869wmg.10.1508248828134; Tue, 17 Oct 2017 07:00:28 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id k141sm12324675wmg.15.2017.10.17.07.00.26 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 17 Oct 2017 07:00:26 -0700 (PDT) Date: Tue, 17 Oct 2017 15:00:24 +0100 From: Leif Lindholm To: Ard Biesheuvel , Alexei Fedorov Cc: edk2-devel@lists.01.org, sudeep.holla@arm.com Message-ID: <20171017140024.nnny4ik5ooquqfvv@bivouac.eciton.net> References: <20171017134205.3907-1-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: <20171017134205.3907-1-ard.biesheuvel@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms v2] Platform/ARM: use appropriate ReportStatusCodeLib resolution for RT drivers X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Oct 2017 13:56:54 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Thanks. Alexei, can you confirm that this addresses your concerns? / Leif On Tue, Oct 17, 2017 at 02:42:05PM +0100, Ard Biesheuvel wrote: > ResetSystemRuntimeDxe may be invoked by the OS at runtime, at which time > it will attempt to call into ReportStatusCodeLib. If we use the default > version for DXE drivers, this will access data structures that are no > longer there so switch to the special runtime version instead. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel > --- > Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > index 8bcb84869c84..1605eedbdd8c 100644 > --- a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > +++ b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > @@ -240,6 +240,7 @@ [LibraryClasses.common.DXE_RUNTIME_DRIVER] > MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf > CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf > ArmPlatformSysConfigLib|ArmPlatformPkg/ArmVExpressPkg/Library/ArmVExpressSysConfigRuntimeLib/ArmVExpressSysConfigRuntimeLib.inf > + ReportStatusCodeLib|MdeModulePkg/Library/RuntimeDxeReportStatusCodeLib/RuntimeDxeReportStatusCodeLib.inf > !if $(SECURE_BOOT_ENABLE) == TRUE > BaseCryptLib|CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf > !endif > -- > 2.11.0 >