From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::233; helo=mail-wm0-x233.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x233.google.com (mail-wm0-x233.google.com [IPv6:2a00:1450:400c:c09::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 4D96221F38854 for ; Tue, 17 Oct 2017 11:20:33 -0700 (PDT) Received: by mail-wm0-x233.google.com with SMTP id l68so5668089wmd.5 for ; Tue, 17 Oct 2017 11:24:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=6W99goMHPGA46urFlrGZ9KJKSAQ/8019pmmJj9RLk0E=; b=T4hcXzUlYQGxcduyIHcPVKr/QqihbiuBitgoszWt8/V/LCLV2K0uKO6Hq19EG+bmIU 05HZVujEhH2kF8ehh1Ii7gIsei5pRwOvTZ+j1LJBBLnJmMhFH7Hxh/q7wqkc9qly0qJc bjh6wABy13wB6afM/ufNIFLi9gB+uDWoZXFzQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=6W99goMHPGA46urFlrGZ9KJKSAQ/8019pmmJj9RLk0E=; b=dpOVnumkwfQ7xh4pYzGuOomUpNWmz3dwMsgog/xMUxKf47Ch4fWmSENs2rZwXyVflX 3tklFTc5guAptHIKmO8b2DBek1IKZk7kIqxhTFYr1p8Lwn9lHyPOYBORI6Dhz+R0Flqq 1z0zAgwkcrpLn6ckGfBwa2JKowuuZoZ+zvNPlvpJTMn6HFxHC0VHu/XsMinwCJLr9QXy qOjPvAf215dsS1WaAGS6LaCf0l1FMWKPMuTHPMji24wdCFH2s+YOEN9JRaQfrA3O5guA vmPzs9vqEDVNudZ9z6OXTg7AIfvuxFzYJp3ZtUtfuVNOO6yXEIV6ZCQmXV153XfVhc8k nC0Q== X-Gm-Message-State: AMCzsaU5tcRLcUDmTjN7O7Ezgww52Z3g1yGby4P+TU6hF1lPOPvXg3wZ 0yeIAl3/CoZoAuB5btGncCCFbA== X-Google-Smtp-Source: ABhQp+SHRcMR0YpLXKXfFhkaIrjYAGf/KDE3HeKn48D9HQtS/+B9/31eVdi7j6kq9jMvCmW7jMHH1g== X-Received: by 10.28.84.89 with SMTP id p25mr3958580wmi.112.1508264648330; Tue, 17 Oct 2017 11:24:08 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id f43sm10296842wra.53.2017.10.17.11.24.07 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 17 Oct 2017 11:24:07 -0700 (PDT) Date: Tue, 17 Oct 2017 19:24:05 +0100 From: Leif Lindholm To: Alexei Fedorov Cc: Ard Biesheuvel , "edk2-devel@lists.01.org" , Sudeep Holla Message-ID: <20171017182405.rafpya5je43rgaez@bivouac.eciton.net> References: <20171017134205.3907-1-ard.biesheuvel@linaro.org> <20171017140024.nnny4ik5ooquqfvv@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms v2] Platform/ARM: use appropriate ReportStatusCodeLib resolution for RT drivers X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Oct 2017 18:20:33 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Thanks! I'll take that as a Tested-by:. Reviewed-by: Leif Lindholm Pushed as 1727ed8024. / Leif On Tue, Oct 17, 2017 at 03:05:36PM +0000, Alexei Fedorov wrote: > Yes, system can be restarted properly with this patch. > > > Alexei. > > ________________________________ > From: Leif Lindholm > Sent: 17 October 2017 15:00:24 > To: Ard Biesheuvel; Alexei Fedorov > Cc: edk2-devel@lists.01.org; Sudeep Holla > Subject: Re: [PATCH edk2-platforms v2] Platform/ARM: use appropriate ReportStatusCodeLib resolution for RT drivers > > Thanks. > > Alexei, can you confirm that this addresses your concerns? > > / > Leif > > On Tue, Oct 17, 2017 at 02:42:05PM +0100, Ard Biesheuvel wrote: > > ResetSystemRuntimeDxe may be invoked by the OS at runtime, at which time > > it will attempt to call into ReportStatusCodeLib. If we use the default > > version for DXE drivers, this will access data structures that are no > > longer there so switch to the special runtime version instead. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Ard Biesheuvel > > --- > > Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > > index 8bcb84869c84..1605eedbdd8c 100644 > > --- a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > > +++ b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > > @@ -240,6 +240,7 @@ [LibraryClasses.common.DXE_RUNTIME_DRIVER] > > MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf > > CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf > > ArmPlatformSysConfigLib|ArmPlatformPkg/ArmVExpressPkg/Library/ArmVExpressSysConfigRuntimeLib/ArmVExpressSysConfigRuntimeLib.inf > > + ReportStatusCodeLib|MdeModulePkg/Library/RuntimeDxeReportStatusCodeLib/RuntimeDxeReportStatusCodeLib.inf > > !if $(SECURE_BOOT_ENABLE) == TRUE > > BaseCryptLib|CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf > > !endif > > -- > > 2.11.0 > > > IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.