From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::243; helo=mail-wm0-x243.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x243.google.com (mail-wm0-x243.google.com [IPv6:2a00:1450:400c:c09::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0C049202E5CDA for ; Thu, 19 Oct 2017 14:32:39 -0700 (PDT) Received: by mail-wm0-x243.google.com with SMTP id k4so18941785wmc.1 for ; Thu, 19 Oct 2017 14:36:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ARLSGDL4hHcVNSPIK16zeTKsxRXEKqbFcgpsfjZPhxA=; b=SOq4MQT85F5ETguTTuvnDRnBpgJSCkNSrNbivceZIHReE7aB5hq3S93FpJEzGf1n2A YW4DTM9tIaLF4XSxF7jSWXtGzH6ztKc79f0ltVXL6LQcuBwHi1707hTMjt8uyGLPqnnx 9yNjiEv8QARTJ61KpbwQAkjX1hKkPov5MMUsM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ARLSGDL4hHcVNSPIK16zeTKsxRXEKqbFcgpsfjZPhxA=; b=JLX9JPOW1Q+1N0D46wFCUyleOyjpOjIkwzObQPgg6YQw/vhJ3ZyRagUB3SW1K9aKRB vOtoy45fkLdSTELZZm5u4DtEgPLYunN+VYnmYc21Vy1b/OuOLPux+kUNkeLfVpq1Ob/6 ASEcGnmSKGgN2kHSx0UjfcztYnLqbNvGhqpOz/8fWPLABi5HHP/7GIrszV4eKziG64Zb CsvUu5YOfS8bzsYqL/Pk7PeQjkWT8fubm3DrHsw427D4JprrQdJP64B6b7uNztFxGFnT csJUegoV2unvRNXTMjVEA5tpLuS1m3rff0iokRScQRyx80bDyqIJ4b2ydUjqYMxtNa/s 1U5w== X-Gm-Message-State: AMCzsaWjUelt0BYqSD/JbxxrizSPRxxHVpmCF6XRj9RVvRGUrUYKjMKq JZmmYhsqYtxadBv4hEsuxlDoiimbJHw= X-Google-Smtp-Source: ABhQp+RXcuiJKf7rDt8SkZpRjQxUcjZ4zQlXVEVNWFWfPvsrJetqfwE0O7WNGp9LWHwzdNGAAGbIHw== X-Received: by 10.28.209.200 with SMTP id i191mr857024wmg.156.1508448977033; Thu, 19 Oct 2017 14:36:17 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id a195sm1996549wme.34.2017.10.19.14.36.15 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 19 Oct 2017 14:36:15 -0700 (PDT) Date: Thu, 19 Oct 2017 22:36:14 +0100 From: Leif Lindholm To: Ard Biesheuvel Cc: "edk2-devel@lists.01.org" Message-ID: <20171019213614.di3l3ixdswk6aqi7@bivouac.eciton.net> References: <20171019192141.4782-1-ard.biesheuvel@linaro.org> <20171019205504.uoiofih7quhjtiq4@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH] EmbeddedPkg/DtPlatformDxe: remove /chosen/stdout-path on GOP registration X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Oct 2017 21:32:40 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Oct 19, 2017 at 10:19:44PM +0100, Ard Biesheuvel wrote: > On 19 October 2017 at 21:55, Leif Lindholm wrote: > > On Thu, Oct 19, 2017 at 08:21:41PM +0100, Ard Biesheuvel wrote: > >> The presence of a /chosen/stdout-path property will force Linux to use > >> the serial port as the primary console, even if a graphical console is > >> available as well. But the presence of the Graphics Output Protocol (GOP) > >> is a strong indication that the user may prefer to use his keyboard and > >> mouse rather than his terminal emulator to interact with the system, so > >> let's remove /chosen/stdout-path as soon as a GOP instance is registered. > > > > This may be the sensible thing to do, but something just doesn't feel > > right. > > > > Also, whatever we do here, we should try to mirror in ACPI with SPCR. > > Yes, but it does not belong in this driver. Absolutely not - but it ties in with the Pcd suggestion below. > > Are we guaranteed to always want to disable serial console if there is > > a graphics adapter? > > This does not disable the serial console, it just makes it more > difficult to access :-) You will have to add console=ttyAMA0 if you > have a screen connected but want your console to appear on the serial > port. (Just like on a normal computer) Oh, I know - seeing those 8 characters just makes me twitch. > > I still dream of a world in which I can run consplitter up to the > > point where an OS takes over, and an OS installer will listen to input > > from both sources and register its selection from there. > > Yeah. I need this change to get the Debian installer to run on the FB > console without having to add 'console=tty0' to the kernel command > line. Yes, I really want that too. So I'm good with the halfway house of a dynamic preference Pcd. > > But if we can't have that, can we have a menu setting to select preference? > > The default can be a platform-specific Pcd. > > That seems reasonable. Thanks! / Leif