From: Peter Jones <pjones@redhat.com>
To: edk2-devel@lists.01.org
Subject: [PATCH v1 1/1] CryptoPkg/BaseCryptLib: remove some duplicate initializations.
Date: Fri, 20 Oct 2017 11:10:18 -0400 [thread overview]
Message-ID: <20171020151018.785-1-pjones@redhat.com> (raw)
clang-analyzer noticed this:
Pk/CryptPkcs7Verify.c:600:5: warning: Value stored to 'OldSize' is never read
OldSize = BufferSize;
^ ~~~~~~~~~~
Pk/CryptPkcs7Verify.c:644:5: warning: Value stored to 'OldSize' is never read
OldSize = BufferSize;
^ ~~~~~~~~~~
2 warnings generated.
These are each immediately followed by a loop that initializes them (to
the same values) a second time, and are otherwise only referenced inside
that loop, so there's just no point to these assignments at all.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Peter Jones <pjones@redhat.com>
---
CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7Verify.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7Verify.c b/CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7Verify.c
index d564591cb7f9..bf67a1f569a2 100644
--- a/CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7Verify.c
+++ b/CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7Verify.c
@@ -612,7 +612,6 @@ Pkcs7GetCertificatesList (
if (CtxChain != NULL) {
BufferSize = sizeof (UINT8);
- OldSize = BufferSize;
CertBuf = NULL;
for (Index = 0; ; Index++) {
@@ -656,7 +655,6 @@ Pkcs7GetCertificatesList (
if (CtxUntrusted != NULL) {
BufferSize = sizeof (UINT8);
- OldSize = BufferSize;
CertBuf = NULL;
for (Index = 0; ; Index++) {
--
2.14.2
next reply other threads:[~2017-10-20 15:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-20 15:10 Peter Jones [this message]
2017-10-20 17:12 ` [PATCH v1 1/1] CryptoPkg/BaseCryptLib: remove some duplicate initializations Laszlo Ersek
2017-10-20 18:21 ` Peter Jones
2017-10-23 3:02 ` Long, Qin
2017-10-24 7:51 ` Laszlo Ersek
2017-10-24 8:15 ` Long, Qin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171020151018.785-1-pjones@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox