public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: edk2-devel-01 <edk2-devel@lists.01.org>
Cc: Andrew Fish <afish@apple.com>, Eric Dong <eric.dong@intel.com>,
	Jeff Fan <vanjeff_919@hotmail.com>,
	Leif Lindholm <leif.lindholm@linaro.org>,
	Michael D Kinney <michael.d.kinney@intel.com>,
	Ruiyu Ni <ruiyu.ni@intel.com>
Subject: [PATCH] Maintainers.txt: add Laszlo Ersek as UefiCpuPkg reviewer
Date: Tue, 24 Oct 2017 12:53:12 +0200	[thread overview]
Message-ID: <20171024105312.18143-1-lersek@redhat.com> (raw)

UefiCpuPkg hosts a number of modules (SMM infrastructure,
MP-initialization) that may behave differently enough between
virtualization guests and physical boards that they merit regression
testing and review specifically from a virtualization perspective.

Add Laszlo as a UefiCpuPkg reviewer (not maintainer) so that he be CC'd on
all UefiCpuPkg patches.

> R: Package Reviewer: Cc address for patches and questions. Reviewers
>    help maintainers review code, but don't have push access.

Cc: Andrew Fish <afish@apple.com>
Cc: Eric Dong <eric.dong@intel.com>
Cc: Jeff Fan <vanjeff_919@hotmail.com>
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---

Notes:
    Recently there have been two UefiCpuPkg patches on the list that have
    each spent hardly more than 24 hours in review:
    
    * d76c2da8d50d ("MdeModulePkg/PiSmmCore: Install Protocol when S3 resume
      finished.", 2017-10-11),
    
    * 0594ec417c89 ("UefiCpuPkg/MpInitLib: Enhance waiting for AP
      initialization logic.", 2017-10-23).
    
    Both times, I was out of office, and didn't get a chance to comment. The
    first commit broke OVMF:
    
      http://mid.mail-archive.com/8d678707-fb07-0326-acfd-878bb7e8c5d6@redhat.com
      https://github.com/tianocore/edk2/commit/152e8d7670d5
    
    while the second commit has a good chance to break OVMF on at least some
    virt hosts:
    
      https://lists.01.org/pipermail/edk2-devel/2017-October/016309.html
    
    I was not CC'd either time. Had I been CC'd, the automated out-of-office
    reply that I always set up would have been received on the submitter's
    side, and I could have tested and/or commented on the patches in
    question, before they were pushed.
    
    My intent as a UefiCpuPkg Reviewer is to be inserted in the patch review
    process for UefiCpuPkg. I should be explicitly CC'd; and my feedback
    should please be waited upon. I think I've proved myself reasonably
    responsive; I intend to follow up in a few days every time. My review
    should definitely not replace Eric's review, but I'd like to get an
    *official* chance to raise questions before a patch is pushed. Whenever
    I have nothing to add, I'll send an Acked-by. Thanks.

 Maintainers.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Maintainers.txt b/Maintainers.txt
index c1a5723af9db..297a9bfd2b56 100644
--- a/Maintainers.txt
+++ b/Maintainers.txt
@@ -245,6 +245,7 @@ M: Jaben Carsey <jaben.carsey@intel.com>
 UefiCpuPkg
 W: https://github.com/tianocore/tianocore.github.io/wiki/UefiCpuPkg
 M: Eric Dong <eric.dong@intel.com>
+R: Laszlo Ersek <lersek@redhat.com>
 
 UnixPkg
 W: https://github.com/tianocore/tianocore.github.io/wiki/UnixPkg
-- 
2.14.1.3.gb7cf6e02401b



             reply	other threads:[~2017-10-24 10:49 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-24 10:53 Laszlo Ersek [this message]
2017-10-24 11:02 ` [PATCH] Maintainers.txt: add Laszlo Ersek as UefiCpuPkg reviewer Shi, Steven
2017-10-24 13:16   ` Laszlo Ersek
2017-10-24 15:28 ` Dong, Eric
2017-10-24 16:23   ` Laszlo Ersek
2017-10-24 16:37     ` Leif Lindholm
2017-10-26 10:40 ` Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171024105312.18143-1-lersek@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox