public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Leif Lindholm <leif.lindholm@linaro.org>
To: Laszlo Ersek <lersek@redhat.com>
Cc: edk2-devel@lists.01.org, daniel.thompson@linaro.org,
	Ard Biesheuvel <ard.biesheuvel@linaro.org>,
	Siyuan Fu <siyuan.fu@intel.com>, Jiaxin Wu <jiaxin.wu@intel.com>
Subject: Re: [RFC PATCH] ArmPkg: add driver to add distro installer HTTP boot options
Date: Tue, 24 Oct 2017 15:44:14 +0100	[thread overview]
Message-ID: <20171024144414.rlwaygmqsirgovlh@bivouac.eciton.net> (raw)
In-Reply-To: <a2784259-e0da-a28c-02f0-624b7dc8503b@redhat.com>

On Tue, Oct 24, 2017 at 03:32:51PM +0200, Laszlo Ersek wrote:
> > Convenience. And given that I only noticed yesterday that the boot
> > fails on HTTP redirects, of somewhat restricted value.
> > 
> > Is that an official policy decision, or just a restriction of the
> > implementation?
> 
> Hm, I'm unsure; the following seems to imply that HttpBootDxe intends to handle redirects:
> 
>         if (HttpBootIsHttpRedirectStatusCode (HttpMessage->Data.Response->StatusCode)) {
>           //
>           // Server indicates the resource has been redirected to a different URL
>           // according to the section 6.4 of RFC7231 and the RFC 7538.
>           // Display the redirect information on the screen.
>           //
>           HttpHeader = HttpFindHeader (
>                  HttpMessage->HeaderCount,
>                  HttpMessage->Headers,
>                  HTTP_HEADER_LOCATION
>                  );
>           if (HttpHeader != NULL) {
>             Print (L"\n  HTTP ERROR: Resource Redirected.\n  New Location: %a\n", HttpHeader->FieldValue);
>           }
> 
> Can you perhaps capture a packet trace and discuss it with Siyuan
> and Jiaxin? Perhaps the server returns a status code that is not
> handled by HttpBootDxe right now.

Oh, it's explicitly printed as a 302 (Found), detected by
HttpBootDxe/HttpBootSupport.c:HttpBootPrintErrorMessage().

See https://www.mail-archive.com/edk2-devel@lists.01.org/msg27819.html

But yes, I should have cc:d Siyuan and Jiaxin (and have now done so).
Can you comment?

Regards,

Leif


  reply	other threads:[~2017-10-24 14:40 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-21 13:10 [RFC PATCH] ArmPkg: add driver to add distro installer HTTP boot options Ard Biesheuvel
2017-10-22 14:40 ` Leif Lindholm
2017-10-22 15:16   ` Ard Biesheuvel
2017-10-24 12:10 ` Laszlo Ersek
2017-10-24 12:36   ` Leif Lindholm
2017-10-24 13:32     ` Laszlo Ersek
2017-10-24 14:44       ` Leif Lindholm [this message]
2017-10-25  2:18         ` Fu, Siyuan
2017-10-25  8:37           ` Leif Lindholm
2017-10-25  8:55             ` Fu, Siyuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171024144414.rlwaygmqsirgovlh@bivouac.eciton.net \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox