[PATCH] Maintainers.txt: add Laszlo Ersek as UefiCpuPkg reviewer

[PATCH] Maintainers.txt: add Laszlo Ersek as UefiCpuPkg reviewer

[Laszlo Ersek]

UefiCpuPkg hosts a number of modules (SMM infrastructure,
MP-initialization) that may behave differently enough between
virtualization guests and physical boards that they merit regression
testing and review specifically from a virtualization perspective.

Add Laszlo as a UefiCpuPkg reviewer (not maintainer) so that he be CC'd on
all UefiCpuPkg patches.

> R: Package Reviewer: Cc address for patches and questions. Reviewers
>    help maintainers review code, but don't have push access.

Cc: Andrew Fish <afish@apple.com>
Cc: Eric Dong <eric.dong@intel.com>
Cc: Jeff Fan <vanjeff_919@hotmail.com>
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---

Notes:
    Recently there have been two UefiCpuPkg patches on the list that have
    each spent hardly more than 24 hours in review:
    
    * d76c2da8d50d ("MdeModulePkg/PiSmmCore: Install Protocol when S3 resume
      finished.", 2017-10-11),
    
    * 0594ec417c89 ("UefiCpuPkg/MpInitLib: Enhance waiting for AP
      initialization logic.", 2017-10-23).
    
    Both times, I was out of office, and didn't get a chance to comment. The
    first commit broke OVMF:
    
      http://mid.mail-archive.com/8d678707-fb07-0326-acfd-878bb7e8c5d6@redhat.com
      https://github.com/tianocore/edk2/commit/152e8d7670d5
    
    while the second commit has a good chance to break OVMF on at least some
    virt hosts:
    
      https://lists.01.org/pipermail/edk2-devel/2017-October/016309.html
    
    I was not CC'd either time. Had I been CC'd, the automated out-of-office
    reply that I always set up would have been received on the submitter's
    side, and I could have tested and/or commented on the patches in
    question, before they were pushed.
    
    My intent as a UefiCpuPkg Reviewer is to be inserted in the patch review
    process for UefiCpuPkg. I should be explicitly CC'd; and my feedback
    should please be waited upon. I think I've proved myself reasonably
    responsive; I intend to follow up in a few days every time. My review
    should definitely not replace Eric's review, but I'd like to get an
    *official* chance to raise questions before a patch is pushed. Whenever
    I have nothing to add, I'll send an Acked-by. Thanks.

 Maintainers.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Maintainers.txt b/Maintainers.txt
index c1a5723af9db..297a9bfd2b56 100644
--- a/Maintainers.txt
+++ b/Maintainers.txt
@@ -245,6 +245,7 @@ M: Jaben Carsey <jaben.carsey@intel.com>
 UefiCpuPkg
 W: https://github.com/tianocore/tianocore.github.io/wiki/UefiCpuPkg
 M: Eric Dong <eric.dong@intel.com>
+R: Laszlo Ersek <lersek@redhat.com>
 
 UnixPkg
 W: https://github.com/tianocore/tianocore.github.io/wiki/UnixPkg
-- 
2.14.1.3.gb7cf6e02401b

Re: [PATCH] Maintainers.txt: add Laszlo Ersek as UefiCpuPkg reviewer

[Shi, Steven]

Hi Laszlo,
I happen hope to know how to well test the IOMMU/VT-D feature on OVMF. Can you give me some hints?


Steven Shi
Intel\SSG\STO\UEFI Firmware

Tel: +86 021-61166522
iNet: 821-6522

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Laszlo Ersek
> Sent: Tuesday, October 24, 2017 6:53 PM
> To: edk2-devel-01 <edk2-devel@lists.01.org>
> Cc: Ni, Ruiyu <ruiyu.ni@intel.com>; Dong, Eric <eric.dong@intel.com>;
> Andrew Fish <afish@apple.com>; Leif Lindholm <leif.lindholm@linaro.org>;
> Kinney, Michael D <michael.d.kinney@intel.com>
> Subject: [edk2] [PATCH] Maintainers.txt: add Laszlo Ersek as UefiCpuPkg
> reviewer
> 
> UefiCpuPkg hosts a number of modules (SMM infrastructure,
> MP-initialization) that may behave differently enough between
> virtualization guests and physical boards that they merit regression
> testing and review specifically from a virtualization perspective.
> 
> Add Laszlo as a UefiCpuPkg reviewer (not maintainer) so that he be CC'd on
> all UefiCpuPkg patches.
> 
> > R: Package Reviewer: Cc address for patches and questions. Reviewers
> >    help maintainers review code, but don't have push access.
> 
> Cc: Andrew Fish <afish@apple.com>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Jeff Fan <vanjeff_919@hotmail.com>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
> 
> Notes:
>     Recently there have been two UefiCpuPkg patches on the list that have
>     each spent hardly more than 24 hours in review:
> 
>     * d76c2da8d50d ("MdeModulePkg/PiSmmCore: Install Protocol when S3
> resume
>       finished.", 2017-10-11),
> 
>     * 0594ec417c89 ("UefiCpuPkg/MpInitLib: Enhance waiting for AP
>       initialization logic.", 2017-10-23).
> 
>     Both times, I was out of office, and didn't get a chance to comment. The
>     first commit broke OVMF:
> 
>       http://mid.mail-archive.com/8d678707-fb07-0326-acfd-
> 878bb7e8c5d6@redhat.com
>       https://github.com/tianocore/edk2/commit/152e8d7670d5
> 
>     while the second commit has a good chance to break OVMF on at least
> some
>     virt hosts:
> 
>       https://lists.01.org/pipermail/edk2-devel/2017-October/016309.html
> 
>     I was not CC'd either time. Had I been CC'd, the automated out-of-office
>     reply that I always set up would have been received on the submitter's
>     side, and I could have tested and/or commented on the patches in
>     question, before they were pushed.
> 
>     My intent as a UefiCpuPkg Reviewer is to be inserted in the patch review
>     process for UefiCpuPkg. I should be explicitly CC'd; and my feedback
>     should please be waited upon. I think I've proved myself reasonably
>     responsive; I intend to follow up in a few days every time. My review
>     should definitely not replace Eric's review, but I'd like to get an
>     *official* chance to raise questions before a patch is pushed. Whenever
>     I have nothing to add, I'll send an Acked-by. Thanks.
> 
>  Maintainers.txt | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Maintainers.txt b/Maintainers.txt
> index c1a5723af9db..297a9bfd2b56 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -245,6 +245,7 @@ M: Jaben Carsey <jaben.carsey@intel.com>
>  UefiCpuPkg
>  W: https://github.com/tianocore/tianocore.github.io/wiki/UefiCpuPkg
>  M: Eric Dong <eric.dong@intel.com>
> +R: Laszlo Ersek <lersek@redhat.com>
> 
>  UnixPkg
>  W: https://github.com/tianocore/tianocore.github.io/wiki/UnixPkg
> --
> 2.14.1.3.gb7cf6e02401b
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel

Re: [PATCH] Maintainers.txt: add Laszlo Ersek as UefiCpuPkg reviewer

[Laszlo Ersek]

Hi Steven,

On 10/24/17 13:02, Shi, Steven wrote:
> Hi Laszlo,
> I happen hope to know how to well test the IOMMU/VT-D feature on OVMF. Can you give me some hints?

first of all, please let us not discuss questions that are unrelated to
a patch under that patch. If you have a question about OVMF, I'm happy
to talk about it, in a separate thread -- just email edk2 and CC me; but
not in response to an unrelated patch.

Second, I'm not sure what level of vt-d emulation QEMU provides. I
suggest asking the question on the qemu-devel mailing list. If QEMU
emulates vt-d closely enough, then bringing the edk2 vt-d modules into
OVMF might suffice.

Thanks
Laszlo


> 
> 
> Steven Shi
> Intel\SSG\STO\UEFI Firmware
> 
> Tel: +86 021-61166522
> iNet: 821-6522
> 
>> -----Original Message-----
>> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
>> Laszlo Ersek
>> Sent: Tuesday, October 24, 2017 6:53 PM
>> To: edk2-devel-01 <edk2-devel@lists.01.org>
>> Cc: Ni, Ruiyu <ruiyu.ni@intel.com>; Dong, Eric <eric.dong@intel.com>;
>> Andrew Fish <afish@apple.com>; Leif Lindholm <leif.lindholm@linaro.org>;
>> Kinney, Michael D <michael.d.kinney@intel.com>
>> Subject: [edk2] [PATCH] Maintainers.txt: add Laszlo Ersek as UefiCpuPkg
>> reviewer
>>
>> UefiCpuPkg hosts a number of modules (SMM infrastructure,
>> MP-initialization) that may behave differently enough between
>> virtualization guests and physical boards that they merit regression
>> testing and review specifically from a virtualization perspective.
>>
>> Add Laszlo as a UefiCpuPkg reviewer (not maintainer) so that he be CC'd on
>> all UefiCpuPkg patches.
>>
>>> R: Package Reviewer: Cc address for patches and questions. Reviewers
>>>    help maintainers review code, but don't have push access.
>>
>> Cc: Andrew Fish <afish@apple.com>
>> Cc: Eric Dong <eric.dong@intel.com>
>> Cc: Jeff Fan <vanjeff_919@hotmail.com>
>> Cc: Leif Lindholm <leif.lindholm@linaro.org>
>> Cc: Michael D Kinney <michael.d.kinney@intel.com>
>> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
>> ---
>>
>> Notes:
>>     Recently there have been two UefiCpuPkg patches on the list that have
>>     each spent hardly more than 24 hours in review:
>>
>>     * d76c2da8d50d ("MdeModulePkg/PiSmmCore: Install Protocol when S3
>> resume
>>       finished.", 2017-10-11),
>>
>>     * 0594ec417c89 ("UefiCpuPkg/MpInitLib: Enhance waiting for AP
>>       initialization logic.", 2017-10-23).
>>
>>     Both times, I was out of office, and didn't get a chance to comment. The
>>     first commit broke OVMF:
>>
>>       http://mid.mail-archive.com/8d678707-fb07-0326-acfd-
>> 878bb7e8c5d6@redhat.com
>>       https://github.com/tianocore/edk2/commit/152e8d7670d5
>>
>>     while the second commit has a good chance to break OVMF on at least
>> some
>>     virt hosts:
>>
>>       https://lists.01.org/pipermail/edk2-devel/2017-October/016309.html
>>
>>     I was not CC'd either time. Had I been CC'd, the automated out-of-office
>>     reply that I always set up would have been received on the submitter's
>>     side, and I could have tested and/or commented on the patches in
>>     question, before they were pushed.
>>
>>     My intent as a UefiCpuPkg Reviewer is to be inserted in the patch review
>>     process for UefiCpuPkg. I should be explicitly CC'd; and my feedback
>>     should please be waited upon. I think I've proved myself reasonably
>>     responsive; I intend to follow up in a few days every time. My review
>>     should definitely not replace Eric's review, but I'd like to get an
>>     *official* chance to raise questions before a patch is pushed. Whenever
>>     I have nothing to add, I'll send an Acked-by. Thanks.
>>
>>  Maintainers.txt | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/Maintainers.txt b/Maintainers.txt
>> index c1a5723af9db..297a9bfd2b56 100644
>> --- a/Maintainers.txt
>> +++ b/Maintainers.txt
>> @@ -245,6 +245,7 @@ M: Jaben Carsey <jaben.carsey@intel.com>
>>  UefiCpuPkg
>>  W: https://github.com/tianocore/tianocore.github.io/wiki/UefiCpuPkg
>>  M: Eric Dong <eric.dong@intel.com>
>> +R: Laszlo Ersek <lersek@redhat.com>
>>
>>  UnixPkg
>>  W: https://github.com/tianocore/tianocore.github.io/wiki/UnixPkg
>> --
>> 2.14.1.3.gb7cf6e02401b
>>
>> _______________________________________________
>> edk2-devel mailing list
>> edk2-devel@lists.01.org
>> https://lists.01.org/mailman/listinfo/edk2-devel

Re: [PATCH] Maintainers.txt: add Laszlo Ersek as UefiCpuPkg reviewer

[Dong, Eric]

Laszlo,

Thanks for your willing to review all CPU changes. We also found Ovmf is a very special system and need to take it in to consideration when do the changes.

Reviewed-by: Eric Dong <eric.dong@intel.com>

Thanks,
Eric

> -----Original Message-----
> From: Laszlo Ersek [mailto:lersek@redhat.com]
> Sent: Tuesday, October 24, 2017 6:53 PM
> To: edk2-devel-01 <edk2-devel@lists.01.org>
> Cc: Andrew Fish <afish@apple.com>; Dong, Eric <eric.dong@intel.com>; Jeff
> Fan <vanjeff_919@hotmail.com>; Leif Lindholm <leif.lindholm@linaro.org>;
> Kinney, Michael D <michael.d.kinney@intel.com>; Ni, Ruiyu
> <ruiyu.ni@intel.com>
> Subject: [PATCH] Maintainers.txt: add Laszlo Ersek as UefiCpuPkg reviewer
> 
> UefiCpuPkg hosts a number of modules (SMM infrastructure,
> MP-initialization) that may behave differently enough between virtualization
> guests and physical boards that they merit regression testing and review
> specifically from a virtualization perspective.
> 
> Add Laszlo as a UefiCpuPkg reviewer (not maintainer) so that he be CC'd on
> all UefiCpuPkg patches.
> 
> > R: Package Reviewer: Cc address for patches and questions. Reviewers
> >    help maintainers review code, but don't have push access.
> 
> Cc: Andrew Fish <afish@apple.com>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Jeff Fan <vanjeff_919@hotmail.com>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
> 
> Notes:
>     Recently there have been two UefiCpuPkg patches on the list that have
>     each spent hardly more than 24 hours in review:
> 
>     * d76c2da8d50d ("MdeModulePkg/PiSmmCore: Install Protocol when S3
> resume
>       finished.", 2017-10-11),
> 
>     * 0594ec417c89 ("UefiCpuPkg/MpInitLib: Enhance waiting for AP
>       initialization logic.", 2017-10-23).
> 
>     Both times, I was out of office, and didn't get a chance to comment. The
>     first commit broke OVMF:
> 
>       http://mid.mail-archive.com/8d678707-fb07-0326-acfd-
> 878bb7e8c5d6@redhat.com
>       https://github.com/tianocore/edk2/commit/152e8d7670d5
> 
>     while the second commit has a good chance to break OVMF on at least
> some
>     virt hosts:
> 
>       https://lists.01.org/pipermail/edk2-devel/2017-October/016309.html
> 
>     I was not CC'd either time. Had I been CC'd, the automated out-of-office
>     reply that I always set up would have been received on the submitter's
>     side, and I could have tested and/or commented on the patches in
>     question, before they were pushed.
> 
>     My intent as a UefiCpuPkg Reviewer is to be inserted in the patch review
>     process for UefiCpuPkg. I should be explicitly CC'd; and my feedback
>     should please be waited upon. I think I've proved myself reasonably
>     responsive; I intend to follow up in a few days every time. My review
>     should definitely not replace Eric's review, but I'd like to get an
>     *official* chance to raise questions before a patch is pushed. Whenever
>     I have nothing to add, I'll send an Acked-by. Thanks.
> 
>  Maintainers.txt | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Maintainers.txt b/Maintainers.txt index
> c1a5723af9db..297a9bfd2b56 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -245,6 +245,7 @@ M: Jaben Carsey <jaben.carsey@intel.com>
> UefiCpuPkg
>  W: https://github.com/tianocore/tianocore.github.io/wiki/UefiCpuPkg
>  M: Eric Dong <eric.dong@intel.com>
> +R: Laszlo Ersek <lersek@redhat.com>
> 
>  UnixPkg
>  W: https://github.com/tianocore/tianocore.github.io/wiki/UnixPkg
> --
> 2.14.1.3.gb7cf6e02401b

Re: [PATCH] Maintainers.txt: add Laszlo Ersek as UefiCpuPkg reviewer

[Laszlo Ersek]

On 10/24/17 17:28, Dong, Eric wrote:
> Laszlo,
> 
> Thanks for your willing to review all CPU changes. We also found Ovmf is a very special system and need to take it in to consideration when do the changes.
> 
> Reviewed-by: Eric Dong <eric.dong@intel.com>

Thank you Eric!

Can one (or more) of the Stewards ACK as well please?

(This is an admin change, not a code change, so I guess it should be
fine to push on Thursday or so.)

Thanks!
Laszlo


>> -----Original Message-----
>> From: Laszlo Ersek [mailto:lersek@redhat.com]
>> Sent: Tuesday, October 24, 2017 6:53 PM
>> To: edk2-devel-01 <edk2-devel@lists.01.org>
>> Cc: Andrew Fish <afish@apple.com>; Dong, Eric <eric.dong@intel.com>; Jeff
>> Fan <vanjeff_919@hotmail.com>; Leif Lindholm <leif.lindholm@linaro.org>;
>> Kinney, Michael D <michael.d.kinney@intel.com>; Ni, Ruiyu
>> <ruiyu.ni@intel.com>
>> Subject: [PATCH] Maintainers.txt: add Laszlo Ersek as UefiCpuPkg reviewer
>>
>> UefiCpuPkg hosts a number of modules (SMM infrastructure,
>> MP-initialization) that may behave differently enough between virtualization
>> guests and physical boards that they merit regression testing and review
>> specifically from a virtualization perspective.
>>
>> Add Laszlo as a UefiCpuPkg reviewer (not maintainer) so that he be CC'd on
>> all UefiCpuPkg patches.
>>
>>> R: Package Reviewer: Cc address for patches and questions. Reviewers
>>>    help maintainers review code, but don't have push access.
>>
>> Cc: Andrew Fish <afish@apple.com>
>> Cc: Eric Dong <eric.dong@intel.com>
>> Cc: Jeff Fan <vanjeff_919@hotmail.com>
>> Cc: Leif Lindholm <leif.lindholm@linaro.org>
>> Cc: Michael D Kinney <michael.d.kinney@intel.com>
>> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
>> ---
>>
>> Notes:
>>     Recently there have been two UefiCpuPkg patches on the list that have
>>     each spent hardly more than 24 hours in review:
>>
>>     * d76c2da8d50d ("MdeModulePkg/PiSmmCore: Install Protocol when S3
>> resume
>>       finished.", 2017-10-11),
>>
>>     * 0594ec417c89 ("UefiCpuPkg/MpInitLib: Enhance waiting for AP
>>       initialization logic.", 2017-10-23).
>>
>>     Both times, I was out of office, and didn't get a chance to comment. The
>>     first commit broke OVMF:
>>
>>       http://mid.mail-archive.com/8d678707-fb07-0326-acfd-
>> 878bb7e8c5d6@redhat.com
>>       https://github.com/tianocore/edk2/commit/152e8d7670d5
>>
>>     while the second commit has a good chance to break OVMF on at least
>> some
>>     virt hosts:
>>
>>       https://lists.01.org/pipermail/edk2-devel/2017-October/016309.html
>>
>>     I was not CC'd either time. Had I been CC'd, the automated out-of-office
>>     reply that I always set up would have been received on the submitter's
>>     side, and I could have tested and/or commented on the patches in
>>     question, before they were pushed.
>>
>>     My intent as a UefiCpuPkg Reviewer is to be inserted in the patch review
>>     process for UefiCpuPkg. I should be explicitly CC'd; and my feedback
>>     should please be waited upon. I think I've proved myself reasonably
>>     responsive; I intend to follow up in a few days every time. My review
>>     should definitely not replace Eric's review, but I'd like to get an
>>     *official* chance to raise questions before a patch is pushed. Whenever
>>     I have nothing to add, I'll send an Acked-by. Thanks.
>>
>>  Maintainers.txt | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/Maintainers.txt b/Maintainers.txt index
>> c1a5723af9db..297a9bfd2b56 100644
>> --- a/Maintainers.txt
>> +++ b/Maintainers.txt
>> @@ -245,6 +245,7 @@ M: Jaben Carsey <jaben.carsey@intel.com>
>> UefiCpuPkg
>>  W: https://github.com/tianocore/tianocore.github.io/wiki/UefiCpuPkg
>>  M: Eric Dong <eric.dong@intel.com>
>> +R: Laszlo Ersek <lersek@redhat.com>
>>
>>  UnixPkg
>>  W: https://github.com/tianocore/tianocore.github.io/wiki/UnixPkg
>> --
>> 2.14.1.3.gb7cf6e02401b
> 

Re: [PATCH] Maintainers.txt: add Laszlo Ersek as UefiCpuPkg reviewer

[Leif Lindholm]

On Tue, Oct 24, 2017 at 06:23:11PM +0200, Laszlo Ersek wrote:
> On 10/24/17 17:28, Dong, Eric wrote:
> > Laszlo,
> > 
> > Thanks for your willing to review all CPU changes. We also found Ovmf is a very special system and need to take it in to consideration when do the changes.
> > 
> > Reviewed-by: Eric Dong <eric.dong@intel.com>
> 
> Thank you Eric!
> 
> Can one (or more) of the Stewards ACK as well please?
> 
> (This is an admin change, not a code change, so I guess it should be
> fine to push on Thursday or so.)

I am certainly happy with this, just wanted to hear from package
maintainers first:
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

/
    Leif

> Thanks!
> Laszlo
> 
> 
> >> -----Original Message-----
> >> From: Laszlo Ersek [mailto:lersek@redhat.com]
> >> Sent: Tuesday, October 24, 2017 6:53 PM
> >> To: edk2-devel-01 <edk2-devel@lists.01.org>
> >> Cc: Andrew Fish <afish@apple.com>; Dong, Eric <eric.dong@intel.com>; Jeff
> >> Fan <vanjeff_919@hotmail.com>; Leif Lindholm <leif.lindholm@linaro.org>;
> >> Kinney, Michael D <michael.d.kinney@intel.com>; Ni, Ruiyu
> >> <ruiyu.ni@intel.com>
> >> Subject: [PATCH] Maintainers.txt: add Laszlo Ersek as UefiCpuPkg reviewer
> >>
> >> UefiCpuPkg hosts a number of modules (SMM infrastructure,
> >> MP-initialization) that may behave differently enough between virtualization
> >> guests and physical boards that they merit regression testing and review
> >> specifically from a virtualization perspective.
> >>
> >> Add Laszlo as a UefiCpuPkg reviewer (not maintainer) so that he be CC'd on
> >> all UefiCpuPkg patches.
> >>
> >>> R: Package Reviewer: Cc address for patches and questions. Reviewers
> >>>    help maintainers review code, but don't have push access.
> >>
> >> Cc: Andrew Fish <afish@apple.com>
> >> Cc: Eric Dong <eric.dong@intel.com>
> >> Cc: Jeff Fan <vanjeff_919@hotmail.com>
> >> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> >> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> >> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> >> Contributed-under: TianoCore Contribution Agreement 1.1
> >> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> >> ---
> >>
> >> Notes:
> >>     Recently there have been two UefiCpuPkg patches on the list that have
> >>     each spent hardly more than 24 hours in review:
> >>
> >>     * d76c2da8d50d ("MdeModulePkg/PiSmmCore: Install Protocol when S3
> >> resume
> >>       finished.", 2017-10-11),
> >>
> >>     * 0594ec417c89 ("UefiCpuPkg/MpInitLib: Enhance waiting for AP
> >>       initialization logic.", 2017-10-23).
> >>
> >>     Both times, I was out of office, and didn't get a chance to comment. The
> >>     first commit broke OVMF:
> >>
> >>       http://mid.mail-archive.com/8d678707-fb07-0326-acfd-
> >> 878bb7e8c5d6@redhat.com
> >>       https://github.com/tianocore/edk2/commit/152e8d7670d5
> >>
> >>     while the second commit has a good chance to break OVMF on at least
> >> some
> >>     virt hosts:
> >>
> >>       https://lists.01.org/pipermail/edk2-devel/2017-October/016309.html
> >>
> >>     I was not CC'd either time. Had I been CC'd, the automated out-of-office
> >>     reply that I always set up would have been received on the submitter's
> >>     side, and I could have tested and/or commented on the patches in
> >>     question, before they were pushed.
> >>
> >>     My intent as a UefiCpuPkg Reviewer is to be inserted in the patch review
> >>     process for UefiCpuPkg. I should be explicitly CC'd; and my feedback
> >>     should please be waited upon. I think I've proved myself reasonably
> >>     responsive; I intend to follow up in a few days every time. My review
> >>     should definitely not replace Eric's review, but I'd like to get an
> >>     *official* chance to raise questions before a patch is pushed. Whenever
> >>     I have nothing to add, I'll send an Acked-by. Thanks.
> >>
> >>  Maintainers.txt | 1 +
> >>  1 file changed, 1 insertion(+)
> >>
> >> diff --git a/Maintainers.txt b/Maintainers.txt index
> >> c1a5723af9db..297a9bfd2b56 100644
> >> --- a/Maintainers.txt
> >> +++ b/Maintainers.txt
> >> @@ -245,6 +245,7 @@ M: Jaben Carsey <jaben.carsey@intel.com>
> >> UefiCpuPkg
> >>  W: https://github.com/tianocore/tianocore.github.io/wiki/UefiCpuPkg
> >>  M: Eric Dong <eric.dong@intel.com>
> >> +R: Laszlo Ersek <lersek@redhat.com>
> >>
> >>  UnixPkg
> >>  W: https://github.com/tianocore/tianocore.github.io/wiki/UnixPkg
> >> --
> >> 2.14.1.3.gb7cf6e02401b
> > 
> 

Re: [PATCH] Maintainers.txt: add Laszlo Ersek as UefiCpuPkg reviewer

[Laszlo Ersek]

On 10/24/17 12:53, Laszlo Ersek wrote:
> UefiCpuPkg hosts a number of modules (SMM infrastructure,
> MP-initialization) that may behave differently enough between
> virtualization guests and physical boards that they merit regression
> testing and review specifically from a virtualization perspective.
> 
> Add Laszlo as a UefiCpuPkg reviewer (not maintainer) so that he be CC'd on
> all UefiCpuPkg patches.
> 
>> R: Package Reviewer: Cc address for patches and questions. Reviewers
>>    help maintainers review code, but don't have push access.
> 
> Cc: Andrew Fish <afish@apple.com>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Jeff Fan <vanjeff_919@hotmail.com>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
> 
> Notes:
>     Recently there have been two UefiCpuPkg patches on the list that have
>     each spent hardly more than 24 hours in review:
>     
>     * d76c2da8d50d ("MdeModulePkg/PiSmmCore: Install Protocol when S3 resume
>       finished.", 2017-10-11),
>     
>     * 0594ec417c89 ("UefiCpuPkg/MpInitLib: Enhance waiting for AP
>       initialization logic.", 2017-10-23).
>     
>     Both times, I was out of office, and didn't get a chance to comment. The
>     first commit broke OVMF:
>     
>       http://mid.mail-archive.com/8d678707-fb07-0326-acfd-878bb7e8c5d6@redhat.com
>       https://github.com/tianocore/edk2/commit/152e8d7670d5
>     
>     while the second commit has a good chance to break OVMF on at least some
>     virt hosts:
>     
>       https://lists.01.org/pipermail/edk2-devel/2017-October/016309.html
>     
>     I was not CC'd either time. Had I been CC'd, the automated out-of-office
>     reply that I always set up would have been received on the submitter's
>     side, and I could have tested and/or commented on the patches in
>     question, before they were pushed.
>     
>     My intent as a UefiCpuPkg Reviewer is to be inserted in the patch review
>     process for UefiCpuPkg. I should be explicitly CC'd; and my feedback
>     should please be waited upon. I think I've proved myself reasonably
>     responsive; I intend to follow up in a few days every time. My review
>     should definitely not replace Eric's review, but I'd like to get an
>     *official* chance to raise questions before a patch is pushed. Whenever
>     I have nothing to add, I'll send an Acked-by. Thanks.
> 
>  Maintainers.txt | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Maintainers.txt b/Maintainers.txt
> index c1a5723af9db..297a9bfd2b56 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -245,6 +245,7 @@ M: Jaben Carsey <jaben.carsey@intel.com>
>  UefiCpuPkg
>  W: https://github.com/tianocore/tianocore.github.io/wiki/UefiCpuPkg
>  M: Eric Dong <eric.dong@intel.com>
> +R: Laszlo Ersek <lersek@redhat.com>
>  
>  UnixPkg
>  W: https://github.com/tianocore/tianocore.github.io/wiki/UnixPkg
> 

Commit c0cbaaf69348.

Thanks!
Laszlo