From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c0c::22c; helo=mail-wr0-x22c.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr0-x22c.google.com (mail-wr0-x22c.google.com [IPv6:2a00:1450:400c:c0c::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 4452321CEB156 for ; Tue, 24 Oct 2017 09:33:26 -0700 (PDT) Received: by mail-wr0-x22c.google.com with SMTP id r79so21333060wrb.13 for ; Tue, 24 Oct 2017 09:37:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=7VlYj8mjTWhIw93iri6FQdaFcz4QMo+Ochep7XEhJDE=; b=c+HmQDLWcD8Q+2TLDB795aB9uYcgNIXTqif5I50Lmv6MQeNs2dbOIaHyBnHpTxOljn SLEqFTRdAmQWDD0XF1+D6j3yN2T62A7LhfVRt5/rnHQxCNCX6zSjxKNETtFeiLyI7SsE S4pzs3k9uy/+9rokeIFHCFI9G3wBOiEElBRqM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=7VlYj8mjTWhIw93iri6FQdaFcz4QMo+Ochep7XEhJDE=; b=QLOj0QAjmRwQnAJ571WbgNpNES4lrmcKhjWu6PMX2TPOcMtY54zXRuAiWB2VjzwjpG /f7Ysj/wmDUqkiC6SRbc6gW5wq28bhx0kOWEZ3h/+e+YB89Lpsca4IBt0kvLHV76M624 Q6Z3xXrIDFKrHxEH632iExrdVfN9jAzVb1qTzEUJjPH4R2d677ldYIwjO/lcr25fbmhV Wp/3MCl36v026CPtHj/RB1cwnHpfmiUE59JZ288PlGJUEnAIGtDOKiHCr6DGEgC3LUA5 JxIGAQ6YJxIQvy2LVxr27toIhH6rZIhzUnJBW/SbzadhWcUcP0Z2dN0Qn3/TYBESSGgZ jvfg== X-Gm-Message-State: AMCzsaXGC49cBd9hOkch2kwjBOQXq2V31z88A4O1C9jEerjYeeABBTFp 3gm61cZUzr32wEnfHMM4+lauIQ== X-Google-Smtp-Source: ABhQp+QnsASKTJKSSR7AM9AsYZzV90m1eAAlDkZ5EgiWHLmiqdMHx72Eol32WXa0LcSGdwy8lqrlmg== X-Received: by 10.223.136.246 with SMTP id g51mr13885004wrg.226.1508863027856; Tue, 24 Oct 2017 09:37:07 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id z35sm795953wrc.9.2017.10.24.09.37.06 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 24 Oct 2017 09:37:06 -0700 (PDT) Date: Tue, 24 Oct 2017 17:37:05 +0100 From: Leif Lindholm To: Laszlo Ersek Cc: "Dong, Eric" , edk2-devel-01 , Andrew Fish , Jeff Fan , "Kinney, Michael D" , "Ni, Ruiyu" Message-ID: <20171024163705.db3q7c6ptkykbxjs@bivouac.eciton.net> References: <20171024105312.18143-1-lersek@redhat.com> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH] Maintainers.txt: add Laszlo Ersek as UefiCpuPkg reviewer X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Oct 2017 16:33:26 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Oct 24, 2017 at 06:23:11PM +0200, Laszlo Ersek wrote: > On 10/24/17 17:28, Dong, Eric wrote: > > Laszlo, > > > > Thanks for your willing to review all CPU changes. We also found Ovmf is a very special system and need to take it in to consideration when do the changes. > > > > Reviewed-by: Eric Dong > > Thank you Eric! > > Can one (or more) of the Stewards ACK as well please? > > (This is an admin change, not a code change, so I guess it should be > fine to push on Thursday or so.) I am certainly happy with this, just wanted to hear from package maintainers first: Reviewed-by: Leif Lindholm / Leif > Thanks! > Laszlo > > > >> -----Original Message----- > >> From: Laszlo Ersek [mailto:lersek@redhat.com] > >> Sent: Tuesday, October 24, 2017 6:53 PM > >> To: edk2-devel-01 > >> Cc: Andrew Fish ; Dong, Eric ; Jeff > >> Fan ; Leif Lindholm ; > >> Kinney, Michael D ; Ni, Ruiyu > >> > >> Subject: [PATCH] Maintainers.txt: add Laszlo Ersek as UefiCpuPkg reviewer > >> > >> UefiCpuPkg hosts a number of modules (SMM infrastructure, > >> MP-initialization) that may behave differently enough between virtualization > >> guests and physical boards that they merit regression testing and review > >> specifically from a virtualization perspective. > >> > >> Add Laszlo as a UefiCpuPkg reviewer (not maintainer) so that he be CC'd on > >> all UefiCpuPkg patches. > >> > >>> R: Package Reviewer: Cc address for patches and questions. Reviewers > >>> help maintainers review code, but don't have push access. > >> > >> Cc: Andrew Fish > >> Cc: Eric Dong > >> Cc: Jeff Fan > >> Cc: Leif Lindholm > >> Cc: Michael D Kinney > >> Cc: Ruiyu Ni > >> Contributed-under: TianoCore Contribution Agreement 1.1 > >> Signed-off-by: Laszlo Ersek > >> --- > >> > >> Notes: > >> Recently there have been two UefiCpuPkg patches on the list that have > >> each spent hardly more than 24 hours in review: > >> > >> * d76c2da8d50d ("MdeModulePkg/PiSmmCore: Install Protocol when S3 > >> resume > >> finished.", 2017-10-11), > >> > >> * 0594ec417c89 ("UefiCpuPkg/MpInitLib: Enhance waiting for AP > >> initialization logic.", 2017-10-23). > >> > >> Both times, I was out of office, and didn't get a chance to comment. The > >> first commit broke OVMF: > >> > >> http://mid.mail-archive.com/8d678707-fb07-0326-acfd- > >> 878bb7e8c5d6@redhat.com > >> https://github.com/tianocore/edk2/commit/152e8d7670d5 > >> > >> while the second commit has a good chance to break OVMF on at least > >> some > >> virt hosts: > >> > >> https://lists.01.org/pipermail/edk2-devel/2017-October/016309.html > >> > >> I was not CC'd either time. Had I been CC'd, the automated out-of-office > >> reply that I always set up would have been received on the submitter's > >> side, and I could have tested and/or commented on the patches in > >> question, before they were pushed. > >> > >> My intent as a UefiCpuPkg Reviewer is to be inserted in the patch review > >> process for UefiCpuPkg. I should be explicitly CC'd; and my feedback > >> should please be waited upon. I think I've proved myself reasonably > >> responsive; I intend to follow up in a few days every time. My review > >> should definitely not replace Eric's review, but I'd like to get an > >> *official* chance to raise questions before a patch is pushed. Whenever > >> I have nothing to add, I'll send an Acked-by. Thanks. > >> > >> Maintainers.txt | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/Maintainers.txt b/Maintainers.txt index > >> c1a5723af9db..297a9bfd2b56 100644 > >> --- a/Maintainers.txt > >> +++ b/Maintainers.txt > >> @@ -245,6 +245,7 @@ M: Jaben Carsey > >> UefiCpuPkg > >> W: https://github.com/tianocore/tianocore.github.io/wiki/UefiCpuPkg > >> M: Eric Dong > >> +R: Laszlo Ersek > >> > >> UnixPkg > >> W: https://github.com/tianocore/tianocore.github.io/wiki/UnixPkg > >> -- > >> 2.14.1.3.gb7cf6e02401b > > >