From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::242; helo=mail-wm0-x242.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x242.google.com (mail-wm0-x242.google.com [IPv6:2a00:1450:400c:c09::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 8D50021CEB12B for ; Wed, 25 Oct 2017 08:32:24 -0700 (PDT) Received: by mail-wm0-x242.google.com with SMTP id u138so2760824wmu.4 for ; Wed, 25 Oct 2017 08:36:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=7CXj4RgEty6nySFh+ci0pwreQbEHMHKIHI8hWkdck84=; b=R9/cAmsBmInx6Qjvgsp/7GdPUnDP83j0ED7h4ABdPIK1aSxNB1rIeJ20J0tXX/HeWi N39AOKEzwkKr6oiXL8a4ffJ1VHOq7QteRTeG/rg9Mz4RW/PKUXZqKK/El+mcoF5kARlp VDRcDpqrAlHEsI04a0K9weIcTMyJjwGRtPV14= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=7CXj4RgEty6nySFh+ci0pwreQbEHMHKIHI8hWkdck84=; b=K2Gr9WpZy6pKhRcJ+deI5QVQdNzyd9i82UorsR0HkCFZv+te0b/BIL4SZv0Omk4iiC dfxtjyVwz8KE81NRRoG9QmUGa0Nr5yH27H19rrVS+x2hKnj6EaUUwMcOtwpNinXt8xq6 RguShsO6Jgl75p2vqlAlM5aSRcBAdTozD9N+5Fcn8Ms1ZKOEM3TCEMjz/lpo2LbVVqi8 eMBuKL93JcobLIXM/DIrEu/0auP7PQxgKDc5ZKZ0t5Hy/r0QmK+D3P0jL+1sFZc6DykF Nzp49j7cqNblhDYViwrd0tHR8ROtUfjy2ZnFxSaUcZbDZY7IVwbzjpX8WpCczNLMOGTN u3gA== X-Gm-Message-State: AMCzsaW9LvMmjBItqiGOUUs4iQ2UqMeOUe3rwCi71hqMpwiJCxbzBaII 8pnWSKH/UvX+0qRaA4x+HFqLPyK6eb0= X-Google-Smtp-Source: ABhQp+Teg2I4P71NZcCSH7PEnX7Q43/93EjcX/IvDuHS19HQ3SSQGnrqeu7jIajK9Mx8aDUXZLPyqw== X-Received: by 10.28.156.67 with SMTP id f64mr2152129wme.42.1508945768223; Wed, 25 Oct 2017 08:36:08 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id m25sm2952805wmi.7.2017.10.25.08.36.07 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 25 Oct 2017 08:36:07 -0700 (PDT) Date: Wed, 25 Oct 2017 16:36:05 +0100 From: Leif Lindholm To: evan.lloyd@arm.com Cc: edk2-devel@lists.01.org, Arvind Chauhan , Daniil Egranov , Thomas Panakamattam Abraham Message-ID: <20171025153605.hhvk6bz5iwgc65qu@bivouac.eciton.net> References: <20170927191044.13668-1-evan.lloyd@arm.com> MIME-Version: 1.0 In-Reply-To: <20170927191044.13668-1-evan.lloyd@arm.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH] Platform/ARM: Reorganize Lcd Graphics Output X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Oct 2017 15:32:24 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Sep 27, 2017 at 08:10:44PM +0100, evan.lloyd@arm.com wrote: > From: Girish Pathak > > This corresponds to the recently submitted edk2 change "ArmPlatformPkg: > Reorganize Lcd Graphics Output". > > This change enables building of a common LcdGraphicsOutputDxe, > replacing PL111LcdGraphicsOutputDxe and HdLcdGraphicsOutputDxe. > > One of the different hardware implementations (PL111Lcd, HdLcd, and > MaliDp) is included as a LcdHwLib library. > > NOTE: The FVP changes include framework for HdLcd and MaliDp builds. > These are not part of the supported FVP model, but may be added as > customisations. Because the parameters that might be used are not > known, some PCD settings are commented out. 1) Note below ---. 2) This makes sense to me, but I'm not actually seeing any MaliDp bits below - am I missing something? / Leif > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Girish Pathak > Signed-off-by: Evan Lloyd > --- > > Code can be examined at: > https://github.com/EvanLloyd/edk2-platforms/tree/166_gop_v1 > > Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc | 7 ++++--- > Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc | 5 +++-- > Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.fdf | 6 +++--- > Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.fdf | 4 ++-- > 4 files changed, 12 insertions(+), 10 deletions(-) > > diff --git a/Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc b/Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc > index efa41165e4ad8a16eacc9c707e0d1b5b60e89b1d..cabae1c7610183046220868776d20ae4e6bfa161 100644 > --- a/Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc > +++ b/Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc > @@ -1,5 +1,5 @@ > # > -# Copyright (c) 2012-2015, ARM Limited. All rights reserved. > +# Copyright (c) 2012-2017, ARM Limited. All rights reserved. > # Copyright (c) 2015, Intel Corporation. All rights reserved.
> # > # This program and the accompanying materials > @@ -51,6 +51,7 @@ [LibraryClasses.common] > ArmGicLib|ArmPkg/Drivers/ArmGic/ArmGicLib.inf > > LcdPlatformLib|ArmPlatformPkg/ArmVExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpressLib.inf > + LcdHwLib|ArmPlatformPkg/Drivers/HdLcd/HdLcd.inf > > TimerLib|ArmPkg/Library/ArmArchTimerLib/ArmArchTimerLib.inf > ArmSmcLib|ArmPkg/Library/ArmSmcLib/ArmSmcLib.inf > @@ -236,8 +237,8 @@ [Components.common] > > ArmPkg/Drivers/ArmGic/ArmGicDxe.inf > ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.inf > - #ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/PL111LcdGraphicsOutputDxe.inf > - ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/HdLcdGraphicsOutputDxe.inf > + > + ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.inf > ArmPkg/Drivers/TimerDxe/TimerDxe.inf > ArmPlatformPkg/Drivers/SP805WatchdogDxe/SP805WatchdogDxe.inf > > diff --git a/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc b/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc > index e9f954d926ac25a2abd2f97a4141267927dfc0a3..2f1811cc68a9a4c3d8f71520533f69b8eafef3f6 100644 > --- a/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc > +++ b/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc > @@ -1,5 +1,5 @@ > # > -# Copyright (c) 2011-2015, ARM Limited. All rights reserved. > +# Copyright (c) 2011-2017, ARM Limited. All rights reserved. > # > # This program and the accompanying materials > # are licensed and made available under the terms and conditions of the BSD License > @@ -48,6 +48,7 @@ [LibraryClasses.common] > NorFlashPlatformLib|ArmPlatformPkg/ArmVExpressPkg/Library/NorFlashArmVExpressLib/NorFlashArmVExpressLib.inf > !ifdef EDK2_ENABLE_PL111 > LcdPlatformLib|ArmPlatformPkg/ArmVExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmVExpressLib.inf > + LcdHwLib|ArmPlatformPkg/Drivers/PL111Lcd/PL111Lcd.inf > !endif > > TimerLib|ArmPkg/Library/ArmArchTimerLib/ArmArchTimerLib.inf > @@ -269,7 +270,7 @@ [Components.common] > ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.inf > ArmPkg/Drivers/TimerDxe/TimerDxe.inf > !ifdef EDK2_ENABLE_PL111 > - ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/PL111LcdGraphicsOutputDxe.inf > + ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.inf > !endif > ArmPlatformPkg/Drivers/SP805WatchdogDxe/SP805WatchdogDxe.inf > > diff --git a/Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.fdf b/Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.fdf > index cb9a89ef0c7f9930c4e78148c90072e364c4fa2e..9bdd71b21acd0d4bc2a5bf6947b649d7cce57861 100644 > --- a/Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.fdf > +++ b/Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.fdf > @@ -1,5 +1,5 @@ > # > -# Copyright (c) 2012-2015, ARM Limited. All rights reserved. > +# Copyright (c) 2012-2017, ARM Limited. All rights reserved. > # Copyright (c) 2015, Intel Corporation. All rights reserved.
> # > # This program and the accompanying materials > @@ -97,8 +97,8 @@ [FV.FvMain] > INF ArmPkg/Drivers/ArmGic/ArmGicDxe.inf > INF ArmPkg/Drivers/TimerDxe/TimerDxe.inf > INF ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.inf > - #INF ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/PL111LcdGraphicsOutputDxe.inf > - INF ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/HdLcdGraphicsOutputDxe.inf > + > + INF ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.inf > INF ArmPlatformPkg/Drivers/SP805WatchdogDxe/SP805WatchdogDxe.inf > > # > diff --git a/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.fdf b/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.fdf > index 1084eda3d367e727fa9428cfe306a060e2cb57b9..ee27e6b69ee815ff6499b4801941f64c6dac4051 100644 > --- a/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.fdf > +++ b/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.fdf > @@ -1,5 +1,5 @@ > # > -# Copyright (c) 2011 - 2015, ARM Limited. All rights reserved. > +# Copyright (c) 2011 - 2017, ARM Limited. All rights reserved. > # > # This program and the accompanying materials > # are licensed and made available under the terms and conditions of the BSD License > @@ -114,7 +114,7 @@ [FV.FvMain] > INF ArmPkg/Drivers/TimerDxe/TimerDxe.inf > INF ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.inf > !ifdef EDK2_ENABLE_PL111 > - INF ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/PL111LcdGraphicsOutputDxe.inf > + INF ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.inf > !endif > INF ArmPlatformPkg/Drivers/SP805WatchdogDxe/SP805WatchdogDxe.inf > > -- > Guid("CE165669-3EF3-493F-B85D-6190EE5B9759") >