public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Gary Lin <glin@suse.com>
To: edk2-devel@lists.01.org
Cc: Jaben Carsey <jaben.carsey@intel.com>, Ruiyu Ni <ruiyu.ni@intel.com>
Subject: [PATCH] ShellPkg/UefiShellDebug1CommandsLib: Remove EFIAPI from Compress()
Date: Thu, 26 Oct 2017 14:53:29 +0800	[thread overview]
Message-ID: <20171026065329.32311-1-glin@suse.com> (raw)

> ShellPkg/Library/UefiShellDebug1CommandsLib/Compress.h:32:1: warning: type of ‘Compress’ does not match original declaration
> [-Wlto-type-mismatch]
>  Compress (
>  ^
> ShellPkg/Library/UefiShellDebug1CommandsLib/Compress.c:1319:1: note: ‘Compress’ was previously declared here
>  Compress (
>  ^

Gcc complains the mismatch of the declaration of Compress(). Since EFIAPI
was removed from Compress() on purpose(*), remove EFIAPI from Compress()
in the header to match the declaration.

* c4e74e9b814cfb4b51cf832f3bb218cd2aba348b
  ShellPkg/UefiShellDebug1CommandsLib: Remove unnecessary EFIAPI

Cc: Jaben Carsey <jaben.carsey@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Gary Lin <glin@suse.com>
---
 ShellPkg/Library/UefiShellDebug1CommandsLib/Compress.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/Compress.h b/ShellPkg/Library/UefiShellDebug1CommandsLib/Compress.h
index 39a997178f..7fe844e212 100644
--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/Compress.h
+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/Compress.h
@@ -28,7 +28,6 @@
   @retval EFI_BUFFER_TOO_SMALL  The buffer was too small.  DstSize is required.
 **/
 EFI_STATUS
-EFIAPI
 Compress (
   IN      VOID    *SrcBuffer,
   IN      UINT64  SrcSize,
-- 
2.14.2



             reply	other threads:[~2017-10-26  6:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-26  6:53 Gary Lin [this message]
2017-10-26  7:18 ` [PATCH] ShellPkg/UefiShellDebug1CommandsLib: Remove EFIAPI from Compress() Ni, Ruiyu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171026065329.32311-1-glin@suse.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox