* [PATCH] ShellPkg/UefiShellDebug1CommandsLib: Remove EFIAPI from Compress()
@ 2017-10-26 6:53 Gary Lin
2017-10-26 7:18 ` Ni, Ruiyu
0 siblings, 1 reply; 2+ messages in thread
From: Gary Lin @ 2017-10-26 6:53 UTC (permalink / raw)
To: edk2-devel; +Cc: Jaben Carsey, Ruiyu Ni
> ShellPkg/Library/UefiShellDebug1CommandsLib/Compress.h:32:1: warning: type of ‘Compress’ does not match original declaration
> [-Wlto-type-mismatch]
> Compress (
> ^
> ShellPkg/Library/UefiShellDebug1CommandsLib/Compress.c:1319:1: note: ‘Compress’ was previously declared here
> Compress (
> ^
Gcc complains the mismatch of the declaration of Compress(). Since EFIAPI
was removed from Compress() on purpose(*), remove EFIAPI from Compress()
in the header to match the declaration.
* c4e74e9b814cfb4b51cf832f3bb218cd2aba348b
ShellPkg/UefiShellDebug1CommandsLib: Remove unnecessary EFIAPI
Cc: Jaben Carsey <jaben.carsey@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Gary Lin <glin@suse.com>
---
ShellPkg/Library/UefiShellDebug1CommandsLib/Compress.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/Compress.h b/ShellPkg/Library/UefiShellDebug1CommandsLib/Compress.h
index 39a997178f..7fe844e212 100644
--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/Compress.h
+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/Compress.h
@@ -28,7 +28,6 @@
@retval EFI_BUFFER_TOO_SMALL The buffer was too small. DstSize is required.
**/
EFI_STATUS
-EFIAPI
Compress (
IN VOID *SrcBuffer,
IN UINT64 SrcSize,
--
2.14.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ShellPkg/UefiShellDebug1CommandsLib: Remove EFIAPI from Compress()
2017-10-26 6:53 [PATCH] ShellPkg/UefiShellDebug1CommandsLib: Remove EFIAPI from Compress() Gary Lin
@ 2017-10-26 7:18 ` Ni, Ruiyu
0 siblings, 0 replies; 2+ messages in thread
From: Ni, Ruiyu @ 2017-10-26 7:18 UTC (permalink / raw)
To: Gary Lin, edk2-devel@lists.01.org; +Cc: Carsey, Jaben
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
Thanks/Ray
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Gary Lin
> Sent: Thursday, October 26, 2017 2:53 PM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ruiyu <ruiyu.ni@intel.com>
> Subject: [edk2] [PATCH] ShellPkg/UefiShellDebug1CommandsLib: Remove
> EFIAPI from Compress()
>
> > ShellPkg/Library/UefiShellDebug1CommandsLib/Compress.h:32:1: warning:
> > type of ‘Compress’ does not match original declaration
> > [-Wlto-type-mismatch] Compress ( ^
> > ShellPkg/Library/UefiShellDebug1CommandsLib/Compress.c:1319:1: note:
> > ‘Compress’ was previously declared here Compress ( ^
>
> Gcc complains the mismatch of the declaration of Compress(). Since EFIAPI
> was removed from Compress() on purpose(*), remove EFIAPI from
> Compress() in the header to match the declaration.
>
> * c4e74e9b814cfb4b51cf832f3bb218cd2aba348b
> ShellPkg/UefiShellDebug1CommandsLib: Remove unnecessary EFIAPI
>
> Cc: Jaben Carsey <jaben.carsey@intel.com>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Gary Lin <glin@suse.com>
> ---
> ShellPkg/Library/UefiShellDebug1CommandsLib/Compress.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/Compress.h
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/Compress.h
> index 39a997178f..7fe844e212 100644
> --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/Compress.h
> +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/Compress.h
> @@ -28,7 +28,6 @@
> @retval EFI_BUFFER_TOO_SMALL The buffer was too small. DstSize is
> required.
> **/
> EFI_STATUS
> -EFIAPI
> Compress (
> IN VOID *SrcBuffer,
> IN UINT64 SrcSize,
> --
> 2.14.2
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-10-26 7:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-26 6:53 [PATCH] ShellPkg/UefiShellDebug1CommandsLib: Remove EFIAPI from Compress() Gary Lin
2017-10-26 7:18 ` Ni, Ruiyu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox