From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::244; helo=mail-wm0-x244.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x244.google.com (mail-wm0-x244.google.com [IPv6:2a00:1450:400c:c09::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 00166203525FD for ; Thu, 26 Oct 2017 06:07:35 -0700 (PDT) Received: by mail-wm0-x244.google.com with SMTP id q124so7916568wmb.0 for ; Thu, 26 Oct 2017 06:11:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=btxMkY+X1SOJfOBHnxVihkGcRtduScxVMWJ62NZA7TY=; b=UJJAHqroTamSzD0Vz8uH6qclJsSTc8GiPTYxL/nvcx7bjmZpdfEIjDvaEaFbk4sKJA FGEGCEMQWeowIL5/jIEPhV+jv14imMesp6m3W0xGd04rwDQriwpZcxX2PWRO57MWjhdq JZghNk0lQ7xecFIxLO4aKXjm3efZm7QeSIDFU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=btxMkY+X1SOJfOBHnxVihkGcRtduScxVMWJ62NZA7TY=; b=hpSNDA1cr0hjx8s4TuwDSiUjdM7g0ZBg9cbAnyfsmkFgfaJFgMOcSswaBDBlfXk/ZX GOensUG5Yosvc/+Uvn70Z08sRcvEJcf3KFNlHaPXNwlS8z7HhWWYeIeOU2pk1oSa8n8C 8H/Gd/BqQAP5xtFe/LHlmg0kKpN3JlftM5doX0PsA1cpq6V0CALtoRMcomMnduhjLS19 TX8E8BF3AlrEJlZgTJDYHesgq8y3j0X9cC632UdSgp1D/uAg9VhoJsrDBRg3wJ44aP5z eJ74tj/KuO/CUNvYCMh/dW1U1e7NESrYUi1ZWrkKZECyFFQBU0yxwxBTEU6vK6WLzF8A fa0g== X-Gm-Message-State: AMCzsaUrAGl3MBbVwSwbD2fsQrqpnE50uROY4dc1Ew15P4BNk7uPshDQ dw9DpB86c/xg9Gk0HMtpiGMSPQ== X-Google-Smtp-Source: ABhQp+Sc8QYVGM6UrtIMS4zeyAfPBxLnnHP0rN9sDmdSl1Fqoq10WpxUkw0QjwuW+v9LwolZfw6Zew== X-Received: by 10.28.206.142 with SMTP id e136mr1683056wmg.27.1509023480711; Thu, 26 Oct 2017 06:11:20 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id u4sm5233830wre.1.2017.10.26.06.11.19 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 26 Oct 2017 06:11:19 -0700 (PDT) Date: Thu, 26 Oct 2017 14:11:17 +0100 From: Leif Lindholm To: Marcin Wojtas Cc: edk2-devel@lists.01.org, ard.biesheuvel@linaro.org, nadavh@marvell.com, neta@marvell.com, kostap@marvell.com, jinghua@marvell.com, jsd@semihalf.com Message-ID: <20171026131117.pnutgjmhrr52b4ng@bivouac.eciton.net> References: <1508980777-29006-1-git-send-email-mw@semihalf.com> <1508980777-29006-3-git-send-email-mw@semihalf.com> MIME-Version: 1.0 In-Reply-To: <1508980777-29006-3-git-send-email-mw@semihalf.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [platforms: PATCH 02/10] Marvell/Drivers: MvI2cDxe: Fix returning status in MvI2cStartRequest X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Oct 2017 13:07:36 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Oct 26, 2017 at 03:19:29AM +0200, Marcin Wojtas wrote: > In MvI2cStartRequest the status was assigned to the variable > without dereferencing a pointer. Fix it. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Marcin Wojtas > --- > Platform/Marvell/Drivers/I2c/MvI2cDxe/MvI2cDxe.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Platform/Marvell/Drivers/I2c/MvI2cDxe/MvI2cDxe.c b/Platform/Marvell/Drivers/I2c/MvI2cDxe/MvI2cDxe.c > index 7faf1f7..8ed96f0 100755 > --- a/Platform/Marvell/Drivers/I2c/MvI2cDxe/MvI2cDxe.c > +++ b/Platform/Marvell/Drivers/I2c/MvI2cDxe/MvI2cDxe.c > @@ -631,7 +631,7 @@ MvI2cStartRequest ( > } > > if (I2cStatus != NULL) > - I2cStatus = EFI_SUCCESS; > + *I2cStatus = Status; Oh, that's horrible! And only did not generate warnings because EFI_SUCCESS is 0. However, you also change from setting *I2cStatus to Status instead of EFI_SUCCESS. This should be mentioned in commit message. / Leif > if (Event != NULL) > gBS->SignalEvent(Event); > return EFI_SUCCESS; > -- > 2.7.4 >