From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c0c::241; helo=mail-wr0-x241.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr0-x241.google.com (mail-wr0-x241.google.com [IPv6:2a00:1450:400c:c0c::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 297E9203525FD for ; Thu, 26 Oct 2017 06:23:12 -0700 (PDT) Received: by mail-wr0-x241.google.com with SMTP id j15so3152660wre.8 for ; Thu, 26 Oct 2017 06:26:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=c9sgup6JXHtgl9ppNkWCWenpb3Wegys9vzBjzRkaCfY=; b=cVYJL2qbd3mvjHseym5dzEZm62bnOHn/4i3NiZFn67CE/Xp2oePog91DhrOlEmXvSd BczvbghfLdgz++MjsdJrVhV9vTNSNexdQ6llnaWu+YaFcKtKGPpjvG8O7brIjzNOVhjc g8DWzvBu7P1guv29GuaPZOOvlRVjhG4+hzxxk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=c9sgup6JXHtgl9ppNkWCWenpb3Wegys9vzBjzRkaCfY=; b=nw7pAN3yu+dYxcmlGQXEhI2OSTjY5XAuHkxxqmSCCjuAlkG87zkD8Sh46KA7bHyi79 MhwxSXw0mYL+DQ/ifxOB8IUY+fD4IoHEmqmBh8zfZbn/mF8YYqAbH8w2NufkB7IzabDg SLBH2ibUUaq77NbSs3KOblhapTb/NtII7EWOgSh5FraG3uih13NkxgR3u4AexlU2UODC lK13HKAmRQJEWlGGlxcj37c/YCO117Oh8hJpRwuj/iFIpNJdP/bGEgVdzwSiat2zx1zL CyONv0WPvyZe9w+Ovc2h8yZvAO/16ZxKPpTZyNHOWZZf5VvHKE5pTMJ0pMRsa4jqnlZA VrDg== X-Gm-Message-State: AMCzsaXU0bBSnUwACwvu/dHWacyMFQsEDHZYDFekoVJ/i4yrYevRvI40 5aUZpdcAynF+A0QdZOMwIsfg5w== X-Google-Smtp-Source: ABhQp+QdLd4xkrs0Ux35QelHYDaQ4nkyDusxbsMVDg4yVW5Yr0o7dJNhJVlUxOWwJQJMRypzdjdfcw== X-Received: by 10.223.138.231 with SMTP id z36mr5571486wrz.154.1509024416899; Thu, 26 Oct 2017 06:26:56 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id p7sm1495748wmg.44.2017.10.26.06.26.55 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 26 Oct 2017 06:26:55 -0700 (PDT) Date: Thu, 26 Oct 2017 14:26:54 +0100 From: Leif Lindholm To: Marcin Wojtas Cc: edk2-devel@lists.01.org, ard.biesheuvel@linaro.org, nadavh@marvell.com, neta@marvell.com, kostap@marvell.com, jinghua@marvell.com, jsd@semihalf.com Message-ID: <20171026132654.hrlsmozwndcjady7@bivouac.eciton.net> References: <1508980777-29006-1-git-send-email-mw@semihalf.com> <1508980777-29006-6-git-send-email-mw@semihalf.com> MIME-Version: 1.0 In-Reply-To: <1508980777-29006-6-git-send-email-mw@semihalf.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [platforms: PATCH 05/10] Marvell/Library: MppLib: Disable the stack protector X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Oct 2017 13:23:12 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Oct 26, 2017 at 03:19:32AM +0200, Marcin Wojtas wrote: > From: Ard Biesheuvel > > MppLib may be used very early (in SEC), at which point stack protection > measures are more likely to cause harm than help, given that not even > the UART has been configured to the point where we can complain usefully. > So just disable it. It may. But it is also used by PlatInitDxe. Can we use different build options for SEC and later phases? / Leif > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel > Signed-off-by: Marcin Wojtas > --- > Platform/Marvell/Library/MppLib/MppLib.inf | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Platform/Marvell/Library/MppLib/MppLib.inf b/Platform/Marvell/Library/MppLib/MppLib.inf > index 2de9cd0..1268542 100644 > --- a/Platform/Marvell/Library/MppLib/MppLib.inf > +++ b/Platform/Marvell/Library/MppLib/MppLib.inf > @@ -106,3 +106,6 @@ > gMarvellTokenSpaceGuid.PcdChip3MppSel7 > > gMarvellTokenSpaceGuid.PcdPciESdhci > + > +[BuildOptions] > + *_*_*_CC_FLAGS = -fno-stack-protector > -- > 2.7.4 >