From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c0c::232; helo=mail-wr0-x232.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr0-x232.google.com (mail-wr0-x232.google.com [IPv6:2a00:1450:400c:c0c::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 60204203525F2 for ; Thu, 26 Oct 2017 07:45:42 -0700 (PDT) Received: by mail-wr0-x232.google.com with SMTP id u40so3423357wrf.10 for ; Thu, 26 Oct 2017 07:49:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=iCQ2tk/RBhHo9QIZR5LkdRuf4woPNqty47ev30qGwUs=; b=Oc1KvfcNA6zbuH9l5xp+avD2fN1Zp3b+hNOOJ5lcoxp0OjivZzs9mE5ysna29hj1wt wBpWZ3DrhIrzLNn9owMY2VkFlN/ZNrA3eLPrUxTwds5NvGszKZL6ZJoCvHDXS7Wv81/f hDoosbaacQmzzHnfotliQaqO7mJ7/4iVc54VI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=iCQ2tk/RBhHo9QIZR5LkdRuf4woPNqty47ev30qGwUs=; b=YULapE63J3FGnRoCAATLO2PG820pUxyNXUJrTP+8jMAz4IdF2QEsRzX/pbfxAo3H3H B96J/17R7Ld2Ch9KWCbgHjDvfcrTuo5srGhwlVQ+Lr3TRky3GH4leGGF4qi7L0B70hPF WQjQLz74Bgxn1iIQ+3feGTYCiLIUU9+OeqRmgsKZ0RGGh021Ly112F7LA8bXPBf5yMRd ShaaZvMkQBoHsw70pKZVAqtJBGDMdDJzePUTu8lZAQth/Yp62NSn4BioolXvRiyljLtY T4um6KaywfawgcytpagZcWdg8D6DphiL2KaJErIS5rfCuwf24LVwH9Rlub8GIKenOjQV TJiQ== X-Gm-Message-State: AMCzsaWr0x0ezi1wnNWc/npmY50E2kfwQ7q4SdkzKdHqxscWSnak8NcP jDod0+qcZxdsPnUdDbsQ/aVoPeh0B2g= X-Google-Smtp-Source: ABhQp+RyEOAMBlndkW+qvn4IyEy9nFm7GiREd+hb2VLJGbK3AudL9UUxFFSUsnefyxm3/ei8M1SIig== X-Received: by 10.223.168.66 with SMTP id l60mr5428458wrc.144.1509029367109; Thu, 26 Oct 2017 07:49:27 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id b190sm1650620wma.22.2017.10.26.07.49.26 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 26 Oct 2017 07:49:26 -0700 (PDT) Date: Thu, 26 Oct 2017 15:49:24 +0100 From: Leif Lindholm To: Ard Biesheuvel Cc: edk2-devel@lists.01.org, daniel.thompson@linaro.org, masami.hiramatsu@linaro.org Message-ID: <20171026144924.qiipaka72qgqqqmv@bivouac.eciton.net> References: <20171025175947.22798-1-ard.biesheuvel@linaro.org> <20171025175947.22798-3-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: <20171025175947.22798-3-ard.biesheuvel@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms v2 02/23] Silicon/Socionext: add driver for NETSEC network controller X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Oct 2017 14:45:42 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Oct 25, 2017 at 06:59:26PM +0100, Ard Biesheuvel wrote: > This adds the NetSecDxe driver provided by Socionext, but reworked > extensively to improve compliance with the SimpleNetworkProtocol API, > and to avoid uncached allocations for streaming DMA. So, I see all of my important style comments addressed, including comment improvements, but not much else. Could you answer the questions in my original response? In the meantime, I can give you a Tested-by: Leif Lindholm / Leif