From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::242; helo=mail-wm0-x242.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x242.google.com (mail-wm0-x242.google.com [IPv6:2a00:1450:400c:c09::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0BD8121CEB138 for ; Thu, 26 Oct 2017 07:53:01 -0700 (PDT) Received: by mail-wm0-x242.google.com with SMTP id r196so8930810wmf.2 for ; Thu, 26 Oct 2017 07:56:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=nkKOt6qBnLF+5tWX8kyrQe8DioxBnM/89V090WywsJs=; b=HSetSrxZnpFjoiEo208GR3F7jWdbCrXGOt08ZksvZbkIOAlQ51tmJzm+GerAnkPsnQ kgeWFR/DgdqFmK1rdN/mcD+3YrdvfOcu+YEeBtlwULLyR3uVGP8a71DaXihNk//4EG45 CHb1uX9nQxzbwBwo0muyTf5tsAI/3sX1wqRZM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=nkKOt6qBnLF+5tWX8kyrQe8DioxBnM/89V090WywsJs=; b=A/J2YF8YR/r3nu0mpJXUbcsnHar1NK/Ebz4h3xv/JQEoMt7gry9dKJrWDxF5QEnZDU HL78igeI6n7YX6+smtx1SueCWXacK9BJRZX90X4gNHtRqlc84zYk/7LQDeMJg3ReeqwS eGz/GjIGZK64o7txbClVyuZqboVDdZGjqwkJOxm18cDY4JzUp7Bc/dsJbAN+eYhjrtY1 rACVsJ/hAmBsOWjS+WfrHQtPGpS+F/OGBvWhO+lwROcqpvnvruBaPHbm/cofWMdsT9th i5UXGdns4ptr+zk/P8VZMh2aALSvkKliE+V39zr+vv35ie6dNgplNzcRpm08lJGlL8WR g2tQ== X-Gm-Message-State: AMCzsaWVL/B78ONGbuM6CPFXEu8hSrZuBdsiErYVydpmFHbQKPwDRmua gB8qMKy345qsqXXSIAtPYcuTiw== X-Google-Smtp-Source: ABhQp+TeIeWThuk3mnM6NAZqE5/m5+8G3Z29u1XFbxmtpgXt39PSqfyqF7EOtA35IoktJquSzoh7Qg== X-Received: by 10.28.222.70 with SMTP id v67mr1608483wmg.99.1509029806274; Thu, 26 Oct 2017 07:56:46 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id s67sm1956408wmd.23.2017.10.26.07.56.44 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 26 Oct 2017 07:56:45 -0700 (PDT) Date: Thu, 26 Oct 2017 15:56:43 +0100 From: Leif Lindholm To: Ard Biesheuvel Cc: edk2-devel@lists.01.org, daniel.thompson@linaro.org, masami.hiramatsu@linaro.org Message-ID: <20171026145643.q5e5rdvnza6twhpg@bivouac.eciton.net> References: <20171025175947.22798-1-ard.biesheuvel@linaro.org> <20171025175947.22798-4-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: <20171025175947.22798-4-ard.biesheuvel@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms v2 03/23] Silicon/SynQuacer: add MemoryInitPeiLib implementation X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Oct 2017 14:53:02 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Oct 25, 2017 at 06:59:27PM +0100, Ard Biesheuvel wrote: > Replace the common MemoryInitPeiLib implementation with one that does > not remove the primary FV from the memory map. This is a waste of > memory and TLB entries, given that the OS can no longer use a 1 GB > block mapping to map this memory. > > Since we have our own implementation now, there is no point in using > ArmPlatformLib's GetVirtualMemoryMap() implementation, and we can > simply declare and map the regions directly. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel This one still has commented-out bits of code. I don't really want to have that in master. Are we holding off on pushing until we get the dynamic detection support ove SCMI, and are we expecting to drop the commented-out bits when we do? / Leif