From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c0c::241; helo=mail-wr0-x241.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr0-x241.google.com (mail-wr0-x241.google.com [IPv6:2a00:1450:400c:c0c::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 9DA872035261E for ; Thu, 26 Oct 2017 14:29:44 -0700 (PDT) Received: by mail-wr0-x241.google.com with SMTP id r79so4449384wrb.13 for ; Thu, 26 Oct 2017 14:33:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=pP0L0QSEk0fvhJJWI+f+k7i1vc6VIFJzOm3crw1dIrw=; b=L5+yhY4Z52qYdbUp7Ox2W0g1i/tdpkaY0Cl926isN/tA3DHCws1d/mdr32Ffj/vxES uMwk+HEoRMDYfgxBSbCDqDpGbIr0aiPJSpGEQedGrHn/pfxp9aVWNB7tjrQ3URAPBVkE WRjz3fLKjcMzSbI1QdY66c+9c8oaiVml8J2/I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=pP0L0QSEk0fvhJJWI+f+k7i1vc6VIFJzOm3crw1dIrw=; b=JJf5LgoD80w/jZS86IKbZpJ2N3fJpJE6MyHuh+vFETpSBBeFlqd7L4cQ8e4cmNRTvb cPPmSbpgQCMxel90xM+W7hejIEo/zSn1kLAqlimem2l89oM30jYSrpynPL7yklmZsXjY DIl7FjxfcmCwd5L/oaf5v02lzWOHJXrvB6FruTRHuTR4dY0PhrF7DLnzu7quDIkkdW0x G10CJK8ZnqK4mmEMNB+4Wv2/2UnXxffyy8njM4XcvZtShQr8nWerlCTBoYvEYlhUNpGx f6BzKB387GlaOzQLzVAlvushfwv6292MSfqR/R3fAsq7/XqcmtHOQdV73XmcMclxgP05 eHEQ== X-Gm-Message-State: AMCzsaXoNTv8fEdlStjLjQkP+aK3VDhvp0F6XR+O3rOydRxAp47Akofr 0P8R4qDJrDxXmnwa/cVzOFQ6Yg== X-Google-Smtp-Source: ABhQp+THsQNfsbYlqacDDsXD6TSjn/okHx/ZUpYeW+f1Hpwh7ytfZr0gBw3eMkT1fjMh3+pePYSl2A== X-Received: by 10.223.136.246 with SMTP id g51mr6032496wrg.226.1509053609782; Thu, 26 Oct 2017 14:33:29 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id g16sm6724321wrd.72.2017.10.26.14.33.28 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 26 Oct 2017 14:33:28 -0700 (PDT) Date: Thu, 26 Oct 2017 22:33:27 +0100 From: Leif Lindholm To: Ard Biesheuvel Cc: edk2-devel@lists.01.org, daniel.thompson@linaro.org, masami.hiramatsu@linaro.org Message-ID: <20171026213327.6wunclsgnk63ax7v@bivouac.eciton.net> References: <20171025175947.22798-1-ard.biesheuvel@linaro.org> <20171025175947.22798-20-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: <20171025175947.22798-20-ard.biesheuvel@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms v2 19/23] Platform/SynQuacerEvalBoard: add signed capsule update support X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Oct 2017 21:29:44 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Oct 25, 2017 at 06:59:43PM +0100, Ard Biesheuvel wrote: > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel > --- > Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc | 20 +++++ > Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.fdf | 92 +++++++++++++++++++- > Platform/Socionext/SynQuacerEvalBoard/SystemFirmwareDescriptor/SystemFirmwareDescriptor.aslc | 80 +++++++++++++++++ > Platform/Socionext/SynQuacerEvalBoard/SystemFirmwareDescriptor/SystemFirmwareDescriptor.inf | 46 ++++++++++ > Platform/Socionext/SynQuacerEvalBoard/SystemFirmwareDescriptor/SystemFirmwareDescriptorPei.c | 68 +++++++++++++++ > Platform/Socionext/SynQuacerEvalBoard/SystemFirmwareUpdateConfig/SystemFirmwareUpdateConfig.ini | 25 ++++++ > 6 files changed, 328 insertions(+), 3 deletions(-) > > diff --git a/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc b/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc > index cb6922a5940e..78c92cbca5a2 100644 > --- a/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc > +++ b/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc > @@ -120,6 +120,10 @@ [LibraryClasses.common] > NULL|ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf > NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf > > + BaseCryptLib|CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf > + OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf > + IntrinsicLib|CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf > + > [LibraryClasses.common.SEC] > PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf > BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf > @@ -154,7 +158,15 @@ [LibraryClasses.common.DXE_CORE] > [LibraryClasses.common.DXE_DRIVER] > SecurityManagementLib|MdeModulePkg/Library/DxeSecurityManagementLib/DxeSecurityManagementLib.inf > PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf > + > + # > + # Firmware update > + # > CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.inf > + EdkiiSystemCapsuleLib|SignedCapsulePkg/Library/EdkiiSystemCapsuleLib/EdkiiSystemCapsuleLib.inf > + FmpAuthenticationLib|SecurityPkg/Library/FmpAuthenticationLibPkcs7/FmpAuthenticationLibPkcs7.inf > + PlatformFlashAccessLib|Silicon/Socionext/SynQuacer/Library/SynQuacerPlatformFlashAccessLib/SynQuacerPlatformFlashAccessLib.inf > + IniParsingLib|SignedCapsulePkg/Library/IniParsingLib/IniParsingLib.inf > > # > # PCI > @@ -580,3 +592,11 @@ [Components.common] > > DtPlatformDtbLoaderLib|EmbeddedPkg/Library/DxeDtPlatformDtbLoaderLibDefault/DxeDtPlatformDtbLoaderLibDefault.inf > } > + > + # > + # Firmware update > + # > + Platform/Socionext/SynQuacerEvalBoard/SystemFirmwareDescriptor/SystemFirmwareDescriptor.inf > + MdeModulePkg/Universal/EsrtDxe/EsrtDxe.inf > + SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareReportDxe.inf > + SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareUpdateDxe.inf > diff --git a/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.fdf b/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.fdf > index 1e3258821a8c..337486d361fc 100644 > --- a/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.fdf > +++ b/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.fdf > @@ -27,12 +27,12 @@ > > [FD.BL33_AP_UEFI] > BaseAddress = 0x08200000|gArmTokenSpaceGuid.PcdFdBaseAddress # The base address of the Firmware in NOR Flash. > -Size = 0x001B0000|gArmTokenSpaceGuid.PcdFdSize # The size in bytes of the FLASH Device > +Size = 0x001A0000|gArmTokenSpaceGuid.PcdFdSize # The size in bytes of the FLASH Device > ErasePolarity = 1 > > # This one is tricky, it must be: BlockSize * NumBlocks = Size > BlockSize = 0x00010000 > -NumBlocks = 0x1B > +NumBlocks = 0x1A > > ################################################################################ > # > @@ -50,7 +50,7 @@ [FD.BL33_AP_UEFI] > # > ################################################################################ > > -0x00000000|0x001B0000 > +0x00000000|0x001A0000 There are a few "could you sort please" things I could comment about below, but this is the only thing that really looks out of place to me. Why is this being shrunk as part of this patch? If intentional and related, this really needs a comment in the commit message. / Leif