public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH] MdePkg/Include: fix incorrect structure definition
@ 2017-10-27  1:04 Chris Ruffin
  2017-10-27  1:55 ` Gao, Liming
  0 siblings, 1 reply; 2+ messages in thread
From: Chris Ruffin @ 2017-10-27  1:04 UTC (permalink / raw)
  To: edk2-devel

Fix incorrect structure definitions for PCI_REG_PCIE_SLOT_CONTROL in
PciExpress21.h.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Chris Ruffin <chris.ruffin@intel.com>
---
 MdePkg/Include/IndustryStandard/PciExpress21.h | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/MdePkg/Include/IndustryStandard/PciExpress21.h b/MdePkg/Include/IndustryStandard/PciExpress21.h
index ce9c06a7c6..d90b5975ba 100644
--- a/MdePkg/Include/IndustryStandard/PciExpress21.h
+++ b/MdePkg/Include/IndustryStandard/PciExpress21.h
@@ -182,18 +182,18 @@ typedef union {
 
 typedef union {
   struct {
-    UINT32 AttentionButtonPressed : 1;
-    UINT32 PowerFaultDetected : 1;
-    UINT32 MrlSensorChanged : 1;
-    UINT32 PresenceDetectChanged : 1;
-    UINT32 CommandCompletedInterrupt : 1;
-    UINT32 HotPlugInterrupt : 1;
-    UINT32 AttentionIndicator : 2;
-    UINT32 PowerIndicator : 2;
-    UINT32 PowerController : 1;
-    UINT32 ElectromechanicalInterlock : 1;
-    UINT32 DataLinkLayerStateChanged : 1;
-    UINT32 Reserved : 3;
+    UINT16 AttentionButtonPressed : 1;
+    UINT16 PowerFaultDetected : 1;
+    UINT16 MrlSensorChanged : 1;
+    UINT16 PresenceDetectChanged : 1;
+    UINT16 CommandCompletedInterrupt : 1;
+    UINT16 HotPlugInterrupt : 1;
+    UINT16 AttentionIndicator : 2;
+    UINT16 PowerIndicator : 2;
+    UINT16 PowerController : 1;
+    UINT16 ElectromechanicalInterlock : 1;
+    UINT16 DataLinkLayerStateChanged : 1;
+    UINT16 Reserved : 3;
   } Bits;
   UINT16   Uint16;
 } PCI_REG_PCIE_SLOT_CONTROL;
-- 
2.13.3.windows.1



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] MdePkg/Include: fix incorrect structure definition
  2017-10-27  1:04 [PATCH] MdePkg/Include: fix incorrect structure definition Chris Ruffin
@ 2017-10-27  1:55 ` Gao, Liming
  0 siblings, 0 replies; 2+ messages in thread
From: Gao, Liming @ 2017-10-27  1:55 UTC (permalink / raw)
  To: Ruffin, Chris, edk2-devel@lists.01.org

Chris:
  Ni, Ruiyu has sent this patch yesterday. 

>-----Original Message-----
>From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
>Chris Ruffin
>Sent: Friday, October 27, 2017 9:04 AM
>To: edk2-devel@lists.01.org
>Subject: [edk2] [PATCH] MdePkg/Include: fix incorrect structure definition
>
>Fix incorrect structure definitions for PCI_REG_PCIE_SLOT_CONTROL in
>PciExpress21.h.
>
>Contributed-under: TianoCore Contribution Agreement 1.0
>Signed-off-by: Chris Ruffin <chris.ruffin@intel.com>
>---
> MdePkg/Include/IndustryStandard/PciExpress21.h | 24 ++++++++++++-------
>-----
> 1 file changed, 12 insertions(+), 12 deletions(-)
>
>diff --git a/MdePkg/Include/IndustryStandard/PciExpress21.h
>b/MdePkg/Include/IndustryStandard/PciExpress21.h
>index ce9c06a7c6..d90b5975ba 100644
>--- a/MdePkg/Include/IndustryStandard/PciExpress21.h
>+++ b/MdePkg/Include/IndustryStandard/PciExpress21.h
>@@ -182,18 +182,18 @@ typedef union {
>
> typedef union {
>   struct {
>-    UINT32 AttentionButtonPressed : 1;
>-    UINT32 PowerFaultDetected : 1;
>-    UINT32 MrlSensorChanged : 1;
>-    UINT32 PresenceDetectChanged : 1;
>-    UINT32 CommandCompletedInterrupt : 1;
>-    UINT32 HotPlugInterrupt : 1;
>-    UINT32 AttentionIndicator : 2;
>-    UINT32 PowerIndicator : 2;
>-    UINT32 PowerController : 1;
>-    UINT32 ElectromechanicalInterlock : 1;
>-    UINT32 DataLinkLayerStateChanged : 1;
>-    UINT32 Reserved : 3;
>+    UINT16 AttentionButtonPressed : 1;
>+    UINT16 PowerFaultDetected : 1;
>+    UINT16 MrlSensorChanged : 1;
>+    UINT16 PresenceDetectChanged : 1;
>+    UINT16 CommandCompletedInterrupt : 1;
>+    UINT16 HotPlugInterrupt : 1;
>+    UINT16 AttentionIndicator : 2;
>+    UINT16 PowerIndicator : 2;
>+    UINT16 PowerController : 1;
>+    UINT16 ElectromechanicalInterlock : 1;
>+    UINT16 DataLinkLayerStateChanged : 1;
>+    UINT16 Reserved : 3;
>   } Bits;
>   UINT16   Uint16;
> } PCI_REG_PCIE_SLOT_CONTROL;
>--
>2.13.3.windows.1
>
>_______________________________________________
>edk2-devel mailing list
>edk2-devel@lists.01.org
>https://lists.01.org/mailman/listinfo/edk2-devel


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-10-27  1:51 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-27  1:04 [PATCH] MdePkg/Include: fix incorrect structure definition Chris Ruffin
2017-10-27  1:55 ` Gao, Liming

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox