From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::242; helo=mail-wm0-x242.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x242.google.com (mail-wm0-x242.google.com [IPv6:2a00:1450:400c:c09::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 67B522034A884 for ; Fri, 27 Oct 2017 07:25:30 -0700 (PDT) Received: by mail-wm0-x242.google.com with SMTP id s66so3884607wmf.5 for ; Fri, 27 Oct 2017 07:29:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=MUKV9Cxz+QcIp71IKoL4D10l13XKY3Zce/exfu9yRrA=; b=eDYZOgYydj6XFtd9fvhnbgdInU/uMcZN1KUEWKWpZSfW7XduxdI8+IT66zlc+FBTfV +xWCTWCXiYnUER4/fZHfyqqFyi8cilSAiisYKW4mPAQyfiNRvCZwFkr3Z2zVtdGYvXtl TqGnrjKcLm/cTyOUFSWcoKPkIUr0XC0C0qQsY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=MUKV9Cxz+QcIp71IKoL4D10l13XKY3Zce/exfu9yRrA=; b=ENgb0RUXI5yWqv9YQiLn3Z4v1hD1MGltZ0yN6GyiRUQl/NITqs77542emj+FEjtum+ FxzHc6SXMC8Au1pH6ZD4B49UlTGxWSWtAtbPdrnWjzBXjOZtbNMEveBpGrZgy6IF2q9T PMew6BPgJuwYgCVQU9dt+T0BMGv0JiV5a9A4Swg32Uk33+mHac9iOky8EJbkUce6XyJT QYCxork2aQsc3B9reshfIp/7+vWVB9WfWv+g1scFDfgC7lh4PLtx5CeuVEbgIrckbK4Q gfBkDiCfx4YWuy8f8RR2ZrqEcxkOWAOAFGZB6+32CnSUhLyMnfazJ8e9Yq95RJSGvR6H UehQ== X-Gm-Message-State: AMCzsaUpDX5NnWovR7Ju4govOcl6hhgxmGgTAmZnbUhq8Jhizxo+f6GI LXiHRrEIQKu+SuTZ9+YMH/eEJA== X-Google-Smtp-Source: ABhQp+TVbKid8t0Ss9a0kYc0GT1X45NkxuaFnU6rnaJD54+9GpazHU8Y4cjtSbitdl8M0++b0O+Gmg== X-Received: by 10.28.136.83 with SMTP id k80mr545471wmd.133.1509114556418; Fri, 27 Oct 2017 07:29:16 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id m37sm12046061wrm.4.2017.10.27.07.29.15 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 27 Oct 2017 07:29:15 -0700 (PDT) Date: Fri, 27 Oct 2017 15:29:13 +0100 From: Leif Lindholm To: Marcin Wojtas Cc: edk2-devel@lists.01.org, ard.biesheuvel@linaro.org, nadavh@marvell.com, neta@marvell.com, kostap@marvell.com, jinghua@marvell.com, jsd@semihalf.com Message-ID: <20171027142913.rixgdlmm4o6gpnfx@bivouac.eciton.net> References: <1509066832-5285-1-git-send-email-mw@semihalf.com> <1509066832-5285-3-git-send-email-mw@semihalf.com> MIME-Version: 1.0 In-Reply-To: <1509066832-5285-3-git-send-email-mw@semihalf.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [platforms: PATCH v2 02/10] Marvell/Drivers: MvI2cDxe: Fix returning status in MvI2cStartRequest X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Oct 2017 14:25:30 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Oct 27, 2017 at 03:13:44AM +0200, Marcin Wojtas wrote: > In MvI2cStartRequest the status was assigned to the variable > without dereferencing a pointer. Fix it. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Marcin Wojtas Reviewed-by: Leif Lindholm > --- > Platform/Marvell/Drivers/I2c/MvI2cDxe/MvI2cDxe.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Platform/Marvell/Drivers/I2c/MvI2cDxe/MvI2cDxe.c b/Platform/Marvell/Drivers/I2c/MvI2cDxe/MvI2cDxe.c > index b4599d2..a62383f 100755 > --- a/Platform/Marvell/Drivers/I2c/MvI2cDxe/MvI2cDxe.c > +++ b/Platform/Marvell/Drivers/I2c/MvI2cDxe/MvI2cDxe.c > @@ -627,7 +627,7 @@ MvI2cStartRequest ( > } > > if (I2cStatus != NULL) > - I2cStatus = EFI_SUCCESS; > + *I2cStatus = EFI_SUCCESS; > if (Event != NULL) > gBS->SignalEvent(Event); > return EFI_SUCCESS; > -- > 2.7.4 >