From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::235; helo=mail-wm0-x235.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x235.google.com (mail-wm0-x235.google.com [IPv6:2a00:1450:400c:c09::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id DA60C21F3B412 for ; Sun, 29 Oct 2017 09:47:29 -0700 (PDT) Received: by mail-wm0-x235.google.com with SMTP id r68so11969827wmr.3 for ; Sun, 29 Oct 2017 09:51:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=hiVyYyuIID0S0d/3gavT3HjOd2x+oPxrpH9+c+r88l4=; b=BncgtSzKPiut8yafyq6iqGW3+3hMF+VSzh4tgquRUeDYxKo46lTsDRNXYxmUCLUzsu D9LaCK4OscmnPYBzqRwxD3vPB6cwJveYq82pOJaxkPjMJlfYP/q2nCitzMzI/TSZk50U GHfCHrUmi+GBIeMxXhCgDQRn4GScr+IS/KNZU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=hiVyYyuIID0S0d/3gavT3HjOd2x+oPxrpH9+c+r88l4=; b=AXxWms4jBg5m+iDD0nuYTMQ2GlxUaTJn9a8zjzkkymzgAQe/SHi93loKvojJEYegX6 0GHvge3jqEMJZln52XwXOFIlBH69ZeaPC0JjyitjGUSZn/LOAb4hsYbMBAUpCCLUB/t8 /l6dQC85SSxxAqntfF4QWDqSY0TU1+xhdlL/4DQmxGqQ/xhmhq1vtgIIQ6G+pkEKRshV fadjmJ1VMdx5yn15yXSSEJx0qu3pLKzXT9AsSiA0ShrFNM2PYsWUtJbKGDEoycC2bmrI v530JCDPDMJfc3gpbitEjWStqjdkiluFsebzYVDWWiVyr7Hye58EKqAt67vSIMhs5c5y AjLQ== X-Gm-Message-State: AMCzsaVBHqUHN8q+uZTwb0iESi/Tc0ygD1A5x6lKfwDz9QOtfNBqRF3c i8xCSNz3n0+p4dO1DaOqIv3RcQ== X-Google-Smtp-Source: ABhQp+SqPRLIvRBKZvGFuCLeumYIXD2rd3Ld5tV54PRBYV5oI78Bobo8NSJj0nEItqTR2lCO/hQxIg== X-Received: by 10.28.125.206 with SMTP id y197mr1915031wmc.85.1509295877386; Sun, 29 Oct 2017 09:51:17 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id o135sm3502074wmg.1.2017.10.29.09.51.15 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 29 Oct 2017 09:51:15 -0700 (PDT) Date: Sun, 29 Oct 2017 16:51:13 +0000 From: Leif Lindholm To: Marcin Wojtas Cc: edk2-devel@lists.01.org, ard.biesheuvel@linaro.org, nadavh@marvell.com, neta@marvell.com, kostap@marvell.com, jinghua@marvell.com, jsd@semihalf.com Message-ID: <20171029165113.7ueoun3vgqeh7sfz@bivouac.eciton.net> References: <1509121913-12937-1-git-send-email-mw@semihalf.com> MIME-Version: 1.0 In-Reply-To: <1509121913-12937-1-git-send-email-mw@semihalf.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [platforms: PATCH v3 00/10] Armada 7k/8k - misc improvements pt.2 X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Oct 2017 16:47:30 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Oct 27, 2017 at 06:31:43PM +0200, Marcin Wojtas wrote: > Hi, > > I send v3 with minor fixes, requested in latest review. Details > can be found in the changelog below. > > The patches are available in the github: > https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/misc-upstream-r20171027-2 > > I'm looking forward to your comments or remarks. > > Best regards, > Marcin Remaining patches: Reviewed-by: Leif Lindholm Series pushed as 5fc9a86fb3..f79bce44ac. / Leif > Changelog: > v2 -> v3: > 7/10 > - simplify code by supporting the only real usecase (forcing link up) > > 9/10 > - print actual clock value in DumpCapabilityReg and inform about > its mismatch with original register contents. > - fix typo in functions' declarations > > 1/10, 2/10, 6/10, 8/10 > - add RBs > > v1 -> v2: > 1/10 > - remove unrelated style fix > - fix style around modified functions calls > > 2/10 > - leave original EFI_SUCCESS assignment > > 6/10 > - use descriptively named temporary variable for pin index in a loop > > 7/10 > - use single flag for link up/down > - simplify logic > - correct style > > 8/10 > - mention missing SDR25 in a commit message > > 9/10 > - use new member of SD_MMC_HC_PRIVATE_DATA > to set actual input clock speed and use it for the output > clock configuration > - rewrite commit message > > 3/10, 4/10, 5/10, 10/10 > - add RB's > > Ard Biesheuvel (2): > Marvell/Library: MppLib: Disable the stack protector > Marvell/Library: MppLib: Take 0xFF placeholders into account > > David Greeson (2): > Marvell/Drivers: MvI2cDxe: Abort transaction immediately upon fail > Marvell/Drivers: MvI2cDxe: Reduce bus occupation time > > Joe Zhou (1): > Marvell/Library: MppLib: Prevent overwriting PCD values > > Marcin Wojtas (5): > Marvell/Drivers: MvI2cDxe: Fix returning status in MvI2cStartRequest > Marvell/Drivers: Pp2Dxe: Change settings for the always-up link > Marvell/Drivers: XenonDxe: Fix UHS signalling mode setting > Marvell/Drivers: XenonDxe: Allow overriding base clock frequency > Marvell/Drivers: XenonDxe: Do not modify FIFO default values > > Platform/Marvell/Drivers/I2c/MvI2cDxe/MvI2cDxe.c | 70 ++++++++++++-------- > Platform/Marvell/Drivers/I2c/MvI2cDxe/MvI2cDxe.h | 2 +- > Platform/Marvell/Drivers/Net/Pp2Dxe/Mvpp2Lib.c | 19 ++++++ > Platform/Marvell/Drivers/Net/Pp2Dxe/Mvpp2Lib.h | 5 ++ > Platform/Marvell/Drivers/Net/Pp2Dxe/Pp2Dxe.c | 6 +- > Platform/Marvell/Drivers/SdMmc/XenonDxe/EmmcDevice.c | 6 +- > Platform/Marvell/Drivers/SdMmc/XenonDxe/SdDevice.c | 4 +- > Platform/Marvell/Drivers/SdMmc/XenonDxe/SdMmcPciHcDxe.c | 15 +++-- > Platform/Marvell/Drivers/SdMmc/XenonDxe/SdMmcPciHcDxe.h | 6 ++ > Platform/Marvell/Drivers/SdMmc/XenonDxe/SdMmcPciHci.c | 31 +++++---- > Platform/Marvell/Drivers/SdMmc/XenonDxe/SdMmcPciHci.h | 16 +++-- > Platform/Marvell/Drivers/SdMmc/XenonDxe/XenonSdhci.c | 16 ----- > Platform/Marvell/Library/MppLib/MppLib.c | 35 +++++----- > Platform/Marvell/Library/MppLib/MppLib.inf | 3 + > 14 files changed, 144 insertions(+), 90 deletions(-) > > -- > 2.7.4 >